[8.19] [Discover][Oblt] Display Attributes doc viewer tab for Observability (#222391)#224219
Merged
MiriamAparicio merged 1 commit intoelastic:8.19from Jun 17, 2025
Merged
Conversation
…lastic#222391) Closing elastic#221919 ## Summary In this PR, I'm adding the Attributes doc viwer tab for the **Observability solution view.** The tab should be visible for all discover documents that have any of the following prefixes ``` const attributesPrefixes = ['attributes.', 'scope.attributes.', 'resource.attributes.']; ``` Also, - Group the observability document profile providers into one file > [!IMPORTANT] > The content of the tab is not inlcuded in this PR. it will be part of this [ticket](elastic#221927) ## Additional changes For the existing profiles, logs, traces I updated the condition to check the solution From `params.rootContext.profileId === OBSERVABILITY_ROOT_PROFILE_ID` to `params.rootContext.solutionType === SolutionType.Observability` IMO both are prone to errors. - As I'm extending the root profile, the above statement is not true. it returns the new extended profile ID - Also, if we add more extensions to the root profile and we add another solutionType by mistake the profiles won't work I updated the type https://github.com/elastic/kibana/pull/222391/files#diff-ff7a53f0c234902226be3e34978326985dfffadabb8ae722b6c3fc2115085d11R14 but it might not be enough. ## Test #### How to generate OTel data - Follow https://github.com/smith/elastic-stack-docker-compose?tab=readme-ov-file#elastic-stack-docker-compose #### How to test - Make sure your solution view is Observability - update your `kibana.yaml` ``` discover.experimental.enabledProfiles: - observability-root-profile-with-attributes-tab # if you want to test it with the additional profiles add the following to your `kibana.yaml` - observability-traces-data-source-profile - observability-traces-transaction-document-profile - observability-traces-span-document-profile ``` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit cf57a85)
jennypavlova
approved these changes
Jun 17, 2025
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Module Count
Async chunks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation