Skip to content

Add bulk migrations UI#224334

Merged
Supplementing merged 12 commits intoelastic:mainfrom
Supplementing:add-bulk-migrations-ui
Jun 23, 2025
Merged

Add bulk migrations UI#224334
Supplementing merged 12 commits intoelastic:mainfrom
Supplementing:add-bulk-migrations-ui

Conversation

@Supplementing
Copy link
Contributor

@Supplementing Supplementing commented Jun 17, 2025 •
edited
Loading

Summary

Closes #217619
Closes https://github.com/elastic/ingest-dev/issues/5695

Adds 'Migrate X Agents' option to the bulk actions on the agents table

  • Reuses the existing migrateAgentFlyout component with some adjustments for single vs bulk agents
  • Added a panel to show if the user selects some protected or fleet-server agents alerting them that they will not be able to migrate those agents and they will be omitted.
  • Added conditional rendering of the replace token switch, as per the requirements, its only allowed for single agent migrations.
  • Also adds feature flag gate to UI (API gate was added in [Fleet] Add feature-flag gate for single agent migrations UI/API & bulk migration API #224143)
Screen.Recording.2025-06-18.at.1.37.38.PM.mov

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

N/A

Release Note

  • Added the ability to migrate bulk agents to another cluster via the bulk actions menu of the agent list table (experimental).
@Supplementing Supplementing added backport:skip This PR does not require backporting Team:Fleet Team label for Observability Data Collection Fleet team release_note:feature Makes this part of the condensed release notes labels Jun 17, 2025
@Supplementing Supplementing mentioned this pull request Jun 18, 2025
Merged
7 tasks
Supplementing added a commit that referenced this pull request Jun 18, 2025
@Supplementing @elasticmachine @kibanamachine
[Fleet] Add feature-flag gate for single agent migrations UI/API & bu…
d3f6fb9 
…lk migration API (#224143)

## Summary

Closes elastic/ingest-dev#5694

- Adds a feature flag gate for the `single` agent migration UI and API
- Also gates the bulk migrate `endpoint`, UI will be gated separately as
part of
#224334

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Identify risks

N/A

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@Supplementing Supplementing marked this pull request as ready for review June 18, 2025 19:40
@Supplementing Supplementing requested a review from a team as a code owner June 18, 2025 19:40
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 18, 2025

Pinging @elastic/fleet (Team:Fleet)
@Supplementing
Copy link
Contributor Author

Supplementing commented Jun 18, 2025

@elasticmachine merge upstream
@Supplementing Supplementing requested a review from a team June 18, 2025 20:01
@florent-leborgne florent-leborgne requested a review from a team June 19, 2025 08:25
juliaElastic
juliaElastic approved these changes Jun 23, 2025
View reviewed changes
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@Supplementing
Copy link
Contributor Author

Supplementing commented Jun 23, 2025

@elasticmachine merge upstream
colleenmcginnis
colleenmcginnis reviewed Jun 23, 2025
View reviewed changes
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor suggestions below.
@Supplementing @colleenmcginnis
Apply suggestions from code review
501cade 
Changed verbiage

Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com>
@Supplementing Supplementing enabled auto-merge (squash) June 23, 2025 15:17
@Supplementing Supplementing merged commit c868136 into elastic:main Jun 23, 2025
10 checks passed
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 23, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #7 / Connector renders correctly

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1429 1430 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.8MB 1.8MB +2.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 168.2KB 168.6KB +318.0B
Unknown metric groups

API count

id before after diff
fleet 1558 1559 +1

History
@colleenmcginnis colleenmcginnis mentioned this pull request Jun 23, 2025
Merged
7 tasks
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request Jun 25, 2025
@Supplementing @elasticmachine
@colleenmcginnis @akowalska622
Add bulk migrations UI (elastic#224334)
ef88326 
## Summary

Closes elastic#217619 
Closes elastic/ingest-dev#5695

Adds 'Migrate X Agents' option to the bulk actions on the agents table

- Reuses the existing migrateAgentFlyout component with some adjustments
for single vs bulk agents
- Added a panel to show if the user selects some protected or
fleet-server agents alerting them that they will not be able to migrate
those agents and they will be omitted.
- Added conditional rendering of the `replace token` switch, as per the
requirements, its only allowed for single agent migrations.
- Also adds feature flag gate to UI (API gate was added in
elastic#224143)




https://github.com/user-attachments/assets/7f50168a-a388-4274-b8c8-aa0ce38591ed





### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Identify risks

N/A

# Release Note

- Added the ability to migrate bulk agents to another cluster via the
bulk actions menu of the agent list table (experimental).

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Colleen McGinnis <colleen.j.mcginnis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:feature Makes this part of the condensed release notes Team:Fleet Team label for Observability Data Collection Fleet team v9.1.0

5 participants

@Supplementing @elasticmachine @colleenmcginnis @juliaElastic @kibanamachine