[8.19] [ES|QL] Suggest all operators in the editor (#223503)#224416
Merged
stratoula merged 1 commit intoelastic:8.19from Jun 18, 2025
Merged
[8.19] [ES|QL] Suggest all operators in the editor (#223503)#224416stratoula merged 1 commit intoelastic:8.19from
stratoula merged 1 commit intoelastic:8.19from
Conversation
## Summary Closes elastic#216418 This PR is cleaning up the definitions in order to suggest all operators. We were not suggesting all `LIKE` operators and the `NOT ....` operators. ### Important notes - Now NOT IN works exactly like IN 🎉 <img width="784" alt="image" src="https://github.com/user-attachments/assets/e7e96c2a-0f28-4868-919c-9e5995e5f0ce" /> - LIKE, NOT LIKE, RLIKE, NOT RLIKE work exactly like LIKE (we were suggesting like). After this operator is been selected we are suggesting wrong suggestions but as it is not the purpose of this PR to fix this and this behavior already exists in main I will add it here elastic#176033 and we can follow up. <img width="765" alt="image" src="https://github.com/user-attachments/assets/bfd3a8af-845a-4aed-b903-214d83e073e0" /> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Vadim Kibana <82822460+vadimkibana@users.noreply.github.com> (cherry picked from commit 825172e) # Conflicts: # src/platform/packages/shared/kbn-esql-validation-autocomplete/scripts/generate_function_definitions.ts # src/platform/packages/shared/kbn-esql-validation-autocomplete/src/definitions/generated/operators.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation