Skip to content

[Write Restricted Dashboards] Feature branch #224552

Merged
SiddharthMantri merged 86 commits intomainfrom
security/read-only-dashboards
Dec 12, 2025
Merged

[Write Restricted Dashboards] Feature branch #224552
SiddharthMantri merged 86 commits intomainfrom
security/read-only-dashboards

Conversation

@SiddharthMantri
Copy link
Contributor

@SiddharthMantri SiddharthMantri commented Jun 19, 2025 •
edited
Loading

Closes https://github.com/elastic/kibana-team/issues/808

The respective teams have been raising PRs against this feature branch. Approved PRs merged so far:

Summary

This pull request overhauls the saved object management workflow by introducing the concept of ownership for SOs - specifically enabled for dashboards only at the moment. Owners and administrators can now control a new write-restricted flag on their objects, allowing them to keep work draft/uneditable state before publishing. This change enables users to define who can modify shared objects, providing a crucial capability to manage and share dashboards.

Release note

Kibana Dashboards now support ownership and "write_restricted" mode. Users can now keep dashboards publicly editable or in a write-restricted state until they are ready to publish, giving them more control over who can edit their dashboards, regardless of broader space permissions.

How to test

Serverless

Please reach out to me via slack or in the project channel (#read-only-dashboards) to be invited to the serverless environment where this feature has been enabled.

Local

  • Clone this PR
  • Enable the feature by editing kibana.yml to include
savedObjects.enableAccessControl: true
  • Start ES and Kibana as you would
  • Once started, seed Kibana with sample data. This should create a few dashboards.
  • Navigate to dashboards and create a new one.
  • In the share modal, change the view mode Everybody in the space Can View,
image
  • Now create a new role which grants access to indices and dashboards all. Create a new user and then assign that role to the newly created user.
image
  • Login as the new user and navigate to the dashboard you had initially set as Can view. You'll see that you're not able to edit the dashboard and a warning like
Screenshot 2025-11-28 at 12 30 50

Local (2nd option)

You can also follow the instructions in #224411 that detail how to use the funtional test runner to test this using the test plugin created for this feature.

Risk matrix

  • What happens when your feature is used in a non-default space or a custom
    space? Works as expected
  • What happens when there are multiple Kibana nodes using the same Elasticsearch
    cluster? Does not depend on functionality of kibana nodes
  • What happens when a plugin you depend on is disabled? Changes are in core and security - both are always available
  • What happens when a feature you depend on is disabled? No dependency
  • What happens when a third party integration you depend on is not responding? No third party inregration
  • Does the feature work in Elastic Cloud? Yes
  • Does the feature create a setting that needs to be exposed, or configured
    differently than the default, on the Elastic Cloud? No
  • Is there a significant performance impact that may affect Cloud Kibana
    instances? No
  • Does your feature need to be aware of running in a container? No
  • Does the feature Work with security disabled, or fails gracefully? If disabled, fails gracefully.
  • Are there performance risks associated with your feature? No
  • Could this cause memory to leak in either the browser or server? No
  • Will your feature still work if Kibana is run behind a reverse proxy? Yes
  • Does your feature affect other plugins? No, other plugins could choose to use it if registering a SO with ownable types
  • Are migrations handled gracefully? Does the feature affect old indices or saved objects? Yes, migrations taken care of.
  • Are you using any technologies, protocols, techniques, conventions, libraries, NPM modules, etc. that may be new or unprecedented in Kibana? No
@SiddharthMantri @kibanamachine
@elasticmachine @jeramysoucy
[Read only dashboards] Store Saved object access control information (#…
5487e4c 
…221916)

## Summary

Closes #221752

PR introduces support for storing access control information into saved
object metadata.

By itself this won't do anything in this PR but we'll use it for the
next phase implementing the various APIs for dashboard specific
operations.

Note: Merging into a feature branch before merging into main.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>
@SiddharthMantri
Copy link
Contributor Author

SiddharthMantri commented Jun 19, 2025

@elasticmachine merge upstream
@SiddharthMantri
Copy link
Contributor Author

SiddharthMantri commented Jun 20, 2025

@elasticmachine merge upstream
@SiddharthMantri
Copy link
Contributor Author

SiddharthMantri commented Jun 25, 2025

@elasticmachine merge upstream
@SiddharthMantri
Copy link
Contributor Author

SiddharthMantri commented Jun 26, 2025

@elasticmachine merge upstream
@SiddharthMantri
Copy link
Contributor Author

SiddharthMantri commented Jun 28, 2025

@elasticmachine merge upstream
@SiddharthMantri
Copy link
Contributor Author

SiddharthMantri commented Jul 2, 2025

@elasticmachine merge upstream
@SiddharthMantri
Copy link
Contributor Author

SiddharthMantri commented Jul 10, 2025

@elasticmachine merge upstream
@SiddharthMantri
Copy link
Contributor Author

SiddharthMantri commented Jul 11, 2025

/ci
@SiddharthMantri @elasticmachine
[Read only dashboards] Root level mapping for access control (#224837)
05c241b 
Adds root level mapping for access control object to allow parallel
work.

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@SiddharthMantri
Copy link
Contributor Author

SiddharthMantri commented Jul 11, 2025

@elasticmachine merge upstream
@SiddharthMantri
Copy link
Contributor Author

SiddharthMantri commented Jul 22, 2025

@elasticmachine merge upstream
@SiddharthMantri
Copy link
Contributor Author

SiddharthMantri commented Jul 24, 2025

@elasticmachine merge upstream
@SiddharthMantri
Copy link
Contributor Author

SiddharthMantri commented Jul 29, 2025

@elasticmachine merge upstream
@SiddharthMantri
Copy link
Contributor Author

SiddharthMantri commented Jul 30, 2025

@elasticmachine merge upstream
@SiddharthMantri
Copy link
Contributor Author

SiddharthMantri commented Aug 5, 2025

@elasticmachine merge upstream
@SiddharthMantri
Copy link
Contributor Author

SiddharthMantri commented Dec 11, 2025

@elasticmachine merge upstream
@SiddharthMantri
Copy link
Contributor Author

SiddharthMantri commented Dec 12, 2025

@elasticmachine merge upstream
gsoldevila
gsoldevila approved these changes Dec 12, 2025
View reviewed changes
Copy link
Contributor

@gsoldevila gsoldevila left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving PR to unblock, but I think the current approach to handle access control changes is not very well designed.

The following packages expose methods to register access control endpoints, which could be queried for any SO type.

@kbn/content-management-access-control-server
@kbn/content-management-access-control-public

However, ATM it is dashboards plugin that is calling this methods to make the enpoints available. I think the packages above should be refactored into a plugin. This brings the following advantages:

  • The feature can be enabled / disabled by adding configuration for the new plugin.
  • The plugin is in charge of registering the endpoints (if enabled).
  • The plugin can expose APIs on the client-side (through the setup() and start() contracts), which SO type owners can call to query / modify access control for a given type.

Hoping this can be addressed with follow-up #245254
@SiddharthMantri SiddharthMantri enabled auto-merge (squash) December 12, 2025 10:32
@SiddharthMantri
Copy link
Contributor Author

SiddharthMantri commented Dec 12, 2025

@elasticmachine merge upstream
@SiddharthMantri
Copy link
Contributor Author

SiddharthMantri commented Dec 12, 2025

/ci
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 12, 2025 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dashboard 988 996 +8

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/content-management-access-control-public - 42 +42
@kbn/content-management-access-control-server - 6 +6
@kbn/core-saved-objects-api-server 17 26 +9
@kbn/core-saved-objects-base-server-internal 182 184 +2
@kbn/core-saved-objects-common 40 42 +2
@kbn/core-saved-objects-server 140 155 +15
navigation 58 59 +1
total +77

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 708.8KB 720.9KB +12.0KB
eventAnnotationListing 207.1KB 206.7KB -364.0B
filesManagement 103.0KB 102.7KB -364.0B
graph 372.8KB 372.4KB -364.0B
maps 3.1MB 3.1MB -364.0B
visualizations 343.5KB 343.2KB -364.0B
total +10.3KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/core 908 922 +14
dashboard 11 12 +1
total +15

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 18.0KB 18.0KB +23.0B
navigation 16.6KB 16.6KB +36.0B
share 53.1KB 53.4KB +248.0B
total +307.0B

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/saved-objects-service.html#_mappings

id before after diff
accessControl - 2 +2
Unknown metric groups

API count

id before after diff
@kbn/content-management-access-control-public - 42 +42
@kbn/content-management-access-control-server - 6 +6
@kbn/core-saved-objects-api-server 382 411 +29
@kbn/core-saved-objects-base-server-internal 226 228 +2
@kbn/core-saved-objects-common 73 76 +3
@kbn/core-saved-objects-server 583 627 +44
data 3215 3217 +2
dataViews 1249 1250 +1
navigation 61 62 +1
total +130

History
@SiddharthMantri SiddharthMantri merged commit 7160a45 into main Dec 12, 2025
14 checks passed
@SiddharthMantri SiddharthMantri deleted the security/read-only-dashboards branch December 12, 2025 18:28
seanrathier pushed a commit to seanrathier/kibana that referenced this pull request Dec 15, 2025
@SiddharthMantri @kibanamachine
@elasticmachine @jeramysoucy @azasypkin @TinaHeiligers @kowalczyk-krzysztof @gsoldevila @seanrathier
[Write Restricted Dashboards] Feature branch (elastic#224552)
6628ae6 
Closes elastic/kibana-team#808

The respective teams have been raising PRs against this feature branch.
Approved PRs merged so far:
- elastic#221916
- elastic#224411 
- elastic#239973 
- elastic#241101
- elastic#238468
- elastic#233552
- elastic#228416 
- elastic#241168
- elastic#244746
- elastic#244830

## Summary
This pull request overhauls the saved object management workflow by
introducing the concept of ownership for SOs - specifically enabled for
dashboards only at the moment. Owners and administrators can now control
a new write-restricted flag on their objects, allowing them to keep work
draft/uneditable state before publishing. This change enables users to
define who can modify shared objects, providing a crucial capability to
manage and share dashboards.


## Release note
Kibana Dashboards now support ownership and "write_restricted" mode.
Users can now keep dashboards publicly editable or in a write-restricted
state until they are ready to publish, giving them more control over who
can edit their dashboards, regardless of broader space permissions.


## How to test

### Serverless
Please reach out to me via slack or in the project channel
(#read-only-dashboards) to be invited to the serverless environment
where this feature has been enabled.

### Local

- Clone this PR
- Enable the feature by editing kibana.yml to include 
```
savedObjects.enableAccessControl: true
```
- Start ES and Kibana as you would
- Once started, seed Kibana with sample data. This should create a few
dashboards.
- Navigate to dashboards and create a new one.
- In the share modal, change the view mode `Everybody in the space Can
View`,
<img width="500" height="410" alt="image"
src="https://github.com/user-attachments/assets/b895442f-cce3-41a6-8b47-d206a9afbf43"
/>

- Now create a new role which grants access to indices and dashboards
all. Create a new user and then assign that role to the newly created
user.
<img width="500" height="410" alt="image"
src="https://github.com/user-attachments/assets/dd5251e1-a3b5-41a8-abc1-7e67399d65d2"
/>

- Login as the new user and navigate to the dashboard you had initially
set as `Can view`. You'll see that you're not able to edit the dashboard
and a warning like
<img width="500" height="410" alt="Screenshot 2025-11-28 at 12 30 50"
src="https://github.com/user-attachments/assets/1f71ccc7-9dc6-4a68-9a2c-540aa74e4f03"
/>



###  Local (2nd option)

You can also follow the instructions in
elastic#224411 that detail how to use
the funtional test runner to test this using the test plugin created for
this feature.

### Risk matrix

- What happens when your feature is used in a non-default space or a
custom
  space? Works as expected
- What happens when there are multiple Kibana nodes using the same
Elasticsearch
  cluster? Does not depend on functionality of kibana nodes
- What happens when a plugin you depend on is disabled? Changes are in
core and security - both are always available
- What happens when a feature you depend on is disabled? No dependency
- What happens when a third party integration you depend on is not
responding? No third party inregration
- Does the feature work in Elastic Cloud? Yes
- Does the feature create a setting that needs to be exposed, or
configured
  differently than the default, on the Elastic Cloud? No
- Is there a significant performance impact that may affect Cloud Kibana
  instances? No
- Does your feature need to be aware of running in a container? No
- Does the feature Work with security disabled, or fails gracefully? If
disabled, fails gracefully.
- Are there performance risks associated with your feature? No
- Could this cause memory to leak in either the browser or server? No
- Will your feature still work if Kibana is run behind a reverse proxy?
Yes
- Does your feature affect other plugins? No, other plugins could choose
to use it if registering a SO with ownable types
- Are migrations handled gracefully? Does the feature affect old indices
or saved objects? Yes, migrations taken care of.
- Are you using any technologies, protocols, techniques, conventions,
libraries, NPM modules, etc. that may be new or unprecedented in Kibana?
No

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>
Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>
Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
Co-authored-by: Krzysztof Kowalczyk <krzysztof.kowalczyk@elastic.co>
Co-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co>
@jeramysoucy jeramysoucy mentioned this pull request Dec 16, 2025
Merged
jeramysoucy added a commit that referenced this pull request Dec 16, 2025
@jeramysoucy @rgodfrey-elastic
[Write restricted dashboards] Enable feature by default (#246602)
a927330 
## Summary

This PR enabled the Saved Objects Access Control feature by default in
non-serverless offerings. This feature is what powers write-restricted
dashboards.


### Testing

1. Start ES & KB normally
2. Log in as an admin user and add sample data
3. Navigate to Dashboards and open any of the sample dashboards
4. Click the share button and verify that the access mode options
appears in the share modal
5. Repeat the test but add `savedObjects.enableAccessControl: false` to
the Kibana config, and verify that the access mode does not appear in
the share modal
6. Remove `savedObjects.enableAccessControl: false` from the Kibana
config, start ES & KB in serverless mode, verify that the access mode
does not appear in the share modal

Note: a release note was already added in
#224552

---------

Co-authored-by: Ryan <ryan.godfrey@elastic.co>
@cqliu1 cqliu1 mentioned this pull request Dec 30, 2025
Merged
10 tasks
cqliu1 added a commit that referenced this pull request Dec 30, 2025
@cqliu1
[Navigation] Fix props for icon only top nav menu item (#247634)
27bc476 
## Summary

Closes #247633.

Bug introduced in #224552. This changes the conditional for passing the
correct props to match the condition for rendering this nested component
as a `Fragment` or `EuiTooltip`. This prevents the invalid tooltips
props from being passed on the `Fragment`.


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 30, 2025
@cqliu1
[Navigation] Fix props for icon only top nav menu item (elastic#247634)
3a81cfd 
## Summary

Closes elastic#247633.

Bug introduced in elastic#224552. This changes the conditional for passing the
correct props to match the condition for rendering this nested component
as a `Fragment` or `EuiTooltip`. This prevents the invalid tooltips
props from being passed on the `Fragment`.

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

(cherry picked from commit 27bc476)
kibanamachine added a commit that referenced this pull request Dec 31, 2025
@kibanamachine @cqliu1
[9.3] [Navigation] Fix props for icon only top nav menu item (#247634) (
50eab13 
#247658)

# Backport

This will backport the following commits from `main` to `9.3`:
- [[Navigation] Fix props for icon only top nav menu item
(#247634)](#247634)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Catherine
Liu","email":"catherine.liu@elastic.co"},"sourceCommit":{"committedDate":"2025-12-30T22:58:55Z","message":"[Navigation]
Fix props for icon only top nav menu item (#247634)\n\n##
Summary\n\nCloses #247633.\n\nBug introduced in #224552. This changes
the conditional for passing the\ncorrect props to match the condition
for rendering this nested component\nas a `Fragment` or `EuiTooltip`.
This prevents the invalid tooltips\nprops from being passed on the
`Fragment`.\n\n\n### Checklist\n\nCheck the PR satisfies following
conditions. \n\nReviewers should verify this PR satisfies this list as
well.\n\n- [ ] Any text added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[
]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas
added for features that require explanation or tutorials\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [ ] If a plugin
configuration key changed, check if it needs to be\nallowlisted in the
cloud and added to the
[docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n-
[ ] This was checked for breaking HTTP API changes, and any
breaking\nchanges have been approved by the breaking-change committee.
The\n`release_note:breaking` label should be applied in these
situations.\n- [ ] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n- [ ] The PR description includes the
appropriate Release Notes section,\nand the correct `release_note:*`
label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n-
[ ] Review the
[backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand
apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this
PR introduce any risks? For example, consider risks like hard\nto test
bugs, performance regression, potential of data loss.\n\nDescribe the
risk, its severity, and mitigation for each identified\nrisk. Invite
stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See
some
risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n-
[ ]
...","sha":"27bc476a2517bd413bae0b5eb7c87c0816db2163","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Dashboard","Team:Presentation","loe:small","release_note:skip","impact:low","Team:SharedUX","backport:version","v9.3.0","v9.4.0"],"title":"[Navigation]
Fix props for icon only top nav menu
item","number":247634,"url":"https://github.com/elastic/kibana/pull/247634","mergeCommit":{"message":"[Navigation]
Fix props for icon only top nav menu item (#247634)\n\n##
Summary\n\nCloses #247633.\n\nBug introduced in #224552. This changes
the conditional for passing the\ncorrect props to match the condition
for rendering this nested component\nas a `Fragment` or `EuiTooltip`.
This prevents the invalid tooltips\nprops from being passed on the
`Fragment`.\n\n\n### Checklist\n\nCheck the PR satisfies following
conditions. \n\nReviewers should verify this PR satisfies this list as
well.\n\n- [ ] Any text added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[
]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas
added for features that require explanation or tutorials\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [ ] If a plugin
configuration key changed, check if it needs to be\nallowlisted in the
cloud and added to the
[docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n-
[ ] This was checked for breaking HTTP API changes, and any
breaking\nchanges have been approved by the breaking-change committee.
The\n`release_note:breaking` label should be applied in these
situations.\n- [ ] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n- [ ] The PR description includes the
appropriate Release Notes section,\nand the correct `release_note:*`
label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n-
[ ] Review the
[backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand
apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this
PR introduce any risks? For example, consider risks like hard\nto test
bugs, performance regression, potential of data loss.\n\nDescribe the
risk, its severity, and mitigation for each identified\nrisk. Invite
stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See
some
risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n-
[ ]
...","sha":"27bc476a2517bd413bae0b5eb7c87c0816db2163"}},"sourceBranch":"main","suggestedTargetBranches":["9.3"],"targetPullRequestStates":[{"branch":"9.3","label":"v9.3.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/247634","number":247634,"mergeCommit":{"message":"[Navigation]
Fix props for icon only top nav menu item (#247634)\n\n##
Summary\n\nCloses #247633.\n\nBug introduced in #224552. This changes
the conditional for passing the\ncorrect props to match the condition
for rendering this nested component\nas a `Fragment` or `EuiTooltip`.
This prevents the invalid tooltips\nprops from being passed on the
`Fragment`.\n\n\n### Checklist\n\nCheck the PR satisfies following
conditions. \n\nReviewers should verify this PR satisfies this list as
well.\n\n- [ ] Any text added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[
]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas
added for features that require explanation or tutorials\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [ ] If a plugin
configuration key changed, check if it needs to be\nallowlisted in the
cloud and added to the
[docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n-
[ ] This was checked for breaking HTTP API changes, and any
breaking\nchanges have been approved by the breaking-change committee.
The\n`release_note:breaking` label should be applied in these
situations.\n- [ ] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n- [ ] The PR description includes the
appropriate Release Notes section,\nand the correct `release_note:*`
label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n-
[ ] Review the
[backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand
apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this
PR introduce any risks? For example, consider risks like hard\nto test
bugs, performance regression, potential of data loss.\n\nDescribe the
risk, its severity, and mitigation for each identified\nrisk. Invite
stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See
some
risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n-
[ ] ...","sha":"27bc476a2517bd413bae0b5eb7c87c0816db2163"}}]}]
BACKPORT-->

Co-authored-by: Catherine Liu <catherine.liu@elastic.co>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 6, 2026
@cqliu1 @CAWilson94
[Navigation] Fix props for icon only top nav menu item (elastic#247634)
714af40 
## Summary

Closes elastic#247633.

Bug introduced in elastic#224552. This changes the conditional for passing the
correct props to match the condition for rendering this nested component
as a `Fragment` or `EuiTooltip`. This prevents the invalid tooltips
props from being passed on the `Fragment`.


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...
dej611 pushed a commit to dej611/kibana that referenced this pull request Jan 8, 2026
@cqliu1 @dej611
[Navigation] Fix props for icon only top nav menu item (elastic#247634)
dd64106 
## Summary

Closes elastic#247633.

Bug introduced in elastic#224552. This changes the conditional for passing the
correct props to match the condition for rendering this nested component
as a `Fragment` or `EuiTooltip`. This prevents the invalid tooltips
props from being passed on the `Fragment`.


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...
@SiddharthMantri SiddharthMantri mentioned this pull request Jan 9, 2026
Merged
10 tasks
devamanv pushed a commit to devamanv/kibana that referenced this pull request Jan 12, 2026
@cqliu1 @devamanv
[Navigation] Fix props for icon only top nav menu item (elastic#247634)
061c1d8 
## Summary

Closes elastic#247633.

Bug introduced in elastic#224552. This changes the conditional for passing the
correct props to match the condition for rendering this nested component
as a `Fragment` or `EuiTooltip`. This prevents the invalid tooltips
props from being passed on the `Fragment`.


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...
SiddharthMantri added a commit that referenced this pull request Jan 12, 2026
@SiddharthMantri @elasticmachine
[Write restricted dashboards] Enable in serverless (#248410)
065932e 
## Summary

Enables write restricted dashboards
#224552 in serverless production.


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
tsullivan pushed a commit that referenced this pull request Jan 12, 2026
@SiddharthMantri @elasticmachine @tsullivan
[Write restricted dashboards] Enable in serverless (#248410)
e03656d 
## Summary

Enables write restricted dashboards
#224552 in serverless production.


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@florent-leborgne florent-leborgne added the Feature:Dashboard Dashboard related features label Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting ci:build-serverless-image ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project Feature:Dashboard Dashboard related features release_note:feature Makes this part of the condensed release notes v9.3.0