[Search] fix: move app menu z index down#224708
Merged
TattdCodeMonkey merged 1 commit intoelastic:mainfrom Jun 20, 2025
Merged
Conversation
Currently the app menu z index is header - 1, which makes it below the header and standard flyout, but it is then above the embeddable dev console which is level1 - 2 to not conflict with flyouts. Updating the AppMenuBar to be header - 10 (990) here to give more flexibility for other layers specifically the embeddable dev console to have a z index between the AppMenuBar and flyouts.
TattdCodeMonkey
added
release_note:fix
v9.0.0
Team:Search
backport:version
Contributor
|
Starting backport for target branches: 8.19, 9.0 |
Contributor
💚 Build Succeeded
Metrics [docs]Page load bundle
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 20, 2025
## Summary Currently the app menu z index is header - 1, which makes it below the header and standard flyout, but it is then above the embeddable dev console which is level1 - 2 to not conflict with flyouts. Updating the AppMenuBar to be header - 10 (990) here to give more flexibility for other layers specifically the embeddable dev console to have a z index between the AppMenuBar and flyouts. This is fixing an issue seen when using the search solution navigation where the header actions are put into an additional header that is not accounted for in the fixed header offset. Which then causes the embedded dev console to render below the AppMenu bar and be more difficult to close:  With this change the `AppMenuBar` is moved down to allow the embedded dev console room to open above. The other option would be to introduce a CSS variable for the height of the `AppMenuBar` when it's rendered and update the embedded dev console to account for that height as well as the `--euiFixedHeadersOffset` with it's total maximum height. After fix:  ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit f72bf85)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 20, 2025
## Summary Currently the app menu z index is header - 1, which makes it below the header and standard flyout, but it is then above the embeddable dev console which is level1 - 2 to not conflict with flyouts. Updating the AppMenuBar to be header - 10 (990) here to give more flexibility for other layers specifically the embeddable dev console to have a z index between the AppMenuBar and flyouts. This is fixing an issue seen when using the search solution navigation where the header actions are put into an additional header that is not accounted for in the fixed header offset. Which then causes the embedded dev console to render below the AppMenu bar and be more difficult to close:  With this change the `AppMenuBar` is moved down to allow the embedded dev console room to open above. The other option would be to introduce a CSS variable for the height of the `AppMenuBar` when it's rendered and update the embedded dev console to account for that height as well as the `--euiFixedHeadersOffset` with it's total maximum height. After fix:  ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit f72bf85)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 20, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [[Search] fix: move app menu z index down (#224708)](#224708) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Rodney Norris","email":"rodney.norris@elastic.co"},"sourceCommit":{"committedDate":"2025-06-20T16:08:29Z","message":"[Search] fix: move app menu z index down (#224708)\n\n## Summary\n\nCurrently the app menu z index is header - 1, which makes it below the\nheader and standard flyout, but it is then above the embeddable dev\nconsole which is level1 - 2 to not conflict with flyouts.\n\nUpdating the AppMenuBar to be header - 10 (990) here to give more\nflexibility for other layers specifically the embeddable dev console to\nhave a z index between the AppMenuBar and flyouts.\n\nThis is fixing an issue seen when using the search solution navigation\nwhere the header actions are put into an additional header that is not\naccounted for in the fixed header offset. Which then causes the embedded\ndev console to render below the AppMenu bar and be more difficult to\nclose:\n\n\n\n\nWith this change the `AppMenuBar` is moved down to allow the embedded\ndev console room to open above. The other option would be to introduce a\nCSS variable for the height of the `AppMenuBar` when it's rendered and\nupdate the embedded dev console to account for that height as well as\nthe `--euiFixedHeadersOffset` with it's total maximum height.\n\nAfter fix:\n\n\n\n### Checklist\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"f72bf857e70ca0d1c507351d2559e2c38b2f246c","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:Search","backport:version","v9.1.0","v8.19.0"],"title":"[Search] fix: move app menu z index down","number":224708,"url":"https://github.com/elastic/kibana/pull/224708","mergeCommit":{"message":"[Search] fix: move app menu z index down (#224708)\n\n## Summary\n\nCurrently the app menu z index is header - 1, which makes it below the\nheader and standard flyout, but it is then above the embeddable dev\nconsole which is level1 - 2 to not conflict with flyouts.\n\nUpdating the AppMenuBar to be header - 10 (990) here to give more\nflexibility for other layers specifically the embeddable dev console to\nhave a z index between the AppMenuBar and flyouts.\n\nThis is fixing an issue seen when using the search solution navigation\nwhere the header actions are put into an additional header that is not\naccounted for in the fixed header offset. Which then causes the embedded\ndev console to render below the AppMenu bar and be more difficult to\nclose:\n\n\n\n\nWith this change the `AppMenuBar` is moved down to allow the embedded\ndev console room to open above. The other option would be to introduce a\nCSS variable for the height of the `AppMenuBar` when it's rendered and\nupdate the embedded dev console to account for that height as well as\nthe `--euiFixedHeadersOffset` with it's total maximum height.\n\nAfter fix:\n\n\n\n### Checklist\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"f72bf857e70ca0d1c507351d2559e2c38b2f246c"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.19"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224708","number":224708,"mergeCommit":{"message":"[Search] fix: move app menu z index down (#224708)\n\n## Summary\n\nCurrently the app menu z index is header - 1, which makes it below the\nheader and standard flyout, but it is then above the embeddable dev\nconsole which is level1 - 2 to not conflict with flyouts.\n\nUpdating the AppMenuBar to be header - 10 (990) here to give more\nflexibility for other layers specifically the embeddable dev console to\nhave a z index between the AppMenuBar and flyouts.\n\nThis is fixing an issue seen when using the search solution navigation\nwhere the header actions are put into an additional header that is not\naccounted for in the fixed header offset. Which then causes the embedded\ndev console to render below the AppMenu bar and be more difficult to\nclose:\n\n\n\n\nWith this change the `AppMenuBar` is moved down to allow the embedded\ndev console room to open above. The other option would be to introduce a\nCSS variable for the height of the `AppMenuBar` when it's rendered and\nupdate the embedded dev console to account for that height as well as\nthe `--euiFixedHeadersOffset` with it's total maximum height.\n\nAfter fix:\n\n\n\n### Checklist\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"f72bf857e70ca0d1c507351d2559e2c38b2f246c"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Rodney Norris <rodney.norris@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Jun 20, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [[Search] fix: move app menu z index down (#224708)](#224708) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Rodney Norris","email":"rodney.norris@elastic.co"},"sourceCommit":{"committedDate":"2025-06-20T16:08:29Z","message":"[Search] fix: move app menu z index down (#224708)\n\n## Summary\n\nCurrently the app menu z index is header - 1, which makes it below the\nheader and standard flyout, but it is then above the embeddable dev\nconsole which is level1 - 2 to not conflict with flyouts.\n\nUpdating the AppMenuBar to be header - 10 (990) here to give more\nflexibility for other layers specifically the embeddable dev console to\nhave a z index between the AppMenuBar and flyouts.\n\nThis is fixing an issue seen when using the search solution navigation\nwhere the header actions are put into an additional header that is not\naccounted for in the fixed header offset. Which then causes the embedded\ndev console to render below the AppMenu bar and be more difficult to\nclose:\n\n\n\n\nWith this change the `AppMenuBar` is moved down to allow the embedded\ndev console room to open above. The other option would be to introduce a\nCSS variable for the height of the `AppMenuBar` when it's rendered and\nupdate the embedded dev console to account for that height as well as\nthe `--euiFixedHeadersOffset` with it's total maximum height.\n\nAfter fix:\n\n\n\n### Checklist\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"f72bf857e70ca0d1c507351d2559e2c38b2f246c","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:Search","backport:version","v9.1.0","v8.19.0"],"title":"[Search] fix: move app menu z index down","number":224708,"url":"https://github.com/elastic/kibana/pull/224708","mergeCommit":{"message":"[Search] fix: move app menu z index down (#224708)\n\n## Summary\n\nCurrently the app menu z index is header - 1, which makes it below the\nheader and standard flyout, but it is then above the embeddable dev\nconsole which is level1 - 2 to not conflict with flyouts.\n\nUpdating the AppMenuBar to be header - 10 (990) here to give more\nflexibility for other layers specifically the embeddable dev console to\nhave a z index between the AppMenuBar and flyouts.\n\nThis is fixing an issue seen when using the search solution navigation\nwhere the header actions are put into an additional header that is not\naccounted for in the fixed header offset. Which then causes the embedded\ndev console to render below the AppMenu bar and be more difficult to\nclose:\n\n\n\n\nWith this change the `AppMenuBar` is moved down to allow the embedded\ndev console room to open above. The other option would be to introduce a\nCSS variable for the height of the `AppMenuBar` when it's rendered and\nupdate the embedded dev console to account for that height as well as\nthe `--euiFixedHeadersOffset` with it's total maximum height.\n\nAfter fix:\n\n\n\n### Checklist\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"f72bf857e70ca0d1c507351d2559e2c38b2f246c"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.19"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224708","number":224708,"mergeCommit":{"message":"[Search] fix: move app menu z index down (#224708)\n\n## Summary\n\nCurrently the app menu z index is header - 1, which makes it below the\nheader and standard flyout, but it is then above the embeddable dev\nconsole which is level1 - 2 to not conflict with flyouts.\n\nUpdating the AppMenuBar to be header - 10 (990) here to give more\nflexibility for other layers specifically the embeddable dev console to\nhave a z index between the AppMenuBar and flyouts.\n\nThis is fixing an issue seen when using the search solution navigation\nwhere the header actions are put into an additional header that is not\naccounted for in the fixed header offset. Which then causes the embedded\ndev console to render below the AppMenu bar and be more difficult to\nclose:\n\n\n\n\nWith this change the `AppMenuBar` is moved down to allow the embedded\ndev console room to open above. The other option would be to introduce a\nCSS variable for the height of the `AppMenuBar` when it's rendered and\nupdate the embedded dev console to account for that height as well as\nthe `--euiFixedHeadersOffset` with it's total maximum height.\n\nAfter fix:\n\n\n\n### Checklist\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"f72bf857e70ca0d1c507351d2559e2c38b2f246c"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Rodney Norris <rodney.norris@elastic.co>
Contributor
|
This PR didn't make it into the latest BC for v9.0.3. Updating the labels. |
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
Jun 25, 2025
## Summary Currently the app menu z index is header - 1, which makes it below the header and standard flyout, but it is then above the embeddable dev console which is level1 - 2 to not conflict with flyouts. Updating the AppMenuBar to be header - 10 (990) here to give more flexibility for other layers specifically the embeddable dev console to have a z index between the AppMenuBar and flyouts. This is fixing an issue seen when using the search solution navigation where the header actions are put into an additional header that is not accounted for in the fixed header offset. Which then causes the embedded dev console to render below the AppMenu bar and be more difficult to close:  With this change the `AppMenuBar` is moved down to allow the embedded dev console room to open above. The other option would be to introduce a CSS variable for the height of the `AppMenuBar` when it's rendered and update the embedded dev console to account for that height as well as the `--euiFixedHeadersOffset` with it's total maximum height. After fix:  ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently the app menu z index is header - 1, which makes it below the header and standard flyout, but it is then above the embeddable dev console which is level1 - 2 to not conflict with flyouts.
Updating the AppMenuBar to be header - 10 (990) here to give more flexibility for other layers specifically the embeddable dev console to have a z index between the AppMenuBar and flyouts.
This is fixing an issue seen when using the search solution navigation where the header actions are put into an additional header that is not accounted for in the fixed header offset. Which then causes the embedded dev console to render below the AppMenu bar and be more difficult to close:
With this change the
AppMenuBaris moved down to allow the embedded dev console room to open above. The other option would be to introduce a CSS variable for the height of theAppMenuBarwhen it's rendered and update the embedded dev console to account for that height as well as the--euiFixedHeadersOffsetwith it's total maximum height.After fix:
Checklist
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesRelease note
Adjusted
z-indexof app menu header to not conflict with the portable dev console.