[ES|QL] Index editor cell validations#224728
Merged
sddonne merged 6 commits intoelastic:feature/lookup-join-uxfrom Jun 26, 2025
Merged
[ES|QL] Index editor cell validations#224728sddonne merged 6 commits intoelastic:feature/lookup-join-uxfrom
sddonne merged 6 commits intoelastic:feature/lookup-join-uxfrom
Conversation
stratoula
reviewed
Jun 25, 2025
Contributor
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
Just a code review, I didn't test
Comment on lines
50
to
79
| const validateValue = (val: string): string | undefined => { | ||
| if (!columnType) return undefined; | ||
|
|
||
| let validation; | ||
| switch (columnType) { | ||
| case 'number': | ||
| validation = isNaN(Number(val)) | ||
| ? i18n.translate('indexEditor.cellValueInput.validation.number', { | ||
| defaultMessage: 'Value must be a number', | ||
| }) | ||
| : undefined; | ||
| break; | ||
| case 'boolean': | ||
| validation = | ||
| val !== 'true' && val !== 'false' | ||
| ? i18n.translate('indexEditor.cellValueInput.validation.boolean', { | ||
| defaultMessage: 'Value must be true or false', | ||
| }) | ||
| : undefined; | ||
| break; | ||
| default: | ||
| validation = undefined; | ||
| } | ||
| if (validation) { | ||
| notifications.toasts.addDanger({ | ||
| title: validation, | ||
| }); | ||
| } | ||
| return validation; | ||
| }; |
Contributor
There was a problem hiding this comment.
Do we need this to be inside the react component? Why don't we declare it outside as a helper function?
Suggested change
| const validateValue = (val: string): string | undefined => { | |
| if (!columnType) return undefined; | |
| let validation; | |
| switch (columnType) { | |
| case 'number': | |
| validation = isNaN(Number(val)) | |
| ? i18n.translate('indexEditor.cellValueInput.validation.number', { | |
| defaultMessage: 'Value must be a number', | |
| }) | |
| : undefined; | |
| break; | |
| case 'boolean': | |
| validation = | |
| val !== 'true' && val !== 'false' | |
| ? i18n.translate('indexEditor.cellValueInput.validation.boolean', { | |
| defaultMessage: 'Value must be true or false', | |
| }) | |
| : undefined; | |
| break; | |
| default: | |
| validation = undefined; | |
| } | |
| if (validation) { | |
| notifications.toasts.addDanger({ | |
| title: validation, | |
| }); | |
| } | |
| return validation; | |
| }; | |
| const validateValue = (val: string, columnType?: string): string | undefined => { | |
| if (!columnType) { | |
| return undefined; | |
| } | |
| let errorMessage: string | undefined; | |
| switch (columnType) { | |
| case 'number': | |
| if (isNaN(Number(val))) { | |
| errorMessage = i18n.translate('indexEditor.cellValueInput.validation.number', { | |
| defaultMessage: 'Value must be a number', | |
| }); | |
| } | |
| break; | |
| case 'boolean': | |
| if (!['true', 'false'].includes(val)) { | |
| errorMessage = i18n.translate('indexEditor.cellValueInput.validation.boolean', { | |
| defaultMessage: 'Value must be true or false', | |
| }); | |
| } | |
| break; | |
| default: | |
| errorMessage = undefined; | |
| } |
darnautov
reviewed
Jun 25, 2025
| services: { notifications }, | ||
| } = useKibana<KibanaContextExtra>(); | ||
| const [editValue, setEditValue] = useState(value); | ||
| const [error, setError] = useState<string | undefined>(undefined); |
Contributor
There was a problem hiding this comment.
nit
Suggested change
| const [error, setError] = useState<string | undefined>(undefined); | |
| const [error, setError] = useState<string | undefined>(); |
| const [error, setError] = useState<string | undefined>(undefined); | ||
|
|
||
| const columnType = useMemo(() => { | ||
| if (!columns || !columnName) return undefined; |
Contributor
There was a problem hiding this comment.
Suggested change
| if (!columns || !columnName) return undefined; | |
| if (!columns || !columnName) return; |
| import { i18n } from '@kbn/i18n'; | ||
| import { DatatableColumnType } from '@kbn/expressions-plugin/common'; | ||
|
|
||
| export const validateCellValue = ( |
Contributor
There was a problem hiding this comment.
I wonder if we should consider a different approach. What do you think about having a factory for the input component based on the data type? Each component could encapsulate its own validation logic, and potentially a different input UI in the future. For example, we could render EuiNumberInput for number, which provides a better UX out of the box
Contributor
There was a problem hiding this comment.
This is not a bad idea ++
stratoula
approved these changes
Jun 25, 2025
Contributor
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
I didnt test but it looks very nice now
Contributor
💔 Build Failed
Failed CI StepsHistory
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue #207330
Adds simple type validations when editing/adding a new cell in the index editor.