Skip to content

[Response Ops][Reporting] Scheduled report API license check#224737

Merged
ymao1 merged 1 commit intoelastic:mainfrom
ymao1:scheduled-report-api-license-check
Jun 20, 2025
Merged

[Response Ops][Reporting] Scheduled report API license check#224737
ymao1 merged 1 commit intoelastic:mainfrom
ymao1:scheduled-report-api-license-check

Conversation

@ymao1
Copy link
Contributor

@ymao1 ymao1 commented Jun 20, 2025

Summary

Adding license check for list and disable scheduled report APIs

To Verify

  1. Run ES with basic license
  2. Try accessing the scheduled report list and disable APIs from the Dev Console. You should get a 403 error.
@ymao1 ymao1 force-pushed the scheduled-report-api-license-check branch from 3f80f87 to e46c7a3 Compare June 20, 2025 16:30
@ymao1 ymao1 self-assigned this Jun 20, 2025
@ymao1 ymao1 added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// Feature:Reporting:Framework Reporting issues pertaining to the overall framework backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Jun 20, 2025
Copy link
Contributor

@js-jankisalvi js-jankisalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally, lgtm 👍

@ymao1 ymao1 marked this pull request as ready for review June 20, 2025 18:53
@ymao1 ymao1 requested a review from a team as a code owner June 20, 2025 18:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@ymao1 ymao1 merged commit 025aacd into elastic:main Jun 20, 2025
22 checks passed
@ymao1 ymao1 deleted the scheduled-report-api-license-check branch June 20, 2025 18:56
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15785843308

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 24, 2025
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 224737 locally
cc: @ymao1

akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request Jun 25, 2025
…#224737)

## Summary

Adding license check for list and disable scheduled report APIs

## To Verify

1. Run ES with basic license
2. Try accessing the scheduled report list and disable APIs from the Dev
Console. You should get a 403 error.
@ymao1
Copy link
Contributor Author

ymao1 commented Jun 25, 2025

💚 All backports created successfully

Status Branch Result
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

ymao1 added a commit to ymao1/kibana that referenced this pull request Jun 25, 2025
…#224737)

## Summary

Adding license check for list and disable scheduled report APIs

## To Verify

1. Run ES with basic license
2. Try accessing the scheduled report list and disable APIs from the Dev
Console. You should get a 403 error.

(cherry picked from commit 025aacd)
ymao1 added a commit that referenced this pull request Jun 25, 2025
…224737) (#225293)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Response Ops][Reporting] Scheduled report API license check
(#224737)](#224737)

<!--- Backport version: 10.0.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Ying
Mao","email":"ying.mao@elastic.co"},"sourceCommit":{"committedDate":"2025-06-20T18:56:51Z","message":"[Response
Ops][Reporting] Scheduled report API license check (#224737)\n\n##
Summary\n\nAdding license check for list and disable scheduled report
APIs\n\n## To Verify\n\n1. Run ES with basic license\n2. Try accessing
the scheduled report list and disable APIs from the Dev\nConsole. You
should get a 403
error.","sha":"025aacd302d61855e539d7cc0590f53641128944","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","backport
missing","Feature:Reporting:Framework","backport:version","v9.1.0","v8.19.0"],"title":"[Response
Ops][Reporting] Scheduled report API license
check","number":224737,"url":"https://github.com/elastic/kibana/pull/224737","mergeCommit":{"message":"[Response
Ops][Reporting] Scheduled report API license check (#224737)\n\n##
Summary\n\nAdding license check for list and disable scheduled report
APIs\n\n## To Verify\n\n1. Run ES with basic license\n2. Try accessing
the scheduled report list and disable APIs from the Dev\nConsole. You
should get a 403
error.","sha":"025aacd302d61855e539d7cc0590f53641128944"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224737","number":224737,"mergeCommit":{"message":"[Response
Ops][Reporting] Scheduled report API license check (#224737)\n\n##
Summary\n\nAdding license check for list and disable scheduled report
APIs\n\n## To Verify\n\n1. Run ES with basic license\n2. Try accessing
the scheduled report list and disable APIs from the Dev\nConsole. You
should get a 403
error.","sha":"025aacd302d61855e539d7cc0590f53641128944"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:Reporting:Framework Reporting issues pertaining to the overall framework release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.19.0 v9.1.0

4 participants