[Streams 🌊 ] Add loader when datasources are being loaded#225005
Merged
rStelmach merged 3 commits intoelastic:mainfrom Jun 24, 2025
Merged
[Streams 🌊 ] Add loader when datasources are being loaded#225005rStelmach merged 3 commits intoelastic:mainfrom
rStelmach merged 3 commits intoelastic:mainfrom
Conversation
tonyghiani
approved these changes
Jun 24, 2025
Contributor
tonyghiani
left a comment
tonyghiani
left a comment
There was a problem hiding this comment.
LGTM, thanks for the update!
rStelmach
added
backport:version
Contributor
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
tonyghiani
approved these changes
Jun 24, 2025
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 8.19 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 24, 2025
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 24, 2025
…5005) (#225066) # Backport This will backport the following commits from `main` to `8.19`: - [[Streams 🌊 ] Add loader when datasources are being loaded (#225005)](#225005) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Robert Stelmach","email":"60304951+rStelmach@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-06-24T11:59:34Z","message":"[Streams 🌊 ] Add loader when datasources are being loaded (#225005)","sha":"3ec2c7e46e31e82a437ecd71e84525b5934e3b28","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:obs-ux-logs","backport:version","Feature:Streams","v9.1.0","v8.19.0"],"title":"[Streams 🌊 ] Add loader when datasources are being loaded","number":225005,"url":"https://github.com/elastic/kibana/pull/225005","mergeCommit":{"message":"[Streams 🌊 ] Add loader when datasources are being loaded (#225005)","sha":"3ec2c7e46e31e82a437ecd71e84525b5934e3b28"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225005","number":225005,"mergeCommit":{"message":"[Streams 🌊 ] Add loader when datasources are being loaded (#225005)","sha":"3ec2c7e46e31e82a437ecd71e84525b5934e3b28"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Stelmach <60304951+rStelmach@users.noreply.github.com>
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Current behavior
• On first load, the page immediately shows the “No samples” warning, even though the initial sample fetch is still in progress.
What this PR does
• Adds a loading indicator while data sources are being fetched, so users can see that samples are still loading instead of assuming none exist.
Demo
Before:
before.mov
After:
example.mov