[Fleet] Fix export CSV in Agent list#225050
Merged
juliaElastic merged 1 commit intoelastic:mainfrom Jun 25, 2025
Merged
Conversation
botelastic
bot
added
the
Team:Fleet
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
|
jen-huang
approved these changes
Jun 24, 2025
Contributor
jen-huang
left a comment
jen-huang
left a comment
There was a problem hiding this comment.
Small Q for my own curiosity, but otherwise LGTM
| const sort = getSortConfig(sortField, sortOrder) as EsQuerySortValue[]; | ||
|
|
||
| const searchSource: SearchSourceFields = { | ||
| type: 'search', |
Contributor
There was a problem hiding this comment.
I'm curious about what the intention of this type field is. what are valid values?
Contributor
Author
There was a problem hiding this comment.
It's not documented too well, I copied the logic originally from the reporting plugin. It seems something changed, I don't see type used anywhere else in the repo anymore.
Contributor
|
Starting backport for target branches: 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 25, 2025
## Summary Export CSV currently failing with the error `Unknown key for a VALUE_STRING in [type]` <img width="1163" alt="image" src="https://github.com/user-attachments/assets/3935247e-adf3-49d2-aa9f-2ac561a7956e" /> To verify, try exporting in Agent list, and check that the CSV contains the expected rows. <img width="1166" alt="image" src="https://github.com/user-attachments/assets/184976b7-2af5-4929-83e8-9b0cba9f6ae6" /> <img width="1177" alt="image" src="https://github.com/user-attachments/assets/711737c8-d054-4fa3-93c5-8c9749b805fb" /> (cherry picked from commit 3bdd4a8)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 25, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [[Fleet] Fix export CSV in Agent list (#225050)](#225050) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Julia Bardi","email":"90178898+juliaElastic@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-06-25T07:19:52Z","message":"[Fleet] Fix export CSV in Agent list (#225050)\n\n## Summary\n\nExport CSV currently failing with the error `Unknown key for a\nVALUE_STRING in [type]`\n\n<img width=\"1163\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/3935247e-adf3-49d2-aa9f-2ac561a7956e\"\n/>\n\nTo verify, try exporting in Agent list, and check that the CSV contains\nthe expected rows.\n\n<img width=\"1166\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/184976b7-2af5-4929-83e8-9b0cba9f6ae6\"\n/>\n<img width=\"1177\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/711737c8-d054-4fa3-93c5-8c9749b805fb\"\n/>","sha":"3bdd4a8ba162409d7abf2ad390f757552bf8686f","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Fleet","backport:prev-minor","v9.1.0"],"title":"[Fleet] Fix export CSV in Agent list","number":225050,"url":"https://github.com/elastic/kibana/pull/225050","mergeCommit":{"message":"[Fleet] Fix export CSV in Agent list (#225050)\n\n## Summary\n\nExport CSV currently failing with the error `Unknown key for a\nVALUE_STRING in [type]`\n\n<img width=\"1163\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/3935247e-adf3-49d2-aa9f-2ac561a7956e\"\n/>\n\nTo verify, try exporting in Agent list, and check that the CSV contains\nthe expected rows.\n\n<img width=\"1166\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/184976b7-2af5-4929-83e8-9b0cba9f6ae6\"\n/>\n<img width=\"1177\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/711737c8-d054-4fa3-93c5-8c9749b805fb\"\n/>","sha":"3bdd4a8ba162409d7abf2ad390f757552bf8686f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225050","number":225050,"mergeCommit":{"message":"[Fleet] Fix export CSV in Agent list (#225050)\n\n## Summary\n\nExport CSV currently failing with the error `Unknown key for a\nVALUE_STRING in [type]`\n\n<img width=\"1163\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/3935247e-adf3-49d2-aa9f-2ac561a7956e\"\n/>\n\nTo verify, try exporting in Agent list, and check that the CSV contains\nthe expected rows.\n\n<img width=\"1166\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/184976b7-2af5-4929-83e8-9b0cba9f6ae6\"\n/>\n<img width=\"1177\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/711737c8-d054-4fa3-93c5-8c9749b805fb\"\n/>","sha":"3bdd4a8ba162409d7abf2ad390f757552bf8686f"}}]}] BACKPORT--> Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
Jun 25, 2025
## Summary Export CSV currently failing with the error `Unknown key for a VALUE_STRING in [type]` <img width="1163" alt="image" src="https://github.com/user-attachments/assets/3935247e-adf3-49d2-aa9f-2ac561a7956e" /> To verify, try exporting in Agent list, and check that the CSV contains the expected rows. <img width="1166" alt="image" src="https://github.com/user-attachments/assets/184976b7-2af5-4929-83e8-9b0cba9f6ae6" /> <img width="1177" alt="image" src="https://github.com/user-attachments/assets/711737c8-d054-4fa3-93c5-8c9749b805fb" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Export CSV currently failing with the error
Unknown key for a VALUE_STRING in [type]To verify, try exporting in Agent list, and check that the CSV contains the expected rows.