[Dashboard][Controls] Do not recommend adhoc dataviews#225705
Merged
ThomThomson merged 5 commits intoelastic:mainfrom Jul 2, 2025
Merged
[Dashboard][Controls] Do not recommend adhoc dataviews#225705ThomThomson merged 5 commits intoelastic:mainfrom
ThomThomson merged 5 commits intoelastic:mainfrom
Conversation
…ols dataview error handling.
ThomThomson
added
bug
Contributor
Author
|
/ci |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
/ci |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
/ci |
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
kertal
approved these changes
Jul 2, 2025
Member
kertal
left a comment
kertal
left a comment
There was a problem hiding this comment.
Codeowner review, it's just a comment, that makes sense, thx!
nreese
approved these changes
Jul 2, 2025
Contributor
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
kibana-presentation changes LGTM. One recommendation is to document that dataViews$ should not contain adhoc data views in src/platform/packages/shared/presentation/presentation_publishing/interfaces/publishes_data_views.ts.
code review only
Contributor
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 2, 2025
Stops the Dashboard from placing adhoc data views into its published data views list. This fixes a bug where Dashboard would recommend an adhoc data view as the most relevant data view when creating a control. (cherry picked from commit f48e814)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 2, 2025
Stops the Dashboard from placing adhoc data views into its published data views list. This fixes a bug where Dashboard would recommend an adhoc data view as the most relevant data view when creating a control. (cherry picked from commit f48e814)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 2, 2025
#226297) # Backport This will backport the following commits from `main` to `9.1`: - [[Dashboard][Controls] Do not recommend adhoc dataviews (#225705)](#225705) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Devon Thomson","email":"devon.thomson@elastic.co"},"sourceCommit":{"committedDate":"2025-07-02T19:45:45Z","message":"[Dashboard][Controls] Do not recommend adhoc dataviews (#225705)\n\nStops the Dashboard from placing adhoc data views into its published data views list. This fixes a bug where Dashboard would recommend an adhoc data view as the most relevant data view when creating a control.","sha":"f48e8142750669651933711e87f57ff26bb8210b","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Presentation","loe:small","impact:critical","backport:version","v9.1.0","v8.19.0","v9.2.0","v9.0.4"],"title":"[Dashboard][Controls] Do not recommend adhoc dataviews","number":225705,"url":"https://github.com/elastic/kibana/pull/225705","mergeCommit":{"message":"[Dashboard][Controls] Do not recommend adhoc dataviews (#225705)\n\nStops the Dashboard from placing adhoc data views into its published data views list. This fixes a bug where Dashboard would recommend an adhoc data view as the most relevant data view when creating a control.","sha":"f48e8142750669651933711e87f57ff26bb8210b"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19","9.0"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225705","number":225705,"mergeCommit":{"message":"[Dashboard][Controls] Do not recommend adhoc dataviews (#225705)\n\nStops the Dashboard from placing adhoc data views into its published data views list. This fixes a bug where Dashboard would recommend an adhoc data view as the most relevant data view when creating a control.","sha":"f48e8142750669651933711e87f57ff26bb8210b"}},{"branch":"9.0","label":"v9.0.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Devon Thomson <devon.thomson@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Jul 2, 2025
… (#226296) # Backport This will backport the following commits from `main` to `8.19`: - [[Dashboard][Controls] Do not recommend adhoc dataviews (#225705)](#225705) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Devon Thomson","email":"devon.thomson@elastic.co"},"sourceCommit":{"committedDate":"2025-07-02T19:45:45Z","message":"[Dashboard][Controls] Do not recommend adhoc dataviews (#225705)\n\nStops the Dashboard from placing adhoc data views into its published data views list. This fixes a bug where Dashboard would recommend an adhoc data view as the most relevant data view when creating a control.","sha":"f48e8142750669651933711e87f57ff26bb8210b","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Presentation","loe:small","impact:critical","backport:version","v9.1.0","v8.19.0","v9.2.0","v9.0.4"],"title":"[Dashboard][Controls] Do not recommend adhoc dataviews","number":225705,"url":"https://github.com/elastic/kibana/pull/225705","mergeCommit":{"message":"[Dashboard][Controls] Do not recommend adhoc dataviews (#225705)\n\nStops the Dashboard from placing adhoc data views into its published data views list. This fixes a bug where Dashboard would recommend an adhoc data view as the most relevant data view when creating a control.","sha":"f48e8142750669651933711e87f57ff26bb8210b"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19","9.0"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225705","number":225705,"mergeCommit":{"message":"[Dashboard][Controls] Do not recommend adhoc dataviews (#225705)\n\nStops the Dashboard from placing adhoc data views into its published data views list. This fixes a bug where Dashboard would recommend an adhoc data view as the most relevant data view when creating a control.","sha":"f48e8142750669651933711e87f57ff26bb8210b"}},{"branch":"9.0","label":"v9.0.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Devon Thomson <devon.thomson@elastic.co>
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Jul 3, 2025
Stops the Dashboard from placing adhoc data views into its published data views list. This fixes a bug where Dashboard would recommend an adhoc data view as the most relevant data view when creating a control. (cherry picked from commit f48e814) # Conflicts: # src/platform/plugins/shared/controls/public/controls/data_controls/options_list_control/get_options_list_control_factory.tsx
ThomThomson
added a commit
that referenced
this pull request
Jul 3, 2025
#226422) # Backport This will backport the following commits from `main` to `9.0`: - [[Dashboard][Controls] Do not recommend adhoc dataviews (#225705)](#225705) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Devon Thomson","email":"devon.thomson@elastic.co"},"sourceCommit":{"committedDate":"2025-07-02T19:45:45Z","message":"[Dashboard][Controls] Do not recommend adhoc dataviews (#225705)\n\nStops the Dashboard from placing adhoc data views into its published data views list. This fixes a bug where Dashboard would recommend an adhoc data view as the most relevant data view when creating a control.","sha":"f48e8142750669651933711e87f57ff26bb8210b","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Presentation","loe:small","impact:critical","backport:version","v9.1.0","v8.19.0","v9.2.0","v9.0.4"],"title":"[Dashboard][Controls] Do not recommend adhoc dataviews","number":225705,"url":"https://github.com/elastic/kibana/pull/225705","mergeCommit":{"message":"[Dashboard][Controls] Do not recommend adhoc dataviews (#225705)\n\nStops the Dashboard from placing adhoc data views into its published data views list. This fixes a bug where Dashboard would recommend an adhoc data view as the most relevant data view when creating a control.","sha":"f48e8142750669651933711e87f57ff26bb8210b"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/226297","number":226297,"state":"MERGED","mergeCommit":{"sha":"88593381d369a55eff0620015fb75d844e558188","message":"[9.1] [Dashboard][Controls] Do not recommend adhoc dataviews (#225705) (#226297)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.1`:\n- [[Dashboard][Controls] Do not recommend adhoc dataviews\n(#225705)](https://github.com/elastic/kibana/pull/225705)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Devon Thomson <devon.thomson@elastic.co>"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/226296","number":226296,"state":"MERGED","mergeCommit":{"sha":"7a30084256088d181e483760178d9d2cbc3ab65a","message":"[8.19] [Dashboard][Controls] Do not recommend adhoc dataviews (#225705) (#226296)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.19`:\n- [[Dashboard][Controls] Do not recommend adhoc dataviews\n(#225705)](https://github.com/elastic/kibana/pull/225705)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Devon Thomson <devon.thomson@elastic.co>"}},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225705","number":225705,"mergeCommit":{"message":"[Dashboard][Controls] Do not recommend adhoc dataviews (#225705)\n\nStops the Dashboard from placing adhoc data views into its published data views list. This fixes a bug where Dashboard would recommend an adhoc data view as the most relevant data view when creating a control.","sha":"f48e8142750669651933711e87f57ff26bb8210b"}},{"branch":"9.0","label":"v9.0.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
Stops the Dashboard from placing adhoc data views into its published data views list. This fixes a bug where Dashboard would recommend an adhoc data view as the most relevant data view when creating a control.
nreese
added a commit
that referenced
this pull request
Oct 14, 2025
…out in the KQL search bar (#238731) Closes #236288 ### Background #225705 fixed an issue where controls where getting created with adhoc data views. This fix cause regression #236288. Instead of filtering out adhoc data views from dashboard.dataViews$, the fix should occur in the control group level and ignore adhoc data views when suggesting the data view when creating a control. ### Test instructions * install sample web logs and wait until its install - web logs is expected to be default data view * install sample flights data set * create new dashboard * add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT 10` * click into unified search query bar. Verify typeahead is populated from `flights` data view. * Add new control to dashboard. Ensure suggested data view is `Kibana Sample Data Logs` - meaning the control suggested the default data view and not the adhoc flights data view from the lens panel.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2025
…out in the KQL search bar (elastic#238731) Closes elastic#236288 ### Background elastic#225705 fixed an issue where controls where getting created with adhoc data views. This fix cause regression elastic#236288. Instead of filtering out adhoc data views from dashboard.dataViews$, the fix should occur in the control group level and ignore adhoc data views when suggesting the data view when creating a control. ### Test instructions * install sample web logs and wait until its install - web logs is expected to be default data view * install sample flights data set * create new dashboard * add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT 10` * click into unified search query bar. Verify typeahead is populated from `flights` data view. * Add new control to dashboard. Ensure suggested data view is `Kibana Sample Data Logs` - meaning the control suggested the default data view and not the adhoc flights data view from the lens panel. (cherry picked from commit 01e67c3)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2025
…out in the KQL search bar (elastic#238731) Closes elastic#236288 ### Background elastic#225705 fixed an issue where controls where getting created with adhoc data views. This fix cause regression elastic#236288. Instead of filtering out adhoc data views from dashboard.dataViews$, the fix should occur in the control group level and ignore adhoc data views when suggesting the data view when creating a control. ### Test instructions * install sample web logs and wait until its install - web logs is expected to be default data view * install sample flights data set * create new dashboard * add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT 10` * click into unified search query bar. Verify typeahead is populated from `flights` data view. * Add new control to dashboard. Ensure suggested data view is `Kibana Sample Data Logs` - meaning the control suggested the default data view and not the adhoc flights data view from the lens panel. (cherry picked from commit 01e67c3)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2025
…out in the KQL search bar (elastic#238731) Closes elastic#236288 ### Background elastic#225705 fixed an issue where controls where getting created with adhoc data views. This fix cause regression elastic#236288. Instead of filtering out adhoc data views from dashboard.dataViews$, the fix should occur in the control group level and ignore adhoc data views when suggesting the data view when creating a control. ### Test instructions * install sample web logs and wait until its install - web logs is expected to be default data view * install sample flights data set * create new dashboard * add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT 10` * click into unified search query bar. Verify typeahead is populated from `flights` data view. * Add new control to dashboard. Ensure suggested data view is `Kibana Sample Data Logs` - meaning the control suggested the default data view and not the adhoc flights data view from the lens panel. (cherry picked from commit 01e67c3)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2025
…out in the KQL search bar (elastic#238731) Closes elastic#236288 ### Background elastic#225705 fixed an issue where controls where getting created with adhoc data views. This fix cause regression elastic#236288. Instead of filtering out adhoc data views from dashboard.dataViews$, the fix should occur in the control group level and ignore adhoc data views when suggesting the data view when creating a control. ### Test instructions * install sample web logs and wait until its install - web logs is expected to be default data view * install sample flights data set * create new dashboard * add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT 10` * click into unified search query bar. Verify typeahead is populated from `flights` data view. * Add new control to dashboard. Ensure suggested data view is `Kibana Sample Data Logs` - meaning the control suggested the default data view and not the adhoc flights data view from the lens panel. (cherry picked from commit 01e67c3)
kibanamachine
added a commit
that referenced
this pull request
Oct 14, 2025
…tered out in the KQL search bar (#238731) (#238990) # Backport This will backport the following commits from `main` to `9.1`: - [[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar (#238731)](#238731) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-10-14T17:50:51Z","message":"[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar (#238731)\n\nCloses https://github.com/elastic/kibana/issues/236288\n\n### Background\nhttps://github.com//pull/225705 fixed an issue where\ncontrols where getting created with adhoc data views. This fix cause\nregression #236288. Instead of\nfiltering out adhoc data views from dashboard.dataViews$, the fix should\noccur in the control group level and ignore adhoc data views when\nsuggesting the data view when creating a control.\n\n### Test instructions\n* install sample web logs and wait until its install - web logs is\nexpected to be default data view\n* install sample flights data set\n* create new dashboard\n* add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT\n10`\n* click into unified search query bar. Verify typeahead is populated\nfrom `flights` data view.\n* Add new control to dashboard. Ensure suggested data view is `Kibana\nSample Data Logs` - meaning the control suggested the default data view\nand not the adhoc flights data view from the lens panel.","sha":"01e67c3b061e8115c793569b7a8923fcecce9295","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","backport:version","v9.2.0","v9.0.6","v9.3.0","v9.1.6","v8.19.6"],"title":"[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar","number":238731,"url":"https://github.com/elastic/kibana/pull/238731","mergeCommit":{"message":"[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar (#238731)\n\nCloses https://github.com/elastic/kibana/issues/236288\n\n### Background\nhttps://github.com//pull/225705 fixed an issue where\ncontrols where getting created with adhoc data views. This fix cause\nregression #236288. Instead of\nfiltering out adhoc data views from dashboard.dataViews$, the fix should\noccur in the control group level and ignore adhoc data views when\nsuggesting the data view when creating a control.\n\n### Test instructions\n* install sample web logs and wait until its install - web logs is\nexpected to be default data view\n* install sample flights data set\n* create new dashboard\n* add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT\n10`\n* click into unified search query bar. Verify typeahead is populated\nfrom `flights` data view.\n* Add new control to dashboard. Ensure suggested data view is `Kibana\nSample Data Logs` - meaning the control suggested the default data view\nand not the adhoc flights data view from the lens panel.","sha":"01e67c3b061e8115c793569b7a8923fcecce9295"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.0","9.1","8.19"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238731","number":238731,"mergeCommit":{"message":"[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar (#238731)\n\nCloses https://github.com/elastic/kibana/issues/236288\n\n### Background\nhttps://github.com//pull/225705 fixed an issue where\ncontrols where getting created with adhoc data views. This fix cause\nregression #236288. Instead of\nfiltering out adhoc data views from dashboard.dataViews$, the fix should\noccur in the control group level and ignore adhoc data views when\nsuggesting the data view when creating a control.\n\n### Test instructions\n* install sample web logs and wait until its install - web logs is\nexpected to be default data view\n* install sample flights data set\n* create new dashboard\n* add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT\n10`\n* click into unified search query bar. Verify typeahead is populated\nfrom `flights` data view.\n* Add new control to dashboard. Ensure suggested data view is `Kibana\nSample Data Logs` - meaning the control suggested the default data view\nand not the adhoc flights data view from the lens panel.","sha":"01e67c3b061e8115c793569b7a8923fcecce9295"}},{"branch":"9.1","label":"v9.1.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Oct 14, 2025
…tered out in the KQL search bar (#238731) (#238991) # Backport This will backport the following commits from `main` to `9.2`: - [[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar (#238731)](#238731) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-10-14T17:50:51Z","message":"[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar (#238731)\n\nCloses https://github.com/elastic/kibana/issues/236288\n\n### Background\nhttps://github.com//pull/225705 fixed an issue where\ncontrols where getting created with adhoc data views. This fix cause\nregression #236288. Instead of\nfiltering out adhoc data views from dashboard.dataViews$, the fix should\noccur in the control group level and ignore adhoc data views when\nsuggesting the data view when creating a control.\n\n### Test instructions\n* install sample web logs and wait until its install - web logs is\nexpected to be default data view\n* install sample flights data set\n* create new dashboard\n* add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT\n10`\n* click into unified search query bar. Verify typeahead is populated\nfrom `flights` data view.\n* Add new control to dashboard. Ensure suggested data view is `Kibana\nSample Data Logs` - meaning the control suggested the default data view\nand not the adhoc flights data view from the lens panel.","sha":"01e67c3b061e8115c793569b7a8923fcecce9295","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","backport:version","v9.2.0","v9.0.6","v9.3.0","v9.1.6","v8.19.6"],"title":"[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar","number":238731,"url":"https://github.com/elastic/kibana/pull/238731","mergeCommit":{"message":"[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar (#238731)\n\nCloses https://github.com/elastic/kibana/issues/236288\n\n### Background\nhttps://github.com//pull/225705 fixed an issue where\ncontrols where getting created with adhoc data views. This fix cause\nregression #236288. Instead of\nfiltering out adhoc data views from dashboard.dataViews$, the fix should\noccur in the control group level and ignore adhoc data views when\nsuggesting the data view when creating a control.\n\n### Test instructions\n* install sample web logs and wait until its install - web logs is\nexpected to be default data view\n* install sample flights data set\n* create new dashboard\n* add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT\n10`\n* click into unified search query bar. Verify typeahead is populated\nfrom `flights` data view.\n* Add new control to dashboard. Ensure suggested data view is `Kibana\nSample Data Logs` - meaning the control suggested the default data view\nand not the adhoc flights data view from the lens panel.","sha":"01e67c3b061e8115c793569b7a8923fcecce9295"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.0","9.1","8.19"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238731","number":238731,"mergeCommit":{"message":"[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar (#238731)\n\nCloses https://github.com/elastic/kibana/issues/236288\n\n### Background\nhttps://github.com//pull/225705 fixed an issue where\ncontrols where getting created with adhoc data views. This fix cause\nregression #236288. Instead of\nfiltering out adhoc data views from dashboard.dataViews$, the fix should\noccur in the control group level and ignore adhoc data views when\nsuggesting the data view when creating a control.\n\n### Test instructions\n* install sample web logs and wait until its install - web logs is\nexpected to be default data view\n* install sample flights data set\n* create new dashboard\n* add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT\n10`\n* click into unified search query bar. Verify typeahead is populated\nfrom `flights` data view.\n* Add new control to dashboard. Ensure suggested data view is `Kibana\nSample Data Logs` - meaning the control suggested the default data view\nand not the adhoc flights data view from the lens panel.","sha":"01e67c3b061e8115c793569b7a8923fcecce9295"}},{"branch":"9.1","label":"v9.1.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Oct 14, 2025
…ltered out in the KQL search bar (#238731) (#238988) # Backport This will backport the following commits from `main` to `8.19`: - [[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar (#238731)](#238731) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-10-14T17:50:51Z","message":"[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar (#238731)\n\nCloses https://github.com/elastic/kibana/issues/236288\n\n### Background\nhttps://github.com//pull/225705 fixed an issue where\ncontrols where getting created with adhoc data views. This fix cause\nregression #236288. Instead of\nfiltering out adhoc data views from dashboard.dataViews$, the fix should\noccur in the control group level and ignore adhoc data views when\nsuggesting the data view when creating a control.\n\n### Test instructions\n* install sample web logs and wait until its install - web logs is\nexpected to be default data view\n* install sample flights data set\n* create new dashboard\n* add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT\n10`\n* click into unified search query bar. Verify typeahead is populated\nfrom `flights` data view.\n* Add new control to dashboard. Ensure suggested data view is `Kibana\nSample Data Logs` - meaning the control suggested the default data view\nand not the adhoc flights data view from the lens panel.","sha":"01e67c3b061e8115c793569b7a8923fcecce9295","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","backport:version","v9.2.0","v9.0.6","v9.3.0","v9.1.6","v8.19.6"],"title":"[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar","number":238731,"url":"https://github.com/elastic/kibana/pull/238731","mergeCommit":{"message":"[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar (#238731)\n\nCloses https://github.com/elastic/kibana/issues/236288\n\n### Background\nhttps://github.com//pull/225705 fixed an issue where\ncontrols where getting created with adhoc data views. This fix cause\nregression #236288. Instead of\nfiltering out adhoc data views from dashboard.dataViews$, the fix should\noccur in the control group level and ignore adhoc data views when\nsuggesting the data view when creating a control.\n\n### Test instructions\n* install sample web logs and wait until its install - web logs is\nexpected to be default data view\n* install sample flights data set\n* create new dashboard\n* add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT\n10`\n* click into unified search query bar. Verify typeahead is populated\nfrom `flights` data view.\n* Add new control to dashboard. Ensure suggested data view is `Kibana\nSample Data Logs` - meaning the control suggested the default data view\nand not the adhoc flights data view from the lens panel.","sha":"01e67c3b061e8115c793569b7a8923fcecce9295"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.0","9.1","8.19"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238731","number":238731,"mergeCommit":{"message":"[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar (#238731)\n\nCloses https://github.com/elastic/kibana/issues/236288\n\n### Background\nhttps://github.com//pull/225705 fixed an issue where\ncontrols where getting created with adhoc data views. This fix cause\nregression #236288. Instead of\nfiltering out adhoc data views from dashboard.dataViews$, the fix should\noccur in the control group level and ignore adhoc data views when\nsuggesting the data view when creating a control.\n\n### Test instructions\n* install sample web logs and wait until its install - web logs is\nexpected to be default data view\n* install sample flights data set\n* create new dashboard\n* add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT\n10`\n* click into unified search query bar. Verify typeahead is populated\nfrom `flights` data view.\n* Add new control to dashboard. Ensure suggested data view is `Kibana\nSample Data Logs` - meaning the control suggested the default data view\nand not the adhoc flights data view from the lens panel.","sha":"01e67c3b061e8115c793569b7a8923fcecce9295"}},{"branch":"9.1","label":"v9.1.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
ersin-erdal
pushed a commit
to ersin-erdal/kibana
that referenced
this pull request
Oct 15, 2025
…out in the KQL search bar (elastic#238731) Closes elastic#236288 ### Background elastic#225705 fixed an issue where controls where getting created with adhoc data views. This fix cause regression elastic#236288. Instead of filtering out adhoc data views from dashboard.dataViews$, the fix should occur in the control group level and ignore adhoc data views when suggesting the data view when creating a control. ### Test instructions * install sample web logs and wait until its install - web logs is expected to be default data view * install sample flights data set * create new dashboard * add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT 10` * click into unified search query bar. Verify typeahead is populated from `flights` data view. * Add new control to dashboard. Ensure suggested data view is `Kibana Sample Data Logs` - meaning the control suggested the default data view and not the adhoc flights data view from the lens panel.
mgadewoll
pushed a commit
to tkajtoch/kibana
that referenced
this pull request
Oct 17, 2025
…out in the KQL search bar (elastic#238731) Closes elastic#236288 ### Background elastic#225705 fixed an issue where controls where getting created with adhoc data views. This fix cause regression elastic#236288. Instead of filtering out adhoc data views from dashboard.dataViews$, the fix should occur in the control group level and ignore adhoc data views when suggesting the data view when creating a control. ### Test instructions * install sample web logs and wait until its install - web logs is expected to be default data view * install sample flights data set * create new dashboard * add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT 10` * click into unified search query bar. Verify typeahead is populated from `flights` data view. * Add new control to dashboard. Ensure suggested data view is `Kibana Sample Data Logs` - meaning the control suggested the default data view and not the adhoc flights data view from the lens panel.
rylnd
pushed a commit
to rylnd/kibana
that referenced
this pull request
Oct 17, 2025
…out in the KQL search bar (elastic#238731) Closes elastic#236288 ### Background elastic#225705 fixed an issue where controls where getting created with adhoc data views. This fix cause regression elastic#236288. Instead of filtering out adhoc data views from dashboard.dataViews$, the fix should occur in the control group level and ignore adhoc data views when suggesting the data view when creating a control. ### Test instructions * install sample web logs and wait until its install - web logs is expected to be default data view * install sample flights data set * create new dashboard * add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT 10` * click into unified search query bar. Verify typeahead is populated from `flights` data view. * Add new control to dashboard. Ensure suggested data view is `Kibana Sample Data Logs` - meaning the control suggested the default data view and not the adhoc flights data view from the lens panel.
nickpeihl
pushed a commit
to nickpeihl/kibana
that referenced
this pull request
Oct 23, 2025
…out in the KQL search bar (elastic#238731) Closes elastic#236288 ### Background elastic#225705 fixed an issue where controls where getting created with adhoc data views. This fix cause regression elastic#236288. Instead of filtering out adhoc data views from dashboard.dataViews$, the fix should occur in the control group level and ignore adhoc data views when suggesting the data view when creating a control. ### Test instructions * install sample web logs and wait until its install - web logs is expected to be default data view * install sample flights data set * create new dashboard * add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT 10` * click into unified search query bar. Verify typeahead is populated from `flights` data view. * Add new control to dashboard. Ensure suggested data view is `Kibana Sample Data Logs` - meaning the control suggested the default data view and not the adhoc flights data view from the lens panel.
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Oct 27, 2025
…out in the KQL search bar (elastic#238731) Closes elastic#236288 ### Background elastic#225705 fixed an issue where controls where getting created with adhoc data views. This fix cause regression elastic#236288. Instead of filtering out adhoc data views from dashboard.dataViews$, the fix should occur in the control group level and ignore adhoc data views when suggesting the data view when creating a control. ### Test instructions * install sample web logs and wait until its install - web logs is expected to be default data view * install sample flights data set * create new dashboard * add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT 10` * click into unified search query bar. Verify typeahead is populated from `flights` data view. * Add new control to dashboard. Ensure suggested data view is `Kibana Sample Data Logs` - meaning the control suggested the default data view and not the adhoc flights data view from the lens panel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #225357
Overview
This PR stops the Dashboard from placing adhoc data views into its published data views list. This fixes a bug where Dashboard would recommend an adhoc data view as the most relevant data view when creating a control, causing the above bug.