Skip to content

[Search Home Page V1] Add tests for checking whether Home page is the active page#225902

Merged
saikatsarkar056 merged 2 commits intoelastic:mainfrom
saikatsarkar056:fix_focus_issue
Jun 30, 2025
Merged

[Search Home Page V1] Add tests for checking whether Home page is the active page#225902
saikatsarkar056 merged 2 commits intoelastic:mainfrom
saikatsarkar056:fix_focus_issue

Conversation

@saikatsarkar056
Copy link
Contributor

@saikatsarkar056 saikatsarkar056 commented Jun 30, 2025 •
edited
Loading

Summary

This PR adds FTR tests to verify that the Home page is correctly marked as active. Previously, when a user was on the Home page, it wasn’t highlighted in the side navigation. This PR addresses and resolves that issue.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.
@saikatsarkar056 saikatsarkar056 requested a review from a team as a code owner June 30, 2025 18:28
@saikatsarkar056 saikatsarkar056 self-assigned this Jun 30, 2025
@saikatsarkar056 saikatsarkar056 added backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Search labels Jun 30, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 30, 2025

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#8498

[✅] x-pack/test/functional_solution_sidenav/config.ts: 25/25 tests passed.

see run history
TattdCodeMonkey
TattdCodeMonkey approved these changes Jun 30, 2025
View reviewed changes
x-pack/test/functional_solution_sidenav/tests/search_sidenav.ts
});

// Redirected to Onboarding Page to Create Index
await solutionNavigation.breadcrumbs.expectBreadcrumbExists({
Copy link
Contributor

@TattdCodeMonkey TattdCodeMonkey Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I had to update this in my nav update PR since the global empty state won't have Build in it's breadcrumbs
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 30, 2025

💚 Build Succeeded

Metrics [docs]

✅ unchanged

cc @saikatsarkar056
@saikatsarkar056 saikatsarkar056 merged commit 00d02da into elastic:main Jun 30, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Search v9.2.0

4 participants

@saikatsarkar056 @kibanamachine @elasticmachine @TattdCodeMonkey