Skip to content

[Lens] Fix ES|QL loading button state for long running queries #226565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dej611 merged 8 commits into from
Jul 29, 2025
Merged

[Lens] Fix ES|QL loading button state for long running queries #226565

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
77dece6
:bug: restore loader
dej611 Jul 4, 2025
64c9212
[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'
kibanamachine Jul 4, 2025
57afc4c
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine Jul 4, 2025
4f69e6a
Merge branch 'main' into fix/225204
dej611 Jul 7, 2025
01089c0
Merge branch 'main' into fix/225204
dej611 Jul 10, 2025
0879c9f
Merge branch 'main' into fix/225204
dej611 Jul 14, 2025
68557d5
Merge branch 'main' into fix/225204
markov00 Jul 14, 2025
3607fd5
Merge branch 'main' into fix/225204
dej611 Jul 28, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...plugins/shared/lens/public/editor_frame_service/editor_frame/config_panel/esql_editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@ export function ESQLEditor({
errors={errors}
suggestsLimitedColumns={suggestsLimitedColumns}
isVisualizationLoading={isVisualizationLoading}
setIsVisualizationLoading={setIsVisualizationLoading}
esqlVariables={esqlVariables}
closeFlyout={closeFlyout}
panelId={panelId}
Expand Down Expand Up @@ -250,6 +251,7 @@ type InnerEditorProps = Simplify<
) => Promise<void>;
errors: Error[];
isVisualizationLoading: boolean | undefined;
setIsVisualizationLoading: (status: boolean) => void;
suggestsLimitedColumns: boolean;
adHocDataViews: DataViewSpec[];
esqlVariables: ESQLControlVariable[] | undefined;
Expand All @@ -267,6 +269,7 @@ function InnerESQLEditor({
closeFlyout,
setQuery,
isVisualizationLoading,
setIsVisualizationLoading,
prevQuery,
runQuery,
esqlVariables,
Expand Down Expand Up @@ -300,7 +303,7 @@ function InnerESQLEditor({
onTextLangQuerySubmit={async (q, a) => {
// do not run the suggestions if the query is the same as the previous one
if (q && !isEqual(q, prevQuery.current)) {
// setIsVisualizationLoading(true);
setIsVisualizationLoading(true);
await runQuery(q, a);
}
}}
Expand Down