Skip to content

[Discover][UnifiedDataTable] Fix row highlight when reordering columns#226584

Merged
jughosta merged 2 commits intoelastic:mainfrom
jughosta:226528-fix-cell-highlight
Jul 8, 2025
Merged

[Discover][UnifiedDataTable] Fix row highlight when reordering columns#226584
jughosta merged 2 commits intoelastic:mainfrom
jughosta:226528-fix-cell-highlight

Conversation

@jughosta
Copy link
Contributor

@jughosta jughosta commented Jul 4, 2025

Summary

Jul-04-2025 15-29-24

Checklist

  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.
@jughosta jughosta self-assigned this Jul 4, 2025
@jughosta jughosta added release_note:fix Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// backport:all-open Backport to all branches that could still receive a release labels Jul 4, 2025
@jughosta jughosta marked this pull request as ready for review July 4, 2025 16:06
@jughosta jughosta requested review from a team as code owners July 4, 2025 16:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, thanks for fixing it!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 556.6KB 556.6KB +2.0B
discover 1.1MB 1.1MB +2.0B
esqlDataGrid 157.2KB 157.2KB +2.0B
securitySolution 9.8MB 9.8MB +2.0B
slo 988.6KB 988.6KB +2.0B
total +10.0B

History

cc @jughosta

Copy link
Contributor

@logeekal logeekal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on code-owners review.

Just an FYI this change does not work in Timeline's embedded discover but issue is not related this particular PR, rather general dragging of columns.

@davismcphee had once raised an issue (elastic/eui#8119) with EUI team which was resolved. But I am not sure why it is still not working.

Someone from our team will take a look at it later.

@jughosta jughosta added backport:prev-minor and removed backport:all-open Backport to all branches that could still receive a release labels Jul 8, 2025
@jughosta jughosta merged commit 3493845 into elastic:main Jul 8, 2025
13 checks passed
@jughosta jughosta deleted the 226528-fix-cell-highlight branch July 8, 2025 09:59
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.1

https://github.com/elastic/kibana/actions/runs/16140086165

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 8, 2025
elastic#226584)

- Closes elastic#226528

## Summary

![Jul-04-2025
15-29-24](https://github.com/user-attachments/assets/8197e3eb-48f7-43e5-bb8f-7e42ec2d6884)

### Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

(cherry picked from commit 3493845)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 8, 2025
…columns (#226584) (#226968)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[Discover][UnifiedDataTable] Fix row highlight when reordering
columns (#226584)](#226584)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2025-07-08T09:59:10Z","message":"[Discover][UnifiedDataTable]
Fix row highlight when reordering columns (#226584)\n\n- Closes
https://github.com/elastic/kibana/issues/226528\n\n##
Summary\n\n![Jul-04-2025\n15-29-24](https://github.com/user-attachments/assets/8197e3eb-48f7-43e5-bb8f-7e42ec2d6884)\n\n\n\n###
Checklist\n\n- [x] The PR description includes the appropriate Release
Notes section,\nand the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n-
[x] Review the
[backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand
apply applicable `backport:*`
labels.","sha":"349384518aa4f2cbc01654933bf6ed3d4be360cb","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:prev-minor","v9.2.0"],"title":"[Discover][UnifiedDataTable]
Fix row highlight when reordering
columns","number":226584,"url":"https://github.com/elastic/kibana/pull/226584","mergeCommit":{"message":"[Discover][UnifiedDataTable]
Fix row highlight when reordering columns (#226584)\n\n- Closes
https://github.com/elastic/kibana/issues/226528\n\n##
Summary\n\n![Jul-04-2025\n15-29-24](https://github.com/user-attachments/assets/8197e3eb-48f7-43e5-bb8f-7e42ec2d6884)\n\n\n\n###
Checklist\n\n- [x] The PR description includes the appropriate Release
Notes section,\nand the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n-
[x] Review the
[backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand
apply applicable `backport:*`
labels.","sha":"349384518aa4f2cbc01654933bf6ed3d4be360cb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226584","number":226584,"mergeCommit":{"message":"[Discover][UnifiedDataTable]
Fix row highlight when reordering columns (#226584)\n\n- Closes
https://github.com/elastic/kibana/issues/226528\n\n##
Summary\n\n![Jul-04-2025\n15-29-24](https://github.com/user-attachments/assets/8197e3eb-48f7-43e5-bb8f-7e42ec2d6884)\n\n\n\n###
Checklist\n\n- [x] The PR description includes the appropriate Release
Notes section,\nand the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n-
[x] Review the
[backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand
apply applicable `backport:*`
labels.","sha":"349384518aa4f2cbc01654933bf6ed3d4be360cb"}}]}]
BACKPORT-->

Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025
elastic#226584)

- Closes elastic#226528

## Summary

![Jul-04-2025
15-29-24](https://github.com/user-attachments/assets/8197e3eb-48f7-43e5-bb8f-7e42ec2d6884)



### Checklist

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:fix Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v9.1.0 v9.2.0

5 participants