Skip to content

[Discover] Fix drag & drop when animations are disabled#226592

Merged
jughosta merged 5 commits intoelastic:mainfrom
jughosta:226029-fix-disabled-dnd
Jul 14, 2025
Merged

[Discover] Fix drag & drop when animations are disabled#226592
jughosta merged 5 commits intoelastic:mainfrom
jughosta:226029-fix-disabled-dnd

Conversation

@jughosta
Copy link
Contributor

@jughosta jughosta commented Jul 4, 2025

Summary

This PR makes sure that drag&drop action finishes correctly.
When testing enable accessibility:disableAnimations in Advanced Settings, reload the page, and check reordering of grid columns or tabs in Discover.

@jughosta jughosta self-assigned this Jul 4, 2025
@jughosta jughosta added release_note:fix Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// backport:all-open Backport to all branches that could still receive a release labels Jul 4, 2025
@jughosta jughosta marked this pull request as ready for review July 4, 2025 16:20
@jughosta jughosta requested a review from a team as a code owner July 4, 2025 16:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@jughosta jughosta added backport:version Backport to applied version labels v9.1.0 v8.19.0 v9.2.0 and removed backport:all-open Backport to all branches that could still receive a release labels Jul 14, 2025
@jughosta jughosta enabled auto-merge (squash) July 14, 2025 09:59
@jughosta jughosta merged commit 5514414 into elastic:main Jul 14, 2025
20 of 21 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/16263934545

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 474.0KB 474.1KB +74.0B

History

cc @jughosta

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 14, 2025
- Close elastic#226029

## Summary

This PR makes sure that drag&drop action finishes correctly.
When testing enable `accessibility:disableAnimations` in Advanced
Settings, reload the page, and check reordering of grid columns or tabs
in Discover.

(cherry picked from commit 5514414)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 14, 2025
- Close elastic#226029

## Summary

This PR makes sure that drag&drop action finishes correctly.
When testing enable `accessibility:disableAnimations` in Advanced
Settings, reload the page, and check reordering of grid columns or tabs
in Discover.

(cherry picked from commit 5514414)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.19
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 14, 2025
… (#227781)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[Discover] Fix drag & drop when animations are disabled
(#226592)](#226592)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2025-07-14T10:04:59Z","message":"[Discover]
Fix drag & drop when animations are disabled (#226592)\n\n- Close
https://github.com/elastic/kibana/issues/226029\n\n## Summary\n\nThis PR
makes sure that drag&drop action finishes correctly.\nWhen testing
enable `accessibility:disableAnimations` in Advanced\nSettings, reload
the page, and check reordering of grid columns or tabs\nin
Discover.","sha":"55144143282c42c42349e87e83351c5a48b43832","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Discover]
Fix drag & drop when animations are
disabled","number":226592,"url":"https://github.com/elastic/kibana/pull/226592","mergeCommit":{"message":"[Discover]
Fix drag & drop when animations are disabled (#226592)\n\n- Close
https://github.com/elastic/kibana/issues/226029\n\n## Summary\n\nThis PR
makes sure that drag&drop action finishes correctly.\nWhen testing
enable `accessibility:disableAnimations` in Advanced\nSettings, reload
the page, and check reordering of grid columns or tabs\nin
Discover.","sha":"55144143282c42c42349e87e83351c5a48b43832"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226592","number":226592,"mergeCommit":{"message":"[Discover]
Fix drag & drop when animations are disabled (#226592)\n\n- Close
https://github.com/elastic/kibana/issues/226029\n\n## Summary\n\nThis PR
makes sure that drag&drop action finishes correctly.\nWhen testing
enable `accessibility:disableAnimations` in Advanced\nSettings, reload
the page, and check reordering of grid columns or tabs\nin
Discover.","sha":"55144143282c42c42349e87e83351c5a48b43832"}}]}]
BACKPORT-->

Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
@jughosta jughosta deleted the 226029-fix-disabled-dnd branch July 14, 2025 12:01
kibanamachine added a commit that referenced this pull request Jul 14, 2025
…) (#227780)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Discover] Fix drag & drop when animations are disabled
(#226592)](#226592)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2025-07-14T10:04:59Z","message":"[Discover]
Fix drag & drop when animations are disabled (#226592)\n\n- Close
https://github.com/elastic/kibana/issues/226029\n\n## Summary\n\nThis PR
makes sure that drag&drop action finishes correctly.\nWhen testing
enable `accessibility:disableAnimations` in Advanced\nSettings, reload
the page, and check reordering of grid columns or tabs\nin
Discover.","sha":"55144143282c42c42349e87e83351c5a48b43832","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Discover]
Fix drag & drop when animations are
disabled","number":226592,"url":"https://github.com/elastic/kibana/pull/226592","mergeCommit":{"message":"[Discover]
Fix drag & drop when animations are disabled (#226592)\n\n- Close
https://github.com/elastic/kibana/issues/226029\n\n## Summary\n\nThis PR
makes sure that drag&drop action finishes correctly.\nWhen testing
enable `accessibility:disableAnimations` in Advanced\nSettings, reload
the page, and check reordering of grid columns or tabs\nin
Discover.","sha":"55144143282c42c42349e87e83351c5a48b43832"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226592","number":226592,"mergeCommit":{"message":"[Discover]
Fix drag & drop when animations are disabled (#226592)\n\n- Close
https://github.com/elastic/kibana/issues/226029\n\n## Summary\n\nThis PR
makes sure that drag&drop action finishes correctly.\nWhen testing
enable `accessibility:disableAnimations` in Advanced\nSettings, reload
the page, and check reordering of grid columns or tabs\nin
Discover.","sha":"55144143282c42c42349e87e83351c5a48b43832"}}]}]
BACKPORT-->

Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
Bluefinger pushed a commit to Bluefinger/kibana that referenced this pull request Jul 22, 2025
- Close elastic#226029

## Summary

This PR makes sure that drag&drop action finishes correctly.
When testing enable `accessibility:disableAnimations` in Advanced
Settings, reload the page, and check reordering of grid columns or tabs
in Discover.
kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025
- Close elastic#226029

## Summary

This PR makes sure that drag&drop action finishes correctly.
When testing enable `accessibility:disableAnimations` in Advanced
Settings, reload the page, and check reordering of grid columns or tabs
in Discover.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:fix Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v8.19.0 v9.1.0 v9.2.0

4 participants