[Discover] Fix drag & drop when animations are disabled#226592
Merged
jughosta merged 5 commits intoelastic:mainfrom Jul 14, 2025
Merged
[Discover] Fix drag & drop when animations are disabled#226592jughosta merged 5 commits intoelastic:mainfrom
jughosta merged 5 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Bamieh
approved these changes
Jul 14, 2025
Contributor
|
Starting backport for target branches: 8.19, 9.1 |
Contributor
💚 Build Succeeded
Metrics [docs]Page load bundle
History
cc @jughosta |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 14, 2025
- Close elastic#226029 ## Summary This PR makes sure that drag&drop action finishes correctly. When testing enable `accessibility:disableAnimations` in Advanced Settings, reload the page, and check reordering of grid columns or tabs in Discover. (cherry picked from commit 5514414)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 14, 2025
- Close elastic#226029 ## Summary This PR makes sure that drag&drop action finishes correctly. When testing enable `accessibility:disableAnimations` in Advanced Settings, reload the page, and check reordering of grid columns or tabs in Discover. (cherry picked from commit 5514414)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 14, 2025
… (#227781) # Backport This will backport the following commits from `main` to `9.1`: - [[Discover] Fix drag & drop when animations are disabled (#226592)](#226592) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2025-07-14T10:04:59Z","message":"[Discover] Fix drag & drop when animations are disabled (#226592)\n\n- Close https://github.com/elastic/kibana/issues/226029\n\n## Summary\n\nThis PR makes sure that drag&drop action finishes correctly.\nWhen testing enable `accessibility:disableAnimations` in Advanced\nSettings, reload the page, and check reordering of grid columns or tabs\nin Discover.","sha":"55144143282c42c42349e87e83351c5a48b43832","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Discover] Fix drag & drop when animations are disabled","number":226592,"url":"https://github.com/elastic/kibana/pull/226592","mergeCommit":{"message":"[Discover] Fix drag & drop when animations are disabled (#226592)\n\n- Close https://github.com/elastic/kibana/issues/226029\n\n## Summary\n\nThis PR makes sure that drag&drop action finishes correctly.\nWhen testing enable `accessibility:disableAnimations` in Advanced\nSettings, reload the page, and check reordering of grid columns or tabs\nin Discover.","sha":"55144143282c42c42349e87e83351c5a48b43832"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226592","number":226592,"mergeCommit":{"message":"[Discover] Fix drag & drop when animations are disabled (#226592)\n\n- Close https://github.com/elastic/kibana/issues/226029\n\n## Summary\n\nThis PR makes sure that drag&drop action finishes correctly.\nWhen testing enable `accessibility:disableAnimations` in Advanced\nSettings, reload the page, and check reordering of grid columns or tabs\nin Discover.","sha":"55144143282c42c42349e87e83351c5a48b43832"}}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Jul 14, 2025
…) (#227780) # Backport This will backport the following commits from `main` to `8.19`: - [[Discover] Fix drag & drop when animations are disabled (#226592)](#226592) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2025-07-14T10:04:59Z","message":"[Discover] Fix drag & drop when animations are disabled (#226592)\n\n- Close https://github.com/elastic/kibana/issues/226029\n\n## Summary\n\nThis PR makes sure that drag&drop action finishes correctly.\nWhen testing enable `accessibility:disableAnimations` in Advanced\nSettings, reload the page, and check reordering of grid columns or tabs\nin Discover.","sha":"55144143282c42c42349e87e83351c5a48b43832","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[Discover] Fix drag & drop when animations are disabled","number":226592,"url":"https://github.com/elastic/kibana/pull/226592","mergeCommit":{"message":"[Discover] Fix drag & drop when animations are disabled (#226592)\n\n- Close https://github.com/elastic/kibana/issues/226029\n\n## Summary\n\nThis PR makes sure that drag&drop action finishes correctly.\nWhen testing enable `accessibility:disableAnimations` in Advanced\nSettings, reload the page, and check reordering of grid columns or tabs\nin Discover.","sha":"55144143282c42c42349e87e83351c5a48b43832"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226592","number":226592,"mergeCommit":{"message":"[Discover] Fix drag & drop when animations are disabled (#226592)\n\n- Close https://github.com/elastic/kibana/issues/226029\n\n## Summary\n\nThis PR makes sure that drag&drop action finishes correctly.\nWhen testing enable `accessibility:disableAnimations` in Advanced\nSettings, reload the page, and check reordering of grid columns or tabs\nin Discover.","sha":"55144143282c42c42349e87e83351c5a48b43832"}}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
Bluefinger
pushed a commit
to Bluefinger/kibana
that referenced
this pull request
Jul 22, 2025
- Close elastic#226029 ## Summary This PR makes sure that drag&drop action finishes correctly. When testing enable `accessibility:disableAnimations` in Advanced Settings, reload the page, and check reordering of grid columns or tabs in Discover.
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
- Close elastic#226029 ## Summary This PR makes sure that drag&drop action finishes correctly. When testing enable `accessibility:disableAnimations` in Advanced Settings, reload the page, and check reordering of grid columns or tabs in Discover.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes sure that drag&drop action finishes correctly.
When testing enable
accessibility:disableAnimationsin Advanced Settings, reload the page, and check reordering of grid columns or tabs in Discover.