[Discover] Fix invalid input highlight in Data View flyout#226822
Merged
jughosta merged 2 commits intoelastic:mainfrom Jul 8, 2025
Merged
[Discover] Fix invalid input highlight in Data View flyout#226822jughosta merged 2 commits intoelastic:mainfrom
jughosta merged 2 commits intoelastic:mainfrom
Conversation
jughosta
added
release_note:fix
Team:DataDiscovery
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @jughosta |
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Contributor
|
Starting backport for target branches: 8.17, 8.18, 8.19, 9.0, 9.1 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 8, 2025
…26822) ## Summary This PR addresses the existing issue with invalid input highlights in Data View flyout. `isInvalid` prop was missing elastic#224382 (comment) Before: <img width="939" alt="Screenshot 2025-07-07 at 15 46 59" src="https://github.com/user-attachments/assets/35a29259-8607-42fd-9898-7af827549ba4" /> <img width="935" alt="Screenshot 2025-07-07 at 15 49 32" src="https://github.com/user-attachments/assets/e37acb28-18ef-4bf6-99b2-8fbb7b5e8c75" /> After (notice the additional bottom outline in red): <img width="937" alt="Screenshot 2025-07-07 at 15 46 27" src="https://github.com/user-attachments/assets/061f3aca-6941-4e26-bcb9-a5530c9555d5" /> <img width="929" alt="Screenshot 2025-07-07 at 15 49 10" src="https://github.com/user-attachments/assets/214a6269-16f5-42d4-be83-e28d49f338d4" /> (cherry picked from commit 7483b8c)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 8, 2025
…26822) ## Summary This PR addresses the existing issue with invalid input highlights in Data View flyout. `isInvalid` prop was missing elastic#224382 (comment) Before: <img width="939" alt="Screenshot 2025-07-07 at 15 46 59" src="https://github.com/user-attachments/assets/35a29259-8607-42fd-9898-7af827549ba4" /> <img width="935" alt="Screenshot 2025-07-07 at 15 49 32" src="https://github.com/user-attachments/assets/e37acb28-18ef-4bf6-99b2-8fbb7b5e8c75" /> After (notice the additional bottom outline in red): <img width="937" alt="Screenshot 2025-07-07 at 15 46 27" src="https://github.com/user-attachments/assets/061f3aca-6941-4e26-bcb9-a5530c9555d5" /> <img width="929" alt="Screenshot 2025-07-07 at 15 49 10" src="https://github.com/user-attachments/assets/214a6269-16f5-42d4-be83-e28d49f338d4" /> (cherry picked from commit 7483b8c)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 8, 2025
…26822) ## Summary This PR addresses the existing issue with invalid input highlights in Data View flyout. `isInvalid` prop was missing elastic#224382 (comment) Before: <img width="939" alt="Screenshot 2025-07-07 at 15 46 59" src="https://github.com/user-attachments/assets/35a29259-8607-42fd-9898-7af827549ba4" /> <img width="935" alt="Screenshot 2025-07-07 at 15 49 32" src="https://github.com/user-attachments/assets/e37acb28-18ef-4bf6-99b2-8fbb7b5e8c75" /> After (notice the additional bottom outline in red): <img width="937" alt="Screenshot 2025-07-07 at 15 46 27" src="https://github.com/user-attachments/assets/061f3aca-6941-4e26-bcb9-a5530c9555d5" /> <img width="929" alt="Screenshot 2025-07-07 at 15 49 10" src="https://github.com/user-attachments/assets/214a6269-16f5-42d4-be83-e28d49f338d4" /> (cherry picked from commit 7483b8c)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 8, 2025
…26822) ## Summary This PR addresses the existing issue with invalid input highlights in Data View flyout. `isInvalid` prop was missing elastic#224382 (comment) Before: <img width="939" alt="Screenshot 2025-07-07 at 15 46 59" src="https://github.com/user-attachments/assets/35a29259-8607-42fd-9898-7af827549ba4" /> <img width="935" alt="Screenshot 2025-07-07 at 15 49 32" src="https://github.com/user-attachments/assets/e37acb28-18ef-4bf6-99b2-8fbb7b5e8c75" /> After (notice the additional bottom outline in red): <img width="937" alt="Screenshot 2025-07-07 at 15 46 27" src="https://github.com/user-attachments/assets/061f3aca-6941-4e26-bcb9-a5530c9555d5" /> <img width="929" alt="Screenshot 2025-07-07 at 15 49 10" src="https://github.com/user-attachments/assets/214a6269-16f5-42d4-be83-e28d49f338d4" /> (cherry picked from commit 7483b8c)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 8, 2025
…26822) ## Summary This PR addresses the existing issue with invalid input highlights in Data View flyout. `isInvalid` prop was missing elastic#224382 (comment) Before: <img width="939" alt="Screenshot 2025-07-07 at 15 46 59" src="https://github.com/user-attachments/assets/35a29259-8607-42fd-9898-7af827549ba4" /> <img width="935" alt="Screenshot 2025-07-07 at 15 49 32" src="https://github.com/user-attachments/assets/e37acb28-18ef-4bf6-99b2-8fbb7b5e8c75" /> After (notice the additional bottom outline in red): <img width="937" alt="Screenshot 2025-07-07 at 15 46 27" src="https://github.com/user-attachments/assets/061f3aca-6941-4e26-bcb9-a5530c9555d5" /> <img width="929" alt="Screenshot 2025-07-07 at 15 49 10" src="https://github.com/user-attachments/assets/214a6269-16f5-42d4-be83-e28d49f338d4" /> (cherry picked from commit 7483b8c)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Contributor
Author
|
Was not aware of the incoming #226787 which would have addressed the name input. |
kibanamachine
added a commit
that referenced
this pull request
Jul 8, 2025
…6822) (#226933) # Backport This will backport the following commits from `main` to `9.0`: - [[Discover] Fix invalid input highlight in Data View flyout (#226822)](#226822) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2025-07-08T07:45:57Z","message":"[Discover] Fix invalid input highlight in Data View flyout (#226822)\n\n## Summary\n\nThis PR addresses the existing issue with invalid input highlights in\nData View flyout. `isInvalid` prop was missing\nhttps://github.com//pull/224382#issuecomment-3043839200\n\nBefore:\n<img width=\"939\" alt=\"Screenshot 2025-07-07 at 15 46 59\"\nsrc=\"https://github.com/user-attachments/assets/35a29259-8607-42fd-9898-7af827549ba4\"\n/>\n<img width=\"935\" alt=\"Screenshot 2025-07-07 at 15 49 32\"\nsrc=\"https://github.com/user-attachments/assets/e37acb28-18ef-4bf6-99b2-8fbb7b5e8c75\"\n/>\n\nAfter (notice the additional bottom outline in red):\n<img width=\"937\" alt=\"Screenshot 2025-07-07 at 15 46 27\"\nsrc=\"https://github.com/user-attachments/assets/061f3aca-6941-4e26-bcb9-a5530c9555d5\"\n/>\n<img width=\"929\" alt=\"Screenshot 2025-07-07 at 15 49 10\"\nsrc=\"https://github.com/user-attachments/assets/214a6269-16f5-42d4-be83-e28d49f338d4\"\n/>","sha":"7483b8c3dad456d5966edd08b6e43b5c49e80ec2","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:all-open","v9.2.0"],"title":"[Discover] Fix invalid input highlight in Data View flyout","number":226822,"url":"https://github.com/elastic/kibana/pull/226822","mergeCommit":{"message":"[Discover] Fix invalid input highlight in Data View flyout (#226822)\n\n## Summary\n\nThis PR addresses the existing issue with invalid input highlights in\nData View flyout. `isInvalid` prop was missing\nhttps://github.com//pull/224382#issuecomment-3043839200\n\nBefore:\n<img width=\"939\" alt=\"Screenshot 2025-07-07 at 15 46 59\"\nsrc=\"https://github.com/user-attachments/assets/35a29259-8607-42fd-9898-7af827549ba4\"\n/>\n<img width=\"935\" alt=\"Screenshot 2025-07-07 at 15 49 32\"\nsrc=\"https://github.com/user-attachments/assets/e37acb28-18ef-4bf6-99b2-8fbb7b5e8c75\"\n/>\n\nAfter (notice the additional bottom outline in red):\n<img width=\"937\" alt=\"Screenshot 2025-07-07 at 15 46 27\"\nsrc=\"https://github.com/user-attachments/assets/061f3aca-6941-4e26-bcb9-a5530c9555d5\"\n/>\n<img width=\"929\" alt=\"Screenshot 2025-07-07 at 15 49 10\"\nsrc=\"https://github.com/user-attachments/assets/214a6269-16f5-42d4-be83-e28d49f338d4\"\n/>","sha":"7483b8c3dad456d5966edd08b6e43b5c49e80ec2"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226822","number":226822,"mergeCommit":{"message":"[Discover] Fix invalid input highlight in Data View flyout (#226822)\n\n## Summary\n\nThis PR addresses the existing issue with invalid input highlights in\nData View flyout. `isInvalid` prop was missing\nhttps://github.com//pull/224382#issuecomment-3043839200\n\nBefore:\n<img width=\"939\" alt=\"Screenshot 2025-07-07 at 15 46 59\"\nsrc=\"https://github.com/user-attachments/assets/35a29259-8607-42fd-9898-7af827549ba4\"\n/>\n<img width=\"935\" alt=\"Screenshot 2025-07-07 at 15 49 32\"\nsrc=\"https://github.com/user-attachments/assets/e37acb28-18ef-4bf6-99b2-8fbb7b5e8c75\"\n/>\n\nAfter (notice the additional bottom outline in red):\n<img width=\"937\" alt=\"Screenshot 2025-07-07 at 15 46 27\"\nsrc=\"https://github.com/user-attachments/assets/061f3aca-6941-4e26-bcb9-a5530c9555d5\"\n/>\n<img width=\"929\" alt=\"Screenshot 2025-07-07 at 15 49 10\"\nsrc=\"https://github.com/user-attachments/assets/214a6269-16f5-42d4-be83-e28d49f338d4\"\n/>","sha":"7483b8c3dad456d5966edd08b6e43b5c49e80ec2"}}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Jul 8, 2025
…6822) (#226934) # Backport This will backport the following commits from `main` to `9.1`: - [[Discover] Fix invalid input highlight in Data View flyout (#226822)](#226822) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2025-07-08T07:45:57Z","message":"[Discover] Fix invalid input highlight in Data View flyout (#226822)\n\n## Summary\n\nThis PR addresses the existing issue with invalid input highlights in\nData View flyout. `isInvalid` prop was missing\nhttps://github.com//pull/224382#issuecomment-3043839200\n\nBefore:\n<img width=\"939\" alt=\"Screenshot 2025-07-07 at 15 46 59\"\nsrc=\"https://github.com/user-attachments/assets/35a29259-8607-42fd-9898-7af827549ba4\"\n/>\n<img width=\"935\" alt=\"Screenshot 2025-07-07 at 15 49 32\"\nsrc=\"https://github.com/user-attachments/assets/e37acb28-18ef-4bf6-99b2-8fbb7b5e8c75\"\n/>\n\nAfter (notice the additional bottom outline in red):\n<img width=\"937\" alt=\"Screenshot 2025-07-07 at 15 46 27\"\nsrc=\"https://github.com/user-attachments/assets/061f3aca-6941-4e26-bcb9-a5530c9555d5\"\n/>\n<img width=\"929\" alt=\"Screenshot 2025-07-07 at 15 49 10\"\nsrc=\"https://github.com/user-attachments/assets/214a6269-16f5-42d4-be83-e28d49f338d4\"\n/>","sha":"7483b8c3dad456d5966edd08b6e43b5c49e80ec2","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:all-open","v9.2.0"],"title":"[Discover] Fix invalid input highlight in Data View flyout","number":226822,"url":"https://github.com/elastic/kibana/pull/226822","mergeCommit":{"message":"[Discover] Fix invalid input highlight in Data View flyout (#226822)\n\n## Summary\n\nThis PR addresses the existing issue with invalid input highlights in\nData View flyout. `isInvalid` prop was missing\nhttps://github.com//pull/224382#issuecomment-3043839200\n\nBefore:\n<img width=\"939\" alt=\"Screenshot 2025-07-07 at 15 46 59\"\nsrc=\"https://github.com/user-attachments/assets/35a29259-8607-42fd-9898-7af827549ba4\"\n/>\n<img width=\"935\" alt=\"Screenshot 2025-07-07 at 15 49 32\"\nsrc=\"https://github.com/user-attachments/assets/e37acb28-18ef-4bf6-99b2-8fbb7b5e8c75\"\n/>\n\nAfter (notice the additional bottom outline in red):\n<img width=\"937\" alt=\"Screenshot 2025-07-07 at 15 46 27\"\nsrc=\"https://github.com/user-attachments/assets/061f3aca-6941-4e26-bcb9-a5530c9555d5\"\n/>\n<img width=\"929\" alt=\"Screenshot 2025-07-07 at 15 49 10\"\nsrc=\"https://github.com/user-attachments/assets/214a6269-16f5-42d4-be83-e28d49f338d4\"\n/>","sha":"7483b8c3dad456d5966edd08b6e43b5c49e80ec2"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226822","number":226822,"mergeCommit":{"message":"[Discover] Fix invalid input highlight in Data View flyout (#226822)\n\n## Summary\n\nThis PR addresses the existing issue with invalid input highlights in\nData View flyout. `isInvalid` prop was missing\nhttps://github.com//pull/224382#issuecomment-3043839200\n\nBefore:\n<img width=\"939\" alt=\"Screenshot 2025-07-07 at 15 46 59\"\nsrc=\"https://github.com/user-attachments/assets/35a29259-8607-42fd-9898-7af827549ba4\"\n/>\n<img width=\"935\" alt=\"Screenshot 2025-07-07 at 15 49 32\"\nsrc=\"https://github.com/user-attachments/assets/e37acb28-18ef-4bf6-99b2-8fbb7b5e8c75\"\n/>\n\nAfter (notice the additional bottom outline in red):\n<img width=\"937\" alt=\"Screenshot 2025-07-07 at 15 46 27\"\nsrc=\"https://github.com/user-attachments/assets/061f3aca-6941-4e26-bcb9-a5530c9555d5\"\n/>\n<img width=\"929\" alt=\"Screenshot 2025-07-07 at 15 49 10\"\nsrc=\"https://github.com/user-attachments/assets/214a6269-16f5-42d4-be83-e28d49f338d4\"\n/>","sha":"7483b8c3dad456d5966edd08b6e43b5c49e80ec2"}}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Jul 8, 2025
…26822) (#226932) # Backport This will backport the following commits from `main` to `8.19`: - [[Discover] Fix invalid input highlight in Data View flyout (#226822)](#226822) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2025-07-08T07:45:57Z","message":"[Discover] Fix invalid input highlight in Data View flyout (#226822)\n\n## Summary\n\nThis PR addresses the existing issue with invalid input highlights in\nData View flyout. `isInvalid` prop was missing\nhttps://github.com//pull/224382#issuecomment-3043839200\n\nBefore:\n<img width=\"939\" alt=\"Screenshot 2025-07-07 at 15 46 59\"\nsrc=\"https://github.com/user-attachments/assets/35a29259-8607-42fd-9898-7af827549ba4\"\n/>\n<img width=\"935\" alt=\"Screenshot 2025-07-07 at 15 49 32\"\nsrc=\"https://github.com/user-attachments/assets/e37acb28-18ef-4bf6-99b2-8fbb7b5e8c75\"\n/>\n\nAfter (notice the additional bottom outline in red):\n<img width=\"937\" alt=\"Screenshot 2025-07-07 at 15 46 27\"\nsrc=\"https://github.com/user-attachments/assets/061f3aca-6941-4e26-bcb9-a5530c9555d5\"\n/>\n<img width=\"929\" alt=\"Screenshot 2025-07-07 at 15 49 10\"\nsrc=\"https://github.com/user-attachments/assets/214a6269-16f5-42d4-be83-e28d49f338d4\"\n/>","sha":"7483b8c3dad456d5966edd08b6e43b5c49e80ec2","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:all-open","v9.2.0"],"title":"[Discover] Fix invalid input highlight in Data View flyout","number":226822,"url":"https://github.com/elastic/kibana/pull/226822","mergeCommit":{"message":"[Discover] Fix invalid input highlight in Data View flyout (#226822)\n\n## Summary\n\nThis PR addresses the existing issue with invalid input highlights in\nData View flyout. `isInvalid` prop was missing\nhttps://github.com//pull/224382#issuecomment-3043839200\n\nBefore:\n<img width=\"939\" alt=\"Screenshot 2025-07-07 at 15 46 59\"\nsrc=\"https://github.com/user-attachments/assets/35a29259-8607-42fd-9898-7af827549ba4\"\n/>\n<img width=\"935\" alt=\"Screenshot 2025-07-07 at 15 49 32\"\nsrc=\"https://github.com/user-attachments/assets/e37acb28-18ef-4bf6-99b2-8fbb7b5e8c75\"\n/>\n\nAfter (notice the additional bottom outline in red):\n<img width=\"937\" alt=\"Screenshot 2025-07-07 at 15 46 27\"\nsrc=\"https://github.com/user-attachments/assets/061f3aca-6941-4e26-bcb9-a5530c9555d5\"\n/>\n<img width=\"929\" alt=\"Screenshot 2025-07-07 at 15 49 10\"\nsrc=\"https://github.com/user-attachments/assets/214a6269-16f5-42d4-be83-e28d49f338d4\"\n/>","sha":"7483b8c3dad456d5966edd08b6e43b5c49e80ec2"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/226822","number":226822,"mergeCommit":{"message":"[Discover] Fix invalid input highlight in Data View flyout (#226822)\n\n## Summary\n\nThis PR addresses the existing issue with invalid input highlights in\nData View flyout. `isInvalid` prop was missing\nhttps://github.com//pull/224382#issuecomment-3043839200\n\nBefore:\n<img width=\"939\" alt=\"Screenshot 2025-07-07 at 15 46 59\"\nsrc=\"https://github.com/user-attachments/assets/35a29259-8607-42fd-9898-7af827549ba4\"\n/>\n<img width=\"935\" alt=\"Screenshot 2025-07-07 at 15 49 32\"\nsrc=\"https://github.com/user-attachments/assets/e37acb28-18ef-4bf6-99b2-8fbb7b5e8c75\"\n/>\n\nAfter (notice the additional bottom outline in red):\n<img width=\"937\" alt=\"Screenshot 2025-07-07 at 15 46 27\"\nsrc=\"https://github.com/user-attachments/assets/061f3aca-6941-4e26-bcb9-a5530c9555d5\"\n/>\n<img width=\"929\" alt=\"Screenshot 2025-07-07 at 15 49 10\"\nsrc=\"https://github.com/user-attachments/assets/214a6269-16f5-42d4-be83-e28d49f338d4\"\n/>","sha":"7483b8c3dad456d5966edd08b6e43b5c49e80ec2"}}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
…26822) ## Summary This PR addresses the existing issue with invalid input highlights in Data View flyout. `isInvalid` prop was missing elastic#224382 (comment) Before: <img width="939" alt="Screenshot 2025-07-07 at 15 46 59" src="https://github.com/user-attachments/assets/35a29259-8607-42fd-9898-7af827549ba4" /> <img width="935" alt="Screenshot 2025-07-07 at 15 49 32" src="https://github.com/user-attachments/assets/e37acb28-18ef-4bf6-99b2-8fbb7b5e8c75" /> After (notice the additional bottom outline in red): <img width="937" alt="Screenshot 2025-07-07 at 15 46 27" src="https://github.com/user-attachments/assets/061f3aca-6941-4e26-bcb9-a5530c9555d5" /> <img width="929" alt="Screenshot 2025-07-07 at 15 49 10" src="https://github.com/user-attachments/assets/214a6269-16f5-42d4-be83-e28d49f338d4" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the existing issue with invalid input highlights in Data View flyout.
isInvalidprop was missing #224382 (comment)Before:
After (notice the additional bottom outline in red):
