[APM][Unified Waterfall] Show related errors count and add failure badge by iblancof · Pull Request #227413 · elastic/kibana

iblancof · 2025-07-10T10:48:26Z

Summary

In this PR, we're introducing two additions to the new Unified Waterfall used in Discover.

I'll include APM screenshots for comparison, as a quick check to confirm that we've reached parity between the APM waterfall and the Unified Waterfall for these two elements for now.

Errors count in the "View related errors" badge

APM	Discover	Waterfall

Add missing "failure" badge in trace items

APM	Discover	Waterfall

elasticmachine · 2025-07-10T10:48:31Z

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

...solutions/observability/plugins/apm/public/components/shared/trace_waterfall/bar_details.tsx

x-pack/solutions/observability/plugins/apm/server/routes/traces/get_unified_trace_items.ts

...solutions/observability/plugins/apm/public/components/shared/trace_waterfall/bar_details.tsx

…hared/trace_waterfall/bar_details.tsx Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>

…no-cache --fix'

…to-the-badge

miloszmarcinkowski

LGTM, tested locally.

...solutions/observability/plugins/apm/public/components/shared/trace_waterfall/bar_details.tsx

x-pack/solutions/observability/plugins/apm/server/routes/traces/get_unified_trace_items.ts

miloszmarcinkowski

Thanks for adjusting the logic. Even if we decide to opt out (comment) maybe we can keep the new logic, since it's easier to extend in the future?

x-pack/solutions/observability/plugins/apm/common/waterfall/unified_trace_item.ts

x-pack/solutions/observability/plugins/apm/server/routes/traces/get_unified_trace_items.ts

…to-the-badge

cauemarcondes

LGTM

…to-the-badge

elasticmachine · 2025-07-17T11:35:20Z

💛 Build succeeded, but was flaky

Failed CI Steps

FTR Configs #82

Test Failures

[job] [logs] FTR Configs #82 / Stateful Observability - Deployment-agnostic APM API integration tests APM alerts preview chart transaction duration with data loaded transaction_duration: with data loaded with empty service name, transaction name and transaction type

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`apm`	2011	2014	+3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/apm-types`	358	359	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	2.6MB	2.6MB	+591.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`apm`	34.3KB	34.3KB	+2.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/apm-types`	359	360	+1

History

💔 Build #320342 failed 8378f9c
💔 Build #319954 failed aa07510
💔 Build #319712 failed b9b041c
💚 Build #319193 succeeded 801d06a
💚 Build #318958 succeeded cd160c6
💔 Build #318542 failed ba69f47

cc @iblancof

…dge (elastic#227413) ## Summary Closes elastic#225475 In this PR, we're introducing two additions to the new Unified Waterfall used in Discover. I'll include APM screenshots for comparison, as a quick check to confirm that we've reached parity between the APM waterfall and the Unified Waterfall for these two elements for now. **Errors count in the "View related errors" badge** |APM|Discover|Waterfall| |-|-|-| |![Screenshot 2025-07-10 at 12 35 20](https://github.com/user-attachments/assets/6845d284-b8f9-43dd-92a5-aac4480d5da5)|![Screenshot 2025-07-10 at 12 35 55](https://github.com/user-attachments/assets/6a386c10-78d7-4b83-a778-d1802bb5cb60)|![Screenshot 2025-07-10 at 12 36 03](https://github.com/user-attachments/assets/0adeceba-f649-4595-809c-01a2f28dc057)| **Add missing "failure" badge in trace items** |APM|Discover|Waterfall| |-|-|-| |![Screenshot 2025-07-10 at 11 45 50](https://github.com/user-attachments/assets/7433e523-bcfc-498e-9e0c-24d4924359d1)|![Screenshot 2025-07-10 at 11 46 36](https://github.com/user-attachments/assets/669ea370-4f95-4c3c-8fda-50e84765d4c8)|![Screenshot 2025-07-10 at 11 46 45](https://github.com/user-attachments/assets/d57f578d-7bdf-4c34-afd4-69665a694e65)| --------- Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

iblancof added 8 commits July 10, 2025 10:19

Modify trace element logic to work with errorCount instead of hasError

cc3c7cf

Update viewRelatedErrorsLabel to include errorCount

a699339

Update TraceItemRow tests

a289524

Update unified waterfall stories

5a4d7b2

Update BarDetails tests

5329b2a

Add isFailure to TraceItem

098b6b5

Add tooltip and update tests for failure in BarDetails

b095e8c

Update failure styles in TraceItemRow

8f7cb1e

iblancof self-assigned this Jul 10, 2025

iblancof requested a review from a team July 10, 2025 10:48

iblancof added backport:skip This PR does not require backporting release_note:feature Makes this part of the condensed release notes Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. v9.2.0 labels Jul 10, 2025

iblancof added v9.1.0 v8.19.0 release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels and removed backport:skip This PR does not require backporting release_note:feature Makes this part of the condensed release notes labels Jul 10, 2025

iblancof added 2 commits July 10, 2025 14:09

Adapt focused waterfall stories

bb15b22

Update tests for new errorCount prop

e036161

cauemarcondes reviewed Jul 10, 2025

View reviewed changes

iblancof and others added 2 commits July 10, 2025 17:27

Update convertTreeToList tests for new errorCount

357d710

Update x-pack/solutions/observability/plugins/apm/public/components/s…

61ac529

…hared/trace_waterfall/bar_details.tsx Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>

iblancof removed release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Jul 10, 2025

[CI] Auto-commit changed files from 'node scripts/eslint_all_files --…

675cc12

…no-cache --fix'

iblancof added the Feature:Discover Discover Application label Jul 10, 2025

Merge branch 'main' into 225475-apmunified-waterfall-add-error-count-…

f598b47

…to-the-badge

iblancof requested a review from cauemarcondes July 11, 2025 13:41

Merge branch 'main' into 225475-apmunified-waterfall-add-error-count-…

ba69f47

…to-the-badge

miloszmarcinkowski approved these changes Jul 14, 2025

View reviewed changes

kpatticha reviewed Jul 14, 2025

View reviewed changes

...solutions/observability/plugins/apm/public/components/shared/trace_waterfall/bar_details.tsx Show resolved Hide resolved

kpatticha reviewed Jul 14, 2025

View reviewed changes

...solutions/observability/plugins/apm/public/components/shared/trace_waterfall/bar_details.tsx Show resolved Hide resolved

Change isFailure with status for OTel native compat

cd160c6

cauemarcondes reviewed Jul 14, 2025

View reviewed changes

x-pack/solutions/observability/plugins/apm/server/routes/traces/get_unified_trace_items.ts Outdated Show resolved Hide resolved

miloszmarcinkowski reviewed Jul 15, 2025

View reviewed changes

x-pack/solutions/observability/plugins/apm/common/waterfall/unified_trace_item.ts Outdated Show resolved Hide resolved

Type status.fieldName

801d06a

crespocarlos reviewed Jul 15, 2025

View reviewed changes

x-pack/solutions/observability/plugins/apm/server/routes/traces/get_unified_trace_items.ts Outdated Show resolved Hide resolved

iblancof added 3 commits July 16, 2025 09:57

Merge branch 'main' into 225475-apmunified-waterfall-add-error-count-…

0fc6a5a

…to-the-badge

Return always status and check for error/failure on the UI

676516d

Type OTel status.code

b9b041c

iblancof requested review from cauemarcondes and crespocarlos July 16, 2025 08:31

crespocarlos approved these changes Jul 16, 2025

View reviewed changes

Add missing type in TraceItem

aa07510

cauemarcondes approved these changes Jul 16, 2025

View reviewed changes

iblancof added 2 commits July 17, 2025 10:28

Merge branch 'main' into 225475-apmunified-waterfall-add-error-count-…

757c8d8

…to-the-badge

Update failing test

8378f9c

iblancof enabled auto-merge (squash) July 17, 2025 08:40

Update errorCount in stories

f85f9c3

iblancof merged commit 1c4d486 into elastic:main Jul 17, 2025
13 checks passed

iblancof deleted the 225475-apmunified-waterfall-add-error-count-to-the-badge branch August 27, 2025 12:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[APM][Unified Waterfall] Show related errors count and add failure badge#227413

[APM][Unified Waterfall] Show related errors count and add failure badge#227413
iblancof merged 24 commits intoelastic:mainfrom
iblancof:225475-apmunified-waterfall-add-error-count-to-the-badge

iblancof commented Jul 10, 2025

elasticmachine commented Jul 10, 2025

Uh oh!

Uh oh!

Uh oh!

miloszmarcinkowski left a comment

Uh oh!

Uh oh!

Uh oh!

miloszmarcinkowski left a comment

Uh oh!

Uh oh!

cauemarcondes left a comment

Uh oh!

elasticmachine commented Jul 17, 2025

API count

Labels

7 participants

Conversation

iblancof commented Jul 10, 2025

Summary

elasticmachine commented Jul 10, 2025

Uh oh!

Uh oh!

Uh oh!

miloszmarcinkowski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

miloszmarcinkowski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cauemarcondes left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jul 17, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

History

Labels

7 participants