Skip to content

[ES|QL] Hides lookup index hidden indices from autocomplete#227819

Merged
stratoula merged 1 commit intoelastic:mainfrom
stratoula:hide-hidden-lookup-indices
Jul 15, 2025
Merged

[ES|QL] Hides lookup index hidden indices from autocomplete#227819
stratoula merged 1 commit intoelastic:mainfrom
stratoula:hide-hidden-lookup-indices

Conversation

@stratoula
Copy link
Contributor

@stratoula stratoula commented Jul 14, 2025

Summary

Doesn't suggest lookup_mode indices which are marked as hidden

image

Checklist

@stratoula stratoula added release_note:fix v9.2.0 v9.1.0 v8.19.0 backport:version Backport to applied version labels Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// labels Jul 14, 2025
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

@stratoula stratoula marked this pull request as ready for review July 15, 2025 05:16
@stratoula stratoula requested a review from a team as a code owner July 15, 2025 05:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

Copy link
Contributor

@sddonne sddonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stratoula stratoula merged commit 381ed7d into elastic:main Jul 15, 2025
26 of 27 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/16287016624

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 15, 2025
…227819)

## Summary

Doesn't suggest lookup_mode indices which are marked as hidden

<img width="493" height="99" alt="image"
src="https://github.com/user-attachments/assets/e7cb08b7-aebf-4a47-8f0e-515cd2f5b203"
/>

### Checklist
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 381ed7d)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 15, 2025
…227819)

## Summary

Doesn't suggest lookup_mode indices which are marked as hidden

<img width="493" height="99" alt="image"
src="https://github.com/user-attachments/assets/e7cb08b7-aebf-4a47-8f0e-515cd2f5b203"
/>

### Checklist
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 381ed7d)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.19
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 15, 2025
…27819) (#227932)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[ES|QL] Hides lookup index hidden indices from autocomplete
(#227819)](#227819)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2025-07-15T07:33:05Z","message":"[ES|QL]
Hides lookup index hidden indices from autocomplete (#227819)\n\n##
Summary\n\nDoesn't suggest lookup_mode indices which are marked as
hidden\n\n<img width=\"493\" height=\"99\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/e7cb08b7-aebf-4a47-8f0e-515cd2f5b203\"\n/>\n\n\n###
Checklist\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"381ed7da3c3ff05b26ae19b06a07c90cd0c6aa11","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[ES|QL]
Hides lookup index hidden indices from
autocomplete","number":227819,"url":"https://github.com/elastic/kibana/pull/227819","mergeCommit":{"message":"[ES|QL]
Hides lookup index hidden indices from autocomplete (#227819)\n\n##
Summary\n\nDoesn't suggest lookup_mode indices which are marked as
hidden\n\n<img width=\"493\" height=\"99\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/e7cb08b7-aebf-4a47-8f0e-515cd2f5b203\"\n/>\n\n\n###
Checklist\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"381ed7da3c3ff05b26ae19b06a07c90cd0c6aa11"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227819","number":227819,"mergeCommit":{"message":"[ES|QL]
Hides lookup index hidden indices from autocomplete (#227819)\n\n##
Summary\n\nDoesn't suggest lookup_mode indices which are marked as
hidden\n\n<img width=\"493\" height=\"99\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/e7cb08b7-aebf-4a47-8f0e-515cd2f5b203\"\n/>\n\n\n###
Checklist\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"381ed7da3c3ff05b26ae19b06a07c90cd0c6aa11"}}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
stratoula added a commit that referenced this pull request Jul 15, 2025
…227819) (#227931)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[ES|QL] Hides lookup index hidden indices from autocomplete
(#227819)](#227819)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2025-07-15T07:33:05Z","message":"[ES|QL]
Hides lookup index hidden indices from autocomplete (#227819)\n\n##
Summary\n\nDoesn't suggest lookup_mode indices which are marked as
hidden\n\n<img width=\"493\" height=\"99\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/e7cb08b7-aebf-4a47-8f0e-515cd2f5b203\"\n/>\n\n\n###
Checklist\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"381ed7da3c3ff05b26ae19b06a07c90cd0c6aa11","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[ES|QL]
Hides lookup index hidden indices from
autocomplete","number":227819,"url":"https://github.com/elastic/kibana/pull/227819","mergeCommit":{"message":"[ES|QL]
Hides lookup index hidden indices from autocomplete (#227819)\n\n##
Summary\n\nDoesn't suggest lookup_mode indices which are marked as
hidden\n\n<img width=\"493\" height=\"99\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/e7cb08b7-aebf-4a47-8f0e-515cd2f5b203\"\n/>\n\n\n###
Checklist\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"381ed7da3c3ff05b26ae19b06a07c90cd0c6aa11"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227819","number":227819,"mergeCommit":{"message":"[ES|QL]
Hides lookup index hidden indices from autocomplete (#227819)\n\n##
Summary\n\nDoesn't suggest lookup_mode indices which are marked as
hidden\n\n<img width=\"493\" height=\"99\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/e7cb08b7-aebf-4a47-8f0e-515cd2f5b203\"\n/>\n\n\n###
Checklist\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"381ed7da3c3ff05b26ae19b06a07c90cd0c6aa11"}}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
@drewdaemon
Copy link
Contributor

Good catch!

@stratoula
Copy link
Contributor Author

@sddonne found it! I just fixed it 😄

Bluefinger pushed a commit to Bluefinger/kibana that referenced this pull request Jul 22, 2025
…227819)

## Summary

Doesn't suggest lookup_mode indices which are marked as hidden

<img width="493" height="99" alt="image"
src="https://github.com/user-attachments/assets/e7cb08b7-aebf-4a47-8f0e-515cd2f5b203"
/>


### Checklist
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025
…227819)

## Summary

Doesn't suggest lookup_mode indices which are marked as hidden

<img width="493" height="99" alt="image"
src="https://github.com/user-attachments/assets/e7cb08b7-aebf-4a47-8f0e-515cd2f5b203"
/>


### Checklist
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:ES|QL ES|QL related features in Kibana release_note:fix Team:ESQL ES|QL related features in Kibana t// v8.19.0 v9.1.0 v9.2.0

5 participants