[ska] relocate dataset quality api-integration tests#227826
Merged
dmlemeshko merged 8 commits intoelastic:mainfrom Jul 15, 2025
Merged
[ska] relocate dataset quality api-integration tests#227826dmlemeshko merged 8 commits intoelastic:mainfrom
dmlemeshko merged 8 commits intoelastic:mainfrom
Conversation
dmlemeshko
added
release_note:skip
shahzad31
approved these changes
Jul 14, 2025
rmyz
approved these changes
Jul 14, 2025
Contributor
rmyz
left a comment
rmyz
left a comment
There was a problem hiding this comment.
infra & services changes LGTM
Contributor
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
cc @dmlemeshko |
sabarasaba
approved these changes
Jul 14, 2025
Ikuni17
approved these changes
Jul 14, 2025
tonyghiani
approved these changes
Jul 15, 2025
csr
reviewed
Jul 15, 2025
|
|
||
|
|
||
| # Data Discovery | ||
| /x-pack/test/api_integration/services/data_view_api.ts @elastic/kibana-data-discovery |
Member
There was a problem hiding this comment.
I see this file was moved to x-pack/test/api_integration/services/data_view_api.ts (in a separate PR). Why not add a CODEOWNER entry for the new location?
Contributor
There was a problem hiding this comment.
+1, please let's add a CODEOWNER entry for the new file's location instead of removing it completely 🙏
Contributor
Author
There was a problem hiding this comment.
at the moment appex-qa owns all services, but agree to move it to the Team
akowalska622
requested changes
Jul 15, 2025
|
|
||
|
|
||
| # Data Discovery | ||
| /x-pack/test/api_integration/services/data_view_api.ts @elastic/kibana-data-discovery |
Contributor
There was a problem hiding this comment.
+1, please let's add a CODEOWNER entry for the new file's location instead of removing it completely 🙏
This was referenced Jul 15, 2025
dmlemeshko
added
backport:version
Contributor
|
Starting backport for target branches: 8.19, 9.1 |
Contributor
|
Starting backport for target branches: 8.19, 9.1 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
1 similar comment
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Jul 16, 2025
## Summary Part of elastic/kibana-team#1503 This PR is mostly about moving platform data quality api tests from x-pack/test ``` x-pack/test/ | - dataset_quality_api_integration ``` After: ``` x-pack/solutions/observability/test/ | - dataset_quality_api_integration ``` I also did a small cleanup of no longer used duplicated services under `x-pack/test/api_integration` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit e7c6fe5) # Conflicts: # .github/CODEOWNERS # x-pack/test/api_integration/services/slo.ts # x-pack/test/functional/services/index.ts # x-pack/test/tsconfig.json
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Jul 17, 2025
## Summary Part of elastic/kibana-team#1503 This PR is mostly about moving platform data quality api tests from x-pack/test ``` x-pack/test/ | - dataset_quality_api_integration ``` After: ``` x-pack/solutions/observability/test/ | - dataset_quality_api_integration ``` I also did a small cleanup of no longer used duplicated services under `x-pack/test/api_integration` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit e7c6fe5)
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
dmlemeshko
added a commit
that referenced
this pull request
Jul 17, 2025
…228217) # Backport This will backport the following commits from `main` to `9.1`: - [[ska] relocate dataset quality api-integration tests (#227826)](#227826) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Dzmitry Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2025-07-15T11:35:02Z","message":"[ska] relocate dataset quality api-integration tests (#227826)\n\n## Summary\n\nPart of https://github.com/elastic/kibana-team/issues/1503\n\nThis PR is mostly about moving platform data quality api tests from\nx-pack/test\n\n```\nx-pack/test/\n | - dataset_quality_api_integration\n```\n\nAfter: \n```\nx-pack/solutions/observability/test/\n | - dataset_quality_api_integration\n```\n\nI also did a small cleanup of no longer used duplicated services under\n`x-pack/test/api_integration`\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"e7c6fe5717ba2ccc5a7b1a65d3697c9e2c109c41","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[ska] relocate dataset quality api-integration tests","number":227826,"url":"https://github.com/elastic/kibana/pull/227826","mergeCommit":{"message":"[ska] relocate dataset quality api-integration tests (#227826)\n\n## Summary\n\nPart of https://github.com/elastic/kibana-team/issues/1503\n\nThis PR is mostly about moving platform data quality api tests from\nx-pack/test\n\n```\nx-pack/test/\n | - dataset_quality_api_integration\n```\n\nAfter: \n```\nx-pack/solutions/observability/test/\n | - dataset_quality_api_integration\n```\n\nI also did a small cleanup of no longer used duplicated services under\n`x-pack/test/api_integration`\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"e7c6fe5717ba2ccc5a7b1a65d3697c9e2c109c41"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227826","number":227826,"mergeCommit":{"message":"[ska] relocate dataset quality api-integration tests (#227826)\n\n## Summary\n\nPart of https://github.com/elastic/kibana-team/issues/1503\n\nThis PR is mostly about moving platform data quality api tests from\nx-pack/test\n\n```\nx-pack/test/\n | - dataset_quality_api_integration\n```\n\nAfter: \n```\nx-pack/solutions/observability/test/\n | - dataset_quality_api_integration\n```\n\nI also did a small cleanup of no longer used duplicated services under\n`x-pack/test/api_integration`\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"e7c6fe5717ba2ccc5a7b1a65d3697c9e2c109c41"}}]}] BACKPORT--> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
removed
the
backport missing
Bluefinger
pushed a commit
to Bluefinger/kibana
that referenced
this pull request
Jul 22, 2025
## Summary Part of elastic/kibana-team#1503 This PR is mostly about moving platform data quality api tests from x-pack/test ``` x-pack/test/ | - dataset_quality_api_integration ``` After: ``` x-pack/solutions/observability/test/ | - dataset_quality_api_integration ``` I also did a small cleanup of no longer used duplicated services under `x-pack/test/api_integration` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
## Summary Part of elastic/kibana-team#1503 This PR is mostly about moving platform data quality api tests from x-pack/test ``` x-pack/test/ | - dataset_quality_api_integration ``` After: ``` x-pack/solutions/observability/test/ | - dataset_quality_api_integration ``` I also did a small cleanup of no longer used duplicated services under `x-pack/test/api_integration` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This was referenced Jul 30, 2025
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
fake-haris
added a commit
that referenced
this pull request
Aug 5, 2025
…#230438) # Backport This will backport the following commits from `main` to `8.19`: - [[ska] relocate dataset quality api-integration tests (#227826)](#227826) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Dzmitry Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2025-07-15T11:35:02Z","message":"[ska] relocate dataset quality api-integration tests (#227826)\n\n## Summary\n\nPart of https://github.com/elastic/kibana-team/issues/1503\n\nThis PR is mostly about moving platform data quality api tests from\nx-pack/test\n\n```\nx-pack/test/\n | - dataset_quality_api_integration\n```\n\nAfter: \n```\nx-pack/solutions/observability/test/\n | - dataset_quality_api_integration\n```\n\nI also did a small cleanup of no longer used duplicated services under\n`x-pack/test/api_integration`\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"e7c6fe5717ba2ccc5a7b1a65d3697c9e2c109c41","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[ska] relocate dataset quality api-integration tests","number":227826,"url":"https://github.com/elastic/kibana/pull/227826","mergeCommit":{"message":"[ska] relocate dataset quality api-integration tests (#227826)\n\n## Summary\n\nPart of https://github.com/elastic/kibana-team/issues/1503\n\nThis PR is mostly about moving platform data quality api tests from\nx-pack/test\n\n```\nx-pack/test/\n | - dataset_quality_api_integration\n```\n\nAfter: \n```\nx-pack/solutions/observability/test/\n | - dataset_quality_api_integration\n```\n\nI also did a small cleanup of no longer used duplicated services under\n`x-pack/test/api_integration`\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"e7c6fe5717ba2ccc5a7b1a65d3697c9e2c109c41"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/228217","number":228217,"state":"MERGED","mergeCommit":{"sha":"818f613f82139b4ebbf6f941b4ebd37dad8a620f","message":"[9.1] [ska] relocate dataset quality api-integration tests (#227826) (#228217)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.1`:\n- [[ska] relocate dataset quality api-integration tests\n(#227826)](https://github.com/elastic/kibana/pull/227826)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227826","number":227826,"mergeCommit":{"message":"[ska] relocate dataset quality api-integration tests (#227826)\n\n## Summary\n\nPart of https://github.com/elastic/kibana-team/issues/1503\n\nThis PR is mostly about moving platform data quality api tests from\nx-pack/test\n\n```\nx-pack/test/\n | - dataset_quality_api_integration\n```\n\nAfter: \n```\nx-pack/solutions/observability/test/\n | - dataset_quality_api_integration\n```\n\nI also did a small cleanup of no longer used duplicated services under\n`x-pack/test/api_integration`\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"e7c6fe5717ba2ccc5a7b1a65d3697c9e2c109c41"}}]}] BACKPORT--> --------- Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of https://github.com/elastic/kibana-team/issues/1503
This PR is mostly about moving platform data quality api tests from x-pack/test
After:
I also did a small cleanup of no longer used duplicated services under
x-pack/test/api_integration