[DataView] Fix flyout styles#228078
Merged
jughosta merged 3 commits intoelastic:mainfrom Jul 17, 2025
Merged
Conversation
jughosta
commented
Jul 16, 2025
| defaultVisible={editData?.getAllowHidden()} | ||
| /> | ||
| </Form> | ||
| </FlyoutPanels.Content> |
Contributor
Author
There was a problem hiding this comment.
Wrapped the title and the form with FlyoutPanels.Content. Excluding the footer.
jughosta
added
Feature:Data Views
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @jughosta |
davismcphee
approved these changes
Jul 17, 2025
Contributor
There was a problem hiding this comment.
LGTM, thanks for fixing it!
The only thing I noticed is that on small screen sizes, the second panel is completely hidden now. But I checked an older version, and even then it was only partially visible and unable to scroll fully into view, so it's not really much worse now:
Contributor
Author
Seems the same on main. We can address it separately. |
Contributor
|
Starting backport for target branches: 8.19, 9.1 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 17, 2025
- Closes elastic#227951 ## Summary Before: <img width="1508" height="792" alt="Screenshot 2025-07-15 at 11 09 01" src="https://github.com/user-attachments/assets/4108c6af-0303-46df-8444-cf865c03714a" /> After: <img width="1719" height="810" alt="Screenshot 2025-07-16 at 11 13 25" src="https://github.com/user-attachments/assets/7e4cfd2d-a37b-492b-ac62-ec8e95d1d746" /> ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 74c5788)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 17, 2025
# Backport This will backport the following commits from `main` to `9.1`: - [[DataView] Fix flyout styles (#228078)](#228078) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2025-07-17T07:23:41Z","message":"[DataView] Fix flyout styles (#228078)\n\n- Closes https://github.com/elastic/kibana/issues/227951\n\n## Summary\n\nBefore:\n<img width=\"1508\" height=\"792\" alt=\"Screenshot 2025-07-15 at 11 09 01\"\nsrc=\"https://github.com/user-attachments/assets/4108c6af-0303-46df-8444-cf865c03714a\"\n/>\n\nAfter:\n<img width=\"1719\" height=\"810\" alt=\"Screenshot 2025-07-16 at 11 13 25\"\nsrc=\"https://github.com/user-attachments/assets/7e4cfd2d-a37b-492b-ac62-ec8e95d1d746\"\n/>\n\n\n\n\n### Checklist\n\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"74c5788a5d0f69582e633005f55a588f8f03a6bf","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:Data Views","Team:DataDiscovery","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[DataView] Fix flyout styles","number":228078,"url":"https://github.com/elastic/kibana/pull/228078","mergeCommit":{"message":"[DataView] Fix flyout styles (#228078)\n\n- Closes https://github.com/elastic/kibana/issues/227951\n\n## Summary\n\nBefore:\n<img width=\"1508\" height=\"792\" alt=\"Screenshot 2025-07-15 at 11 09 01\"\nsrc=\"https://github.com/user-attachments/assets/4108c6af-0303-46df-8444-cf865c03714a\"\n/>\n\nAfter:\n<img width=\"1719\" height=\"810\" alt=\"Screenshot 2025-07-16 at 11 13 25\"\nsrc=\"https://github.com/user-attachments/assets/7e4cfd2d-a37b-492b-ac62-ec8e95d1d746\"\n/>\n\n\n\n\n### Checklist\n\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"74c5788a5d0f69582e633005f55a588f8f03a6bf"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/228078","number":228078,"mergeCommit":{"message":"[DataView] Fix flyout styles (#228078)\n\n- Closes https://github.com/elastic/kibana/issues/227951\n\n## Summary\n\nBefore:\n<img width=\"1508\" height=\"792\" alt=\"Screenshot 2025-07-15 at 11 09 01\"\nsrc=\"https://github.com/user-attachments/assets/4108c6af-0303-46df-8444-cf865c03714a\"\n/>\n\nAfter:\n<img width=\"1719\" height=\"810\" alt=\"Screenshot 2025-07-16 at 11 13 25\"\nsrc=\"https://github.com/user-attachments/assets/7e4cfd2d-a37b-492b-ac62-ec8e95d1d746\"\n/>\n\n\n\n\n### Checklist\n\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"74c5788a5d0f69582e633005f55a588f8f03a6bf"}}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jughosta
added a commit
to jughosta/kibana
that referenced
this pull request
Jul 20, 2025
- Closes elastic#227951 ## Summary Before: <img width="1508" height="792" alt="Screenshot 2025-07-15 at 11 09 01" src="https://github.com/user-attachments/assets/4108c6af-0303-46df-8444-cf865c03714a" /> After: <img width="1719" height="810" alt="Screenshot 2025-07-16 at 11 13 25" src="https://github.com/user-attachments/assets/7e4cfd2d-a37b-492b-ac62-ec8e95d1d746" /> ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 74c5788) # Conflicts: # src/platform/plugins/shared/data_view_editor/public/components/data_view_editor_flyout_content.tsx # src/platform/plugins/shared/data_view_editor/public/components/footer/footer.tsx
Bluefinger
pushed a commit
to Bluefinger/kibana
that referenced
this pull request
Jul 22, 2025
- Closes elastic#227951 ## Summary Before: <img width="1508" height="792" alt="Screenshot 2025-07-15 at 11 09 01" src="https://github.com/user-attachments/assets/4108c6af-0303-46df-8444-cf865c03714a" /> After: <img width="1719" height="810" alt="Screenshot 2025-07-16 at 11 13 25" src="https://github.com/user-attachments/assets/7e4cfd2d-a37b-492b-ac62-ec8e95d1d746" /> ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
jughosta
added a commit
that referenced
this pull request
Jul 23, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [[DataView] Fix flyout styles (#228078)](#228078) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2025-07-17T07:23:41Z","message":"[DataView] Fix flyout styles (#228078)\n\n- Closes https://github.com/elastic/kibana/issues/227951\n\n## Summary\n\nBefore:\n<img width=\"1508\" height=\"792\" alt=\"Screenshot 2025-07-15 at 11 09 01\"\nsrc=\"https://github.com/user-attachments/assets/4108c6af-0303-46df-8444-cf865c03714a\"\n/>\n\nAfter:\n<img width=\"1719\" height=\"810\" alt=\"Screenshot 2025-07-16 at 11 13 25\"\nsrc=\"https://github.com/user-attachments/assets/7e4cfd2d-a37b-492b-ac62-ec8e95d1d746\"\n/>\n\n\n\n\n### Checklist\n\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"74c5788a5d0f69582e633005f55a588f8f03a6bf","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:Data Views","Team:DataDiscovery","backport:version","v9.1.0","v8.19.0","v9.2.0"],"title":"[DataView] Fix flyout styles","number":228078,"url":"https://github.com/elastic/kibana/pull/228078","mergeCommit":{"message":"[DataView] Fix flyout styles (#228078)\n\n- Closes https://github.com/elastic/kibana/issues/227951\n\n## Summary\n\nBefore:\n<img width=\"1508\" height=\"792\" alt=\"Screenshot 2025-07-15 at 11 09 01\"\nsrc=\"https://github.com/user-attachments/assets/4108c6af-0303-46df-8444-cf865c03714a\"\n/>\n\nAfter:\n<img width=\"1719\" height=\"810\" alt=\"Screenshot 2025-07-16 at 11 13 25\"\nsrc=\"https://github.com/user-attachments/assets/7e4cfd2d-a37b-492b-ac62-ec8e95d1d746\"\n/>\n\n\n\n\n### Checklist\n\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"74c5788a5d0f69582e633005f55a588f8f03a6bf"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/228376","number":228376,"state":"MERGED","mergeCommit":{"sha":"ae1da899f7e400bb118bdc42944f65ab228c4e3d","message":"[9.1] [DataView] Fix flyout styles (#228078) (#228376)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.1`:\n- [[DataView] Fix flyout styles\n(#228078)](https://github.com/elastic/kibana/pull/228078)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/228078","number":228078,"mergeCommit":{"message":"[DataView] Fix flyout styles (#228078)\n\n- Closes https://github.com/elastic/kibana/issues/227951\n\n## Summary\n\nBefore:\n<img width=\"1508\" height=\"792\" alt=\"Screenshot 2025-07-15 at 11 09 01\"\nsrc=\"https://github.com/user-attachments/assets/4108c6af-0303-46df-8444-cf865c03714a\"\n/>\n\nAfter:\n<img width=\"1719\" height=\"810\" alt=\"Screenshot 2025-07-16 at 11 13 25\"\nsrc=\"https://github.com/user-attachments/assets/7e4cfd2d-a37b-492b-ac62-ec8e95d1d746\"\n/>\n\n\n\n\n### Checklist\n\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"74c5788a5d0f69582e633005f55a588f8f03a6bf"}}]}] BACKPORT-->
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
- Closes elastic#227951 ## Summary Before: <img width="1508" height="792" alt="Screenshot 2025-07-15 at 11 09 01" src="https://github.com/user-attachments/assets/4108c6af-0303-46df-8444-cf865c03714a" /> After: <img width="1719" height="810" alt="Screenshot 2025-07-16 at 11 13 25" src="https://github.com/user-attachments/assets/7e4cfd2d-a37b-492b-ac62-ec8e95d1d746" /> ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before:
After:
Checklist
release_note:*label is applied per the guidelinesbackport:*labels.