[ES|QL] Lookup index - Add warning message when dropping a file upon unsaved data#228146
Merged
sddonne merged 70 commits intoelastic:feature/lookup-join-uxfrom Jul 29, 2025
Merged
Conversation
sddonne
changed the title
sddonne
commented
Jul 23, 2025
| for (const column of pendingColumnsToBeSaved) { | ||
| if (!dataView.fields.getByName(column.name)) { | ||
| dataView.fields.add({ | ||
| const unsavedFields = pendingColumnsToBeSaved |
sddonne
added a commit
that referenced
this pull request
Jul 24, 2025
Part of #207330 ## Summary While columns are not saved into elastic search, allow editing it's names. * Created `colum_input_control.tsx` as counterpart to `value_input_control.tsx` to hold the custom renderization of the header columns. * Moved both into a folder `grid_custom_redenderers` folder. * Added a new action to edit the name of unsaved columns. * Allow deleting unsaved columns. * Improve how unsavedColumns are tracked: * They are now added to the dataview after being saved, otherwise they would be shown after discarding changes. * This change is also present in #228146, had to bring it as it was needed here too. https://github.com/user-attachments/assets/ee97a1cf-171a-4acb-b31a-020a359eb8ed
darnautov
reviewed
Jul 28, 2025
src/platform/packages/private/kbn-index-editor/src/components/file_drop_zone.tsx
Outdated
Show resolved
Hide resolved
src/platform/packages/private/kbn-index-editor/src/components/modals/override_warning_modal.tsx
Outdated
Show resolved
Hide resolved
src/platform/packages/private/kbn-index-editor/src/components/modals/override_warning_modal.tsx
Outdated
Show resolved
Hide resolved
src/platform/packages/private/kbn-index-editor/src/hooks/use_dont_show_me_again.tsx
Outdated
Show resolved
Hide resolved
Contributor
💔 Build Failed
Failed CI StepsMetrics [docs]
History
|
sddonne
merged commit 4cde6bc
into
elastic:feature/lookup-join-ux
11 of 12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #207330
Design
Summary
Screen.Recording.2025-07-16.at.10.27.55.mov