[ES|QL] Adds "Prettify" button in the editor and removes the abiity to unwrap

[stratoula]

Summary

Closes #223209

Removes the wrap button and inserts a prettify one instead. It is currently missing the icon.

[elasticmachine]

Pinging @elastic/kibana-esql (Team:ESQL)

[vadimkibana]

Nice! Code changes LGTM.

[drewdaemon]

"Prettify" is fun! But is "Format" easier to translate?

[stratoula]

"Prettify" is fun! But is "Format" easier to translate?

Mmm I personally prefer Prettify but I am not a native speaker. @andreadelrio @florent-leborgne wdyt?

We are talking about the tooltip

[florent-leborgne]

@stratoula No strong opinion on my end. "Prettify query" is perfectly valid and even slightly more engaging than a classic "Format query" (which would be very fine too). It's slightly harder to translate without surrounding context though, if that is a concern 😅

[drewdaemon]

I think "Prettify" is more fun. Maybe we go with that and change it if it raises eyebrows.

[stratoula]

@florent-leborgne you are right. I should have given you more context. We have this button in the editor which when the user clicks it the ES|QL query changes in order to be more readable. We add some indent, we are wrapping, we change the keywords from lowercase to uppercase etc

[florent-leborgne]

@stratoula thanks for the added details. I was just saying that translators (or the machines that translate our content 🤔) might not correctly translate "prettify" if they translate it literally because they often lack that context :D (like in french it should be translated to "formatter" anyways because the literal translation of "prettify" would make no sense 😂). So in case there is a strong concern with how this could be translated, or if we're unable to make a note for the translator, "Format" is maybe a safer option.

If not, let's keep "Prettify", because we all prefer this term :)

[stratoula]

Ah I see!! It is a good point! But as Drew said let's try Prettify (super cute) and if we have concerns we can always change it

I could change the key to format to make it more clear for them

[elasticmachine]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: d5c152f

Failed CI Steps

• FTR Configs #93

Test Failures

• [job] [logs] FTR Configs #93 / Air-gapped environment with pre-bundled packages @ess @serverless @skipInServerlessMKI Install bundled package should install prebuilt rules from the package that comes bundled with Kibana

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
@kbn/esql-utils	100	99	-1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
esql	258.0KB	257.6KB	-389.0B
securitySolution	9.8MB	9.8MB	+10.0B
total			-379.0B

Unknown metric groups

API count

id	before	after	diff
@kbn/esql-utils	118	117	-1

References to deprecated APIs

id	before	after	diff
@kbn/esql-utils	35	34	-1

History

• 💔 Build #324373 failed 1955f52
• 💛 Build #323765 was flaky 85ae8b5
• 💔 Build #323656 failed 51beb90
• 💔 Build #323223 failed 980ac2a
• 💚 Build #321641 succeeded 62c10e1
• 💛 Build #319928 was flaky b6b2a97