Skip to content

[8.19] [Lens] Fix palette switching on Partition charts (#228051)#228241

Merged
kibanamachine merged 4 commits intoelastic:8.19from
kibanamachine:backport/8.19/pr-228051
Jul 23, 2025
Merged

[8.19] [Lens] Fix palette switching on Partition charts (#228051)#228241
kibanamachine merged 4 commits intoelastic:8.19from
kibanamachine:backport/8.19/pr-228051

Conversation

@kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

## Summary

Fixes issue in Lens Partition chart which prevented the user from
switching legacy palettes.

https://github.com/user-attachments/assets/1cc3d222-f823-4135-9fde-257b75ebfbe0

Fixes elastic#227922

## Details

The issue here was that we are using `useDebouncedValue` which sets the
value async. When the user selects a legacy palette we call
`setLocalState` to set the palette then immediately call
`setColorMapping` which was overriding the palette changes.

Really we just need to clear the `colorMapping` when a `palette` is set.
Instead of doing this every time the palette is set, I added the
`onModeChange` callback to clear the `colorMapping` once when the mode
is set to legacy.

## Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

## Release Notes

Fixes an issue where a Lens Partition chart (i.e. `Pie`) prevented the
user from selecting a legacy palette.

(cherry picked from commit 3cd7dec)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Jul 16, 2025
@kibanamachine kibanamachine enabled auto-merge (squash) July 16, 2025 14:55
@kibanamachine kibanamachine merged commit 1240626 into elastic:8.19 Jul 23, 2025
8 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #44 / Upgrade Assistant ES deprecation logs flyout Shows no warnings callout if there are no deprecations

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +32.0B

History

cc @nickofthyme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

3 participants