[9.1] [Lens] Forward secondary prefix correctly when state value is an empty string (None option) (#228183)#228424
Merged
kibanamachine merged 1 commit intoelastic:9.1from Jul 17, 2025
Conversation
…y string (`None` option) (elastic#228183) Closes elastic#227281 ## Summary When going from state to expression, the secondaryPrefix value wasn't forwarded correctly when the secondaryPrefix state value was an empty string (the empty string is set in the state when the Prefix "None" option is selected in settings). It was forwarded as `undefined`, causing showing the column name as the prefix on: https://github.com/elastic/kibana/blob/2928bdf1cb5f8fd648c6a46a52ae3f96b4b01a70/src/platform/plugins/shared/chart_expressions/expression_metric/public/components/secondary_metric.tsx#L255 #### After: https://github.com/user-attachments/assets/1a104f9e-bf78-4acc-aca5-a3866c80d03f ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit d1846d3)
Merged
3 tasks
![github-actions[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.1:Noneoption) (#228183)Questions ?
Please refer to the Backport tool documentation