[Discover] Fix Drag-n-Drop on Firefox in Lens inline editor flyout#228849
Merged
nickofthyme merged 1 commit intoelastic:mainfrom Jul 23, 2025
Merged
[Discover] Fix Drag-n-Drop on Firefox in Lens inline editor flyout#228849nickofthyme merged 1 commit intoelastic:mainfrom
nickofthyme merged 1 commit intoelastic:mainfrom
Conversation
nickofthyme
added
Feature:Discover
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
|
andrimal
approved these changes
Jul 22, 2025
Contributor
Author
|
This fix will be backported with #228625 backports |
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
…lastic#228849) ## Summary This PR adds the `clip-path: none` fix to the ESQL Lens inline flyout in discover. This was missed in elastic#228625. https://github.com/user-attachments/assets/c6b04ef6-9b4c-40b9-b676-c8b28a26c816 > With the current `clip-path` the scrolling does not work properly, with the default eui-flyout `clip-path` the extra drop targets outside of the flyout are cut off (see below). Setting `clip-path` to `none` fixes both issues. >  Fixes elastic#227939 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ## Release Note Fixes an issue on Firefox where the ESQL inline editor in discover would prevent scrolling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
clip-path: nonefix to the ESQL Lens inline flyout in discover. This was missed in #228625.Zight.Recording.2025-07-21.at.02.22.22.PM.mp4
Fixes #227939
Checklist
release_note:*label is applied per the guidelinesbackport:*labels.Release Note
Fixes an issue on Firefox where the ESQL inline editor in discover would prevent scrolling.