[8.18] [Discover] Fix "Body cell lines" display option handling when default value is -1 (#228697)#228880
Merged
davismcphee merged 3 commits intoelastic:8.18from Jul 24, 2025
Merged
Conversation
… value is `-1` (elastic#228697) ## Summary This PR fixes the handling of the "Body cell lines" display option in Discover when the default value is set to `-1` in Advanced Settings. It will now set the cell lines input to a default value instead of `-1` in this case, and will not prevent users from switching from "Auto" to "Custom" mode. Additionally, some changes were made to the validation to address some bugs and improve the UX: - Manually setting a value of `-1` does not automatically switch to "Auto" mode and cause the user to get stuck again. - The last valid input value will be restored when switching from "Custom" to "Auto" with an invalid value. - Deleting the current value allows users to actually clear the input and enter a new value instead of it automatically being reset to `1` or `0`. Fixes elastic#228682. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit de5e2a6) # Conflicts: # src/platform/packages/shared/kbn-unified-data-table/src/components/data_table_additional_display_settings.tsx
8 tasks
davismcphee
added
the
Team:DataDiscovery
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
History
cc @davismcphee |
AlexGPlay
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.18:-1(#228697)Questions ?
Please refer to the Backport tool documentation