Skip to content

[Discover][Query Bar] Enable "Save Query" button after making changes in the save query menu #229053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MiloszRadzynski merged 5 commits into from
Jul 30, 2025
Merged

[Discover][Query Bar] Enable "Save Query" button after making changes in the save query menu #229053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b5facc7
Assign an empty array to the saved query object filters property when…
MiloszRadzynski Jul 23, 2025
0a7f826
Add functional test
MiloszRadzynski Jul 24, 2025
bea19a4
Change if statement to expect in functional test
MiloszRadzynski Jul 25, 2025
f63c50c
Revert changes and modify the comparision logic for filters
MiloszRadzynski Jul 29, 2025
340b0b8
Merge branch 'main' into save-query-disabled-button-fix
MiloszRadzynski Jul 29, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...latform/plugins/shared/unified_search/public/query_string_input/query_bar_menu_panels.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,9 +260,10 @@ export function useQueryBarMenuPanels({

useEffect(() => {
if (savedQuery) {
const filtersHaveChanged = Boolean(
savedQuery?.attributes.filters &&
!compareFilters(filters ?? [], savedQuery.attributes.filters, COMPARE_ALL_OPTIONS)
const filtersHaveChanged = !compareFilters(
Copy link
Contributor

@ThomThomson ThomThomson Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much better, thank you for making the change!
filters ?? [],
savedQuery.attributes.filters ?? [],
COMPARE_ALL_OPTIONS
);

const timeFilterHasChanged = Boolean(
Expand Down
31 changes: 31 additions & 0 deletions src/platform/test/functional/apps/discover/ccs_compatibility/_saved_queries.ts
View file
Open in desktop
Copy link
Contributor

@davismcphee davismcphee Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context in case you haven't come across it yet, ccs_compatibility stands for cross-cluster search, and it's odd that all our saved query management tests live here 😅 But it does seem like the most appropriate place for this test currently.
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,37 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await queryBar.switchQueryLanguage('lucene');
expect(await queryBar.getQueryString()).to.eql('');
});

it('checks if the "Save query" button becomes enabled after adding filters, even when the query was saved with "Include filters" unchecked', async () => {
await queryBar.setQuery('response:200');
await queryBar.submitQuery();
await savedQueryManagementComponent.saveNewQuery('filterExcluded', '', false, false);
await savedQueryManagementComponent.savedQueryExistOrFail('filterExcluded');
await savedQueryManagementComponent.closeSavedQueryManagementComponent();
await savedQueryManagementComponent.openSavedQueryManagementComponent();
let isSaveButtonDisabled = await testSubjects.getAttribute(
'saved-query-management-save-button',
'disabled'
);
expect(isSaveButtonDisabled).to.equal(
'true',
'Save button should be disabled directly after saving a query'
);
await filterBar.addFilter({ field: '@message', operation: 'exists' });
await savedQueryManagementComponent.openSavedQueryManagementComponent();
isSaveButtonDisabled = await testSubjects.getAttribute(
'saved-query-management-save-button',
'disabled'
);
expect(isSaveButtonDisabled).to.equal(
null,
'Save button should be enabled after adding a filter'
);
const updateQueryButtonExists = await testSubjects.exists(
'saved-query-management-save-changes-button'
);
expect(updateQueryButtonExists).to.equal(true, 'Update query button does not exist');
});
});
});
}