[Discover] Improve performance of breakdown field search#229335
Merged
jughosta merged 7 commits intoelastic:mainfrom Jul 28, 2025
Merged
[Discover] Improve performance of breakdown field search#229335jughosta merged 7 commits intoelastic:mainfrom
jughosta merged 7 commits intoelastic:mainfrom
Conversation
jughosta
added
release_note:fix
v9.0.0
Team:DataDiscovery
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
AlexGPlay
reviewed
Jul 25, 2025
Comment on lines
+191
to
+193
| act(() => { | ||
| button.click(); | ||
| }); |
Contributor
There was a problem hiding this comment.
can we use userEvent for this actions?
AlexGPlay
reviewed
Jul 25, 2025
Comment on lines
+218
to
+219
| input.focus(); | ||
| fireEvent.change(input, { target: { value: 'extee' } }); |
Contributor
There was a problem hiding this comment.
same here, can we use userEvent?
Contributor
Author
There was a problem hiding this comment.
It did not work with useEvent when I tried (because it thinks for some reason that it can't accept pointer events) so I went with fireEvent here.
AlexGPlay
reviewed
Jul 25, 2025
| ); | ||
|
|
||
| const filteredOptions = useMemo( | ||
| function filterOptionsForSearchValue() { |
Contributor
There was a problem hiding this comment.
q: why is this one not an anonymous function?
Contributor
Author
There was a problem hiding this comment.
Having names for functions allows to see them when profiling.
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @jughosta |
Contributor
|
/oblt-deploy |
yngrdyn
approved these changes
Jul 28, 2025
Contributor
yngrdyn
left a comment
yngrdyn
left a comment
There was a problem hiding this comment.
Everything is working as expected in Data set quality
Screen.Recording.2025-07-28.at.15.26.43.mov
Contributor
|
Starting backport for target branches: 8.18, 8.19, 9.0, 9.1 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 28, 2025
) - Closes elastic#221362 ## Summary This PR moves the filtering logic from `EuiSelectable` to Kibana side so we can optimize and debounce it for Breakdown dropdown on Discover page. And looks like this component is also used somewhere in dataset quality details area. Before (ui freeze): <img width="1203" height="423" alt="Screenshot 2025-07-25 at 14 24 55" src="https://github.com/user-attachments/assets/682d923d-3996-4bb2-9e3b-d3daa27197f5" /> After (debounced calculations): <img width="1196" height="525" alt="Screenshot 2025-07-25 at 14 34 03" src="https://github.com/user-attachments/assets/70987d23-934c-4aa7-90a5-e69759e10beb" /> This fix prevents the "freezing" of the UI during the search. Next possible step would be to evaluate when to enable/disable fuzzy search. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 2ef6e95)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 28, 2025
) - Closes elastic#221362 ## Summary This PR moves the filtering logic from `EuiSelectable` to Kibana side so we can optimize and debounce it for Breakdown dropdown on Discover page. And looks like this component is also used somewhere in dataset quality details area. Before (ui freeze): <img width="1203" height="423" alt="Screenshot 2025-07-25 at 14 24 55" src="https://github.com/user-attachments/assets/682d923d-3996-4bb2-9e3b-d3daa27197f5" /> After (debounced calculations): <img width="1196" height="525" alt="Screenshot 2025-07-25 at 14 34 03" src="https://github.com/user-attachments/assets/70987d23-934c-4aa7-90a5-e69759e10beb" /> This fix prevents the "freezing" of the UI during the search. Next possible step would be to evaluate when to enable/disable fuzzy search. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 2ef6e95)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 28, 2025
) - Closes elastic#221362 ## Summary This PR moves the filtering logic from `EuiSelectable` to Kibana side so we can optimize and debounce it for Breakdown dropdown on Discover page. And looks like this component is also used somewhere in dataset quality details area. Before (ui freeze): <img width="1203" height="423" alt="Screenshot 2025-07-25 at 14 24 55" src="https://github.com/user-attachments/assets/682d923d-3996-4bb2-9e3b-d3daa27197f5" /> After (debounced calculations): <img width="1196" height="525" alt="Screenshot 2025-07-25 at 14 34 03" src="https://github.com/user-attachments/assets/70987d23-934c-4aa7-90a5-e69759e10beb" /> This fix prevents the "freezing" of the UI during the search. Next possible step would be to evaluate when to enable/disable fuzzy search. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 2ef6e95)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 28, 2025
) - Closes elastic#221362 ## Summary This PR moves the filtering logic from `EuiSelectable` to Kibana side so we can optimize and debounce it for Breakdown dropdown on Discover page. And looks like this component is also used somewhere in dataset quality details area. Before (ui freeze): <img width="1203" height="423" alt="Screenshot 2025-07-25 at 14 24 55" src="https://github.com/user-attachments/assets/682d923d-3996-4bb2-9e3b-d3daa27197f5" /> After (debounced calculations): <img width="1196" height="525" alt="Screenshot 2025-07-25 at 14 34 03" src="https://github.com/user-attachments/assets/70987d23-934c-4aa7-90a5-e69759e10beb" /> This fix prevents the "freezing" of the UI during the search. Next possible step would be to evaluate when to enable/disable fuzzy search. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 2ef6e95)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 28, 2025
…) (#229649) # Backport This will backport the following commits from `main` to `9.1`: - [[Discover] Improve performance of breakdown field search (#229335)](#229335) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2025-07-28T13:29:02Z","message":"[Discover] Improve performance of breakdown field search (#229335)\n\n- Closes https://github.com/elastic/kibana/issues/221362\n\n## Summary\n\nThis PR moves the filtering logic from `EuiSelectable` to Kibana side so\nwe can optimize and debounce it for Breakdown dropdown on Discover page.\nAnd looks like this component is also used somewhere in dataset quality\ndetails area.\n\nBefore (ui freeze):\n<img width=\"1203\" height=\"423\" alt=\"Screenshot 2025-07-25 at 14 24 55\"\nsrc=\"https://github.com/user-attachments/assets/682d923d-3996-4bb2-9e3b-d3daa27197f5\"\n/>\n\nAfter (debounced calculations):\n<img width=\"1196\" height=\"525\" alt=\"Screenshot 2025-07-25 at 14 34 03\"\nsrc=\"https://github.com/user-attachments/assets/70987d23-934c-4aa7-90a5-e69759e10beb\"\n/>\n\nThis fix prevents the \"freezing\" of the UI during the search. Next\npossible step would be to evaluate when to enable/disable fuzzy search.\n\n\n### Checklist\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"2ef6e9550536259ff3278c201aebec01f9bd02a0","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:version","v9.2.0","v9.0.5","v9.1.1","v8.18.5","v8.19.1"],"title":"[Discover] Improve performance of breakdown field search","number":229335,"url":"https://github.com/elastic/kibana/pull/229335","mergeCommit":{"message":"[Discover] Improve performance of breakdown field search (#229335)\n\n- Closes https://github.com/elastic/kibana/issues/221362\n\n## Summary\n\nThis PR moves the filtering logic from `EuiSelectable` to Kibana side so\nwe can optimize and debounce it for Breakdown dropdown on Discover page.\nAnd looks like this component is also used somewhere in dataset quality\ndetails area.\n\nBefore (ui freeze):\n<img width=\"1203\" height=\"423\" alt=\"Screenshot 2025-07-25 at 14 24 55\"\nsrc=\"https://github.com/user-attachments/assets/682d923d-3996-4bb2-9e3b-d3daa27197f5\"\n/>\n\nAfter (debounced calculations):\n<img width=\"1196\" height=\"525\" alt=\"Screenshot 2025-07-25 at 14 34 03\"\nsrc=\"https://github.com/user-attachments/assets/70987d23-934c-4aa7-90a5-e69759e10beb\"\n/>\n\nThis fix prevents the \"freezing\" of the UI during the search. Next\npossible step would be to evaluate when to enable/disable fuzzy search.\n\n\n### Checklist\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"2ef6e9550536259ff3278c201aebec01f9bd02a0"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","9.1","8.18","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/229335","number":229335,"mergeCommit":{"message":"[Discover] Improve performance of breakdown field search (#229335)\n\n- Closes https://github.com/elastic/kibana/issues/221362\n\n## Summary\n\nThis PR moves the filtering logic from `EuiSelectable` to Kibana side so\nwe can optimize and debounce it for Breakdown dropdown on Discover page.\nAnd looks like this component is also used somewhere in dataset quality\ndetails area.\n\nBefore (ui freeze):\n<img width=\"1203\" height=\"423\" alt=\"Screenshot 2025-07-25 at 14 24 55\"\nsrc=\"https://github.com/user-attachments/assets/682d923d-3996-4bb2-9e3b-d3daa27197f5\"\n/>\n\nAfter (debounced calculations):\n<img width=\"1196\" height=\"525\" alt=\"Screenshot 2025-07-25 at 14 34 03\"\nsrc=\"https://github.com/user-attachments/assets/70987d23-934c-4aa7-90a5-e69759e10beb\"\n/>\n\nThis fix prevents the \"freezing\" of the UI during the search. Next\npossible step would be to evaluate when to enable/disable fuzzy search.\n\n\n### Checklist\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"2ef6e9550536259ff3278c201aebec01f9bd02a0"}},{"branch":"9.0","label":"v9.0.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Jul 28, 2025
) (#229645) # Backport This will backport the following commits from `main` to `8.18`: - [[Discover] Improve performance of breakdown field search (#229335)](#229335) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2025-07-28T13:29:02Z","message":"[Discover] Improve performance of breakdown field search (#229335)\n\n- Closes https://github.com/elastic/kibana/issues/221362\n\n## Summary\n\nThis PR moves the filtering logic from `EuiSelectable` to Kibana side so\nwe can optimize and debounce it for Breakdown dropdown on Discover page.\nAnd looks like this component is also used somewhere in dataset quality\ndetails area.\n\nBefore (ui freeze):\n<img width=\"1203\" height=\"423\" alt=\"Screenshot 2025-07-25 at 14 24 55\"\nsrc=\"https://github.com/user-attachments/assets/682d923d-3996-4bb2-9e3b-d3daa27197f5\"\n/>\n\nAfter (debounced calculations):\n<img width=\"1196\" height=\"525\" alt=\"Screenshot 2025-07-25 at 14 34 03\"\nsrc=\"https://github.com/user-attachments/assets/70987d23-934c-4aa7-90a5-e69759e10beb\"\n/>\n\nThis fix prevents the \"freezing\" of the UI during the search. Next\npossible step would be to evaluate when to enable/disable fuzzy search.\n\n\n### Checklist\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"2ef6e9550536259ff3278c201aebec01f9bd02a0","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:version","v9.2.0","v9.0.5","v9.1.1","v8.18.5","v8.19.1"],"title":"[Discover] Improve performance of breakdown field search","number":229335,"url":"https://github.com/elastic/kibana/pull/229335","mergeCommit":{"message":"[Discover] Improve performance of breakdown field search (#229335)\n\n- Closes https://github.com/elastic/kibana/issues/221362\n\n## Summary\n\nThis PR moves the filtering logic from `EuiSelectable` to Kibana side so\nwe can optimize and debounce it for Breakdown dropdown on Discover page.\nAnd looks like this component is also used somewhere in dataset quality\ndetails area.\n\nBefore (ui freeze):\n<img width=\"1203\" height=\"423\" alt=\"Screenshot 2025-07-25 at 14 24 55\"\nsrc=\"https://github.com/user-attachments/assets/682d923d-3996-4bb2-9e3b-d3daa27197f5\"\n/>\n\nAfter (debounced calculations):\n<img width=\"1196\" height=\"525\" alt=\"Screenshot 2025-07-25 at 14 34 03\"\nsrc=\"https://github.com/user-attachments/assets/70987d23-934c-4aa7-90a5-e69759e10beb\"\n/>\n\nThis fix prevents the \"freezing\" of the UI during the search. Next\npossible step would be to evaluate when to enable/disable fuzzy search.\n\n\n### Checklist\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"2ef6e9550536259ff3278c201aebec01f9bd02a0"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","9.1","8.18","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/229335","number":229335,"mergeCommit":{"message":"[Discover] Improve performance of breakdown field search (#229335)\n\n- Closes https://github.com/elastic/kibana/issues/221362\n\n## Summary\n\nThis PR moves the filtering logic from `EuiSelectable` to Kibana side so\nwe can optimize and debounce it for Breakdown dropdown on Discover page.\nAnd looks like this component is also used somewhere in dataset quality\ndetails area.\n\nBefore (ui freeze):\n<img width=\"1203\" height=\"423\" alt=\"Screenshot 2025-07-25 at 14 24 55\"\nsrc=\"https://github.com/user-attachments/assets/682d923d-3996-4bb2-9e3b-d3daa27197f5\"\n/>\n\nAfter (debounced calculations):\n<img width=\"1196\" height=\"525\" alt=\"Screenshot 2025-07-25 at 14 34 03\"\nsrc=\"https://github.com/user-attachments/assets/70987d23-934c-4aa7-90a5-e69759e10beb\"\n/>\n\nThis fix prevents the \"freezing\" of the UI during the search. Next\npossible step would be to evaluate when to enable/disable fuzzy search.\n\n\n### Checklist\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"2ef6e9550536259ff3278c201aebec01f9bd02a0"}},{"branch":"9.0","label":"v9.0.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Jul 28, 2025
) (#229646) # Backport This will backport the following commits from `main` to `8.19`: - [[Discover] Improve performance of breakdown field search (#229335)](#229335) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2025-07-28T13:29:02Z","message":"[Discover] Improve performance of breakdown field search (#229335)\n\n- Closes https://github.com/elastic/kibana/issues/221362\n\n## Summary\n\nThis PR moves the filtering logic from `EuiSelectable` to Kibana side so\nwe can optimize and debounce it for Breakdown dropdown on Discover page.\nAnd looks like this component is also used somewhere in dataset quality\ndetails area.\n\nBefore (ui freeze):\n<img width=\"1203\" height=\"423\" alt=\"Screenshot 2025-07-25 at 14 24 55\"\nsrc=\"https://github.com/user-attachments/assets/682d923d-3996-4bb2-9e3b-d3daa27197f5\"\n/>\n\nAfter (debounced calculations):\n<img width=\"1196\" height=\"525\" alt=\"Screenshot 2025-07-25 at 14 34 03\"\nsrc=\"https://github.com/user-attachments/assets/70987d23-934c-4aa7-90a5-e69759e10beb\"\n/>\n\nThis fix prevents the \"freezing\" of the UI during the search. Next\npossible step would be to evaluate when to enable/disable fuzzy search.\n\n\n### Checklist\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"2ef6e9550536259ff3278c201aebec01f9bd02a0","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:version","v9.2.0","v9.0.5","v9.1.1","v8.18.5","v8.19.1"],"title":"[Discover] Improve performance of breakdown field search","number":229335,"url":"https://github.com/elastic/kibana/pull/229335","mergeCommit":{"message":"[Discover] Improve performance of breakdown field search (#229335)\n\n- Closes https://github.com/elastic/kibana/issues/221362\n\n## Summary\n\nThis PR moves the filtering logic from `EuiSelectable` to Kibana side so\nwe can optimize and debounce it for Breakdown dropdown on Discover page.\nAnd looks like this component is also used somewhere in dataset quality\ndetails area.\n\nBefore (ui freeze):\n<img width=\"1203\" height=\"423\" alt=\"Screenshot 2025-07-25 at 14 24 55\"\nsrc=\"https://github.com/user-attachments/assets/682d923d-3996-4bb2-9e3b-d3daa27197f5\"\n/>\n\nAfter (debounced calculations):\n<img width=\"1196\" height=\"525\" alt=\"Screenshot 2025-07-25 at 14 34 03\"\nsrc=\"https://github.com/user-attachments/assets/70987d23-934c-4aa7-90a5-e69759e10beb\"\n/>\n\nThis fix prevents the \"freezing\" of the UI during the search. Next\npossible step would be to evaluate when to enable/disable fuzzy search.\n\n\n### Checklist\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"2ef6e9550536259ff3278c201aebec01f9bd02a0"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","9.1","8.18","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/229335","number":229335,"mergeCommit":{"message":"[Discover] Improve performance of breakdown field search (#229335)\n\n- Closes https://github.com/elastic/kibana/issues/221362\n\n## Summary\n\nThis PR moves the filtering logic from `EuiSelectable` to Kibana side so\nwe can optimize and debounce it for Breakdown dropdown on Discover page.\nAnd looks like this component is also used somewhere in dataset quality\ndetails area.\n\nBefore (ui freeze):\n<img width=\"1203\" height=\"423\" alt=\"Screenshot 2025-07-25 at 14 24 55\"\nsrc=\"https://github.com/user-attachments/assets/682d923d-3996-4bb2-9e3b-d3daa27197f5\"\n/>\n\nAfter (debounced calculations):\n<img width=\"1196\" height=\"525\" alt=\"Screenshot 2025-07-25 at 14 34 03\"\nsrc=\"https://github.com/user-attachments/assets/70987d23-934c-4aa7-90a5-e69759e10beb\"\n/>\n\nThis fix prevents the \"freezing\" of the UI during the search. Next\npossible step would be to evaluate when to enable/disable fuzzy search.\n\n\n### Checklist\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"2ef6e9550536259ff3278c201aebec01f9bd02a0"}},{"branch":"9.0","label":"v9.0.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Jul 28, 2025
…) (#229647) # Backport This will backport the following commits from `main` to `9.0`: - [[Discover] Improve performance of breakdown field search (#229335)](#229335) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2025-07-28T13:29:02Z","message":"[Discover] Improve performance of breakdown field search (#229335)\n\n- Closes https://github.com/elastic/kibana/issues/221362\n\n## Summary\n\nThis PR moves the filtering logic from `EuiSelectable` to Kibana side so\nwe can optimize and debounce it for Breakdown dropdown on Discover page.\nAnd looks like this component is also used somewhere in dataset quality\ndetails area.\n\nBefore (ui freeze):\n<img width=\"1203\" height=\"423\" alt=\"Screenshot 2025-07-25 at 14 24 55\"\nsrc=\"https://github.com/user-attachments/assets/682d923d-3996-4bb2-9e3b-d3daa27197f5\"\n/>\n\nAfter (debounced calculations):\n<img width=\"1196\" height=\"525\" alt=\"Screenshot 2025-07-25 at 14 34 03\"\nsrc=\"https://github.com/user-attachments/assets/70987d23-934c-4aa7-90a5-e69759e10beb\"\n/>\n\nThis fix prevents the \"freezing\" of the UI during the search. Next\npossible step would be to evaluate when to enable/disable fuzzy search.\n\n\n### Checklist\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"2ef6e9550536259ff3278c201aebec01f9bd02a0","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:version","v9.2.0","v9.0.5","v9.1.1","v8.18.5","v8.19.1"],"title":"[Discover] Improve performance of breakdown field search","number":229335,"url":"https://github.com/elastic/kibana/pull/229335","mergeCommit":{"message":"[Discover] Improve performance of breakdown field search (#229335)\n\n- Closes https://github.com/elastic/kibana/issues/221362\n\n## Summary\n\nThis PR moves the filtering logic from `EuiSelectable` to Kibana side so\nwe can optimize and debounce it for Breakdown dropdown on Discover page.\nAnd looks like this component is also used somewhere in dataset quality\ndetails area.\n\nBefore (ui freeze):\n<img width=\"1203\" height=\"423\" alt=\"Screenshot 2025-07-25 at 14 24 55\"\nsrc=\"https://github.com/user-attachments/assets/682d923d-3996-4bb2-9e3b-d3daa27197f5\"\n/>\n\nAfter (debounced calculations):\n<img width=\"1196\" height=\"525\" alt=\"Screenshot 2025-07-25 at 14 34 03\"\nsrc=\"https://github.com/user-attachments/assets/70987d23-934c-4aa7-90a5-e69759e10beb\"\n/>\n\nThis fix prevents the \"freezing\" of the UI during the search. Next\npossible step would be to evaluate when to enable/disable fuzzy search.\n\n\n### Checklist\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"2ef6e9550536259ff3278c201aebec01f9bd02a0"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","9.1","8.18","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/229335","number":229335,"mergeCommit":{"message":"[Discover] Improve performance of breakdown field search (#229335)\n\n- Closes https://github.com/elastic/kibana/issues/221362\n\n## Summary\n\nThis PR moves the filtering logic from `EuiSelectable` to Kibana side so\nwe can optimize and debounce it for Breakdown dropdown on Discover page.\nAnd looks like this component is also used somewhere in dataset quality\ndetails area.\n\nBefore (ui freeze):\n<img width=\"1203\" height=\"423\" alt=\"Screenshot 2025-07-25 at 14 24 55\"\nsrc=\"https://github.com/user-attachments/assets/682d923d-3996-4bb2-9e3b-d3daa27197f5\"\n/>\n\nAfter (debounced calculations):\n<img width=\"1196\" height=\"525\" alt=\"Screenshot 2025-07-25 at 14 34 03\"\nsrc=\"https://github.com/user-attachments/assets/70987d23-934c-4aa7-90a5-e69759e10beb\"\n/>\n\nThis fix prevents the \"freezing\" of the UI during the search. Next\npossible step would be to evaluate when to enable/disable fuzzy search.\n\n\n### Checklist\n\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"2ef6e9550536259ff3278c201aebec01f9bd02a0"}},{"branch":"9.0","label":"v9.0.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Aug 5, 2025
) - Closes elastic#221362 ## Summary This PR moves the filtering logic from `EuiSelectable` to Kibana side so we can optimize and debounce it for Breakdown dropdown on Discover page. And looks like this component is also used somewhere in dataset quality details area. Before (ui freeze): <img width="1203" height="423" alt="Screenshot 2025-07-25 at 14 24 55" src="https://github.com/user-attachments/assets/682d923d-3996-4bb2-9e3b-d3daa27197f5" /> After (debounced calculations): <img width="1196" height="525" alt="Screenshot 2025-07-25 at 14 34 03" src="https://github.com/user-attachments/assets/70987d23-934c-4aa7-90a5-e69759e10beb" /> This fix prevents the "freezing" of the UI during the search. Next possible step would be to evaluate when to enable/disable fuzzy search. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves the filtering logic from
EuiSelectableto Kibana side so we can optimize and debounce it for Breakdown dropdown on Discover page. And looks like this component is also used somewhere in dataset quality details area.Before (ui freeze):
After (debounced calculations):
This fix prevents the "freezing" of the UI during the search. Next possible step would be to evaluate when to enable/disable fuzzy search.
Checklist
release_note:*label is applied per the guidelinesbackport:*labels.