[Search] Enabled Saved Playgrounds#229511
Conversation
| }); | ||
| }); | ||
| it('should be able to search index', async () => { | ||
| it.skip('should be able to search index', async () => { |
There was a problem hiding this comment.
Is there any reason we are going to skip this test?
There was a problem hiding this comment.
This tests the search playground, which is still feature flagged.
And testing the chat playground will require rewriting this test to mock the LLM, which is what needs to happen but just haven't done it yet.
| }); | ||
| }); | ||
| it('should be able to search index', async () => { | ||
| it.skip('should be able to search index', async () => { |
There was a problem hiding this comment.
Is there a specific reason we’re skipping this test here?
There was a problem hiding this comment.
same reason as above.
|
Are we going to remove the feature flag |
|
@saikatsarkar056 we are not going to remove |
2f2afcc to
2f2e9bd
Compare
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
|
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#8893[✅] x-pack/solutions/search/test/functional_search/config/config.search_playground.ts: 25/25 tests passed. |
## Summary Enables Saving Playgrounds including playground lists page, updating and deleting playgrounds. ### Screenshots List Page w/ updated Empty State <img width="1571" height="1156" alt="image" src="https://github.com/user-attachments/assets/271d7a67-ca63-4b8b-8dd1-e8a4b3336b04" /> Unsaved Playground - Setup View <img width="1851" height="1049" alt="image" src="https://github.com/user-attachments/assets/bb719ed1-41c4-43b5-97fb-daeeabdbdbb0" /> Saving Playground <img width="1851" height="1049" alt="image" src="https://github.com/user-attachments/assets/d1310371-f685-44a5-b758-9b5651c23a38" /> Playground w/ unsaved changes <img width="1851" height="1049" alt="image" src="https://github.com/user-attachments/assets/b6fdfc72-34d9-4696-864f-2389374396d7" /> Playground List page w/ playground <img width="1851" height="1049" alt="image" src="https://github.com/user-attachments/assets/4673e4e9-db33-4ce5-9c85-4126c31b73e4" /> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] ~If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~ - [ ] ~This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~ - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ## Release note Adds the ability to save Playgrounds within a space.
Summary
Enables Saving Playgrounds including playground lists page, updating and deleting playgrounds.
Screenshots
List Page w/ updated Empty State

Unsaved Playground - Setup View

Saving Playground

Playground w/ unsaved changes

Playground List page w/ playground

Checklist
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker listThis was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. Therelease_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Release note
Adds the ability to save Playgrounds within a space.