Skip to content

[Search] Enabled Saved Playgrounds#229511

Merged
TattdCodeMonkey merged 7 commits intoelastic:mainfrom
TattdCodeMonkey:search/enabled-saved-playgrounds
Jul 28, 2025
Merged

[Search] Enabled Saved Playgrounds#229511
TattdCodeMonkey merged 7 commits intoelastic:mainfrom
TattdCodeMonkey:search/enabled-saved-playgrounds

Conversation

@TattdCodeMonkey
Copy link
Copy Markdown
Contributor

@TattdCodeMonkey TattdCodeMonkey commented Jul 25, 2025

Summary

Enables Saving Playgrounds including playground lists page, updating and deleting playgrounds.

Screenshots

List Page w/ updated Empty State
image

Unsaved Playground - Setup View
image

Saving Playground
image

Playground w/ unsaved changes
image

Playground List page w/ playground
image

Checklist

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

Release note

Adds the ability to save Playgrounds within a space.

@TattdCodeMonkey TattdCodeMonkey added backport:skip This PR does not require backporting release_note:feature Makes this part of the condensed release notes labels Jul 25, 2025
@TattdCodeMonkey TattdCodeMonkey requested a review from a team as a code owner July 25, 2025 18:26
@TattdCodeMonkey TattdCodeMonkey requested a review from a team as a code owner July 25, 2025 18:26
});
});
it('should be able to search index', async () => {
it.skip('should be able to search index', async () => {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason we are going to skip this test?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests the search playground, which is still feature flagged.

And testing the chat playground will require rewriting this test to mock the LLM, which is what needs to happen but just haven't done it yet.

});
});
it('should be able to search index', async () => {
it.skip('should be able to search index', async () => {
Copy link
Copy Markdown
Contributor

@saikatsarkar056 saikatsarkar056 Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason we’re skipping this test here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same reason as above.

@saikatsarkar056
Copy link
Copy Markdown
Contributor

Are we going to remove the feature flag useSearchPlaygroundFeatureFlag in a separate PR?

@TattdCodeMonkey
Copy link
Copy Markdown
Contributor Author

@saikatsarkar056 we are not going to remove useSearchPlaygroundFeatureFlag yet, it's still being used to gate the search playground. When working on Saved playgrounds I re-used the same feature flag to make development easier. We're ready to ungate saved playgrounds, but not the search playground so this feature flag will continue to exist until we either release or remove search playgrounds.

@TattdCodeMonkey TattdCodeMonkey force-pushed the search/enabled-saved-playgrounds branch from 2f2afcc to 2f2e9bd Compare July 28, 2025 16:59
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
searchPlayground 395 398 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
searchPlayground 221.0KB 221.5KB +490.0B

History

@kibanamachine
Copy link
Copy Markdown
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#8893

[✅] x-pack/solutions/search/test/functional_search/config/config.search_playground.ts: 25/25 tests passed.
[✅] x-pack/test_serverless/functional/test_suites/search/config.ts: 25/25 tests passed.

see run history

@TattdCodeMonkey TattdCodeMonkey merged commit 10df1c0 into elastic:main Jul 28, 2025
12 checks passed
delanni pushed a commit to delanni/kibana that referenced this pull request Aug 5, 2025
## Summary

Enables Saving Playgrounds including playground lists page, updating and
deleting playgrounds.

### Screenshots

List Page w/ updated Empty State
<img width="1571" height="1156" alt="image"
src="https://github.com/user-attachments/assets/271d7a67-ca63-4b8b-8dd1-e8a4b3336b04"
/>

Unsaved Playground - Setup View
<img width="1851" height="1049" alt="image"
src="https://github.com/user-attachments/assets/bb719ed1-41c4-43b5-97fb-daeeabdbdbb0"
/>

Saving Playground
<img width="1851" height="1049" alt="image"
src="https://github.com/user-attachments/assets/d1310371-f685-44a5-b758-9b5651c23a38"
/>

Playground w/ unsaved changes
<img width="1851" height="1049" alt="image"
src="https://github.com/user-attachments/assets/b6fdfc72-34d9-4696-864f-2389374396d7"
/>

Playground List page w/ playground
<img width="1851" height="1049" alt="image"
src="https://github.com/user-attachments/assets/4673e4e9-db33-4ce5-9c85-4126c31b73e4"
/>

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] ~If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~
- [ ] ~This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.~
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

## Release note

Adds the ability to save Playgrounds within a space.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:feature Makes this part of the condensed release notes Team:Search v9.2.0

5 participants