[ES|QL] support expressions in STATS#229513
Merged
drewdaemon merged 62 commits intoelastic:mainfrom Aug 1, 2025
Merged
Conversation
drewdaemon
commented
Jul 30, 2025
| offset?: number | ||
| ): Promise<ISuggestionItem[]> => { | ||
| const correctedQuery = correctQuerySyntax(query); | ||
| const innerText = query.substring(0, offset ?? query.length); |
Contributor
Author
There was a problem hiding this comment.
This step that is executed in the real autocomplete routine was missed here, causing one of my tests to fail.
drewdaemon
commented
Jul 30, 2025
| } | ||
| if ( | ||
| isNotEnrichClauseAssigment(node, command) && | ||
| (!isOperator(node) || (command.name === 'stats' && !withinStatsWhereClause)) |
Contributor
Author
There was a problem hiding this comment.
This exception was designed to partially support suggestions after operators using the logic in getFunctionArgsSuggestions. Now, we are using the suggestForExpression function, so no need for this partial support anymore.
…daemon/kibana into 216492/support-expressions-in-stats
drewdaemon
added
backport:skip
drewdaemon
force-pushed
the
216492/support-expressions-in-stats
branch
from
fd45c47 to
62d9f84
Compare
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
stratoula
approved these changes
Aug 1, 2025
| * License v3.0 only", or the "Server Side Public License, v 1". | ||
| */ | ||
| import { ESQLVariableType } from '@kbn/esql-types'; | ||
| // import { getInsideFunctionsSuggestions } from '../../../definitions/utils/autocomplete/functions'; |
Contributor
There was a problem hiding this comment.
Suggested change
| // import { getInsideFunctionsSuggestions } from '../../../definitions/utils/autocomplete/functions'; |
| defaultMessage: 'WHERE operator', | ||
| }), | ||
| locationsAvailable: [Location.STATS], | ||
| ignoreAsSuggestion: true, |
Contributor
There was a problem hiding this comment.
Why don't we remove it once and for all and we add the flag instead?
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
|
szaffarano
pushed a commit
to szaffarano/kibana
that referenced
this pull request
Aug 5, 2025
## Summary Adds first-class support for expressions within both aggregation and grouping clauses in `STATS`. https://github.com/user-attachments/assets/a435410f-9176-47d5-9ca2-412a2438e197 Part of elastic#216492 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Reinstate controls suggestions - [x] Behavior after single field in grouping clauses - [x] Reenable function arg suggestions - [x] Ignore previously-used columns in grouping clauses - [x] Verify suggestions after complete WHERE - [x] Verify nested grouping functions - [x] Write tests --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Aug 5, 2025
## Summary Adds first-class support for expressions within both aggregation and grouping clauses in `STATS`. https://github.com/user-attachments/assets/a435410f-9176-47d5-9ca2-412a2438e197 Part of elastic#216492 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Reinstate controls suggestions - [x] Behavior after single field in grouping clauses - [x] Reenable function arg suggestions - [x] Ignore previously-used columns in grouping clauses - [x] Verify suggestions after complete WHERE - [x] Verify nested grouping functions - [x] Write tests --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
## Summary Adds first-class support for expressions within both aggregation and grouping clauses in `STATS`. https://github.com/user-attachments/assets/a435410f-9176-47d5-9ca2-412a2438e197 Part of elastic#216492 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Reinstate controls suggestions - [x] Behavior after single field in grouping clauses - [x] Reenable function arg suggestions - [x] Ignore previously-used columns in grouping clauses - [x] Verify suggestions after complete WHERE - [x] Verify nested grouping functions - [x] Write tests --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds first-class support for expressions within both aggregation and grouping clauses in
STATS.expressions_in_stats.mov
Part of #216492
Checklist