[ES|QL][Discover] Supports controls by stratoula · Pull Request #229598 · elastic/kibana

stratoula · 2025-07-28T10:17:45Z

Summary

Enables controls in Discover from the editor.

The users can save the charts with variables in a dashboard but the controls are not been transferred. We will deal with it on a follow up PR. The same behavior is on dashboards too so there is a consistency there 😄.

Flaky tests runner
#229598 (comment)

Note: The Expand width to fit available space is not working but I will hide it for Discover only in a follow up PR

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Flaky Test Runner was used on any tests changed

… src/core/server/integration_tests/ci_checks'

davismcphee

With the latest SO changes, this LGTM on the Data Discovery side 👍 Great work!

Although funnily enough, the test you commented out in 48bf66d was for the stateful version, and not the serverless one that was previously failing, but it still passed CI 😅 I guess that confirms it is still related to flakiness in main. Feel free to comment the serverless one out too before your next merge in case it fails again. And apologies for the flakiness, we'll get it resolved soon.

lukasolson

LGTM!

stratoula · 2025-09-18T05:40:32Z

@davismcphee done! (Very funny and weird indeed 😄 )

stratoula · 2025-09-18T07:35:08Z

@davismcphee and now it fails 😄

I am sorry I had to revert 🤷‍♀️

And now it fails again 🤦‍♀️

gsoldevila

Core changes LGTM! new model version added in 'search' SO.

vadimkibana

ESQL changes LGTM.

Heenawter

@elastic/kibana-presentation code changes LGTM. Noticed three potential bugs, though.

src/platform/plugins/shared/unified_search/public/query_string_input/query_bar_top_row.tsx

delanni

limits.yml 👍

elasticmachine · 2025-09-19T09:49:25Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: b0cef5a

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #27 / Serverless Observability - Deployment-agnostic API integration tests SLO Find SLOs using kql query searches SLOs using kqlQuery

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`discover`	1559	1563	+4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/unified-histogram`	94	95	+1
`savedSearch`	101	102	+1
total			+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`controls`	486.6KB	486.6KB	+30.0B
`discover`	1.1MB	1.2MB	+3.6KB
`esql`	521.3KB	521.6KB	+293.0B
`lens`	1.5MB	1.5MB	+21.0B
`savedSearch`	6.8KB	6.9KB	+83.0B
`unifiedSearch`	353.3KB	353.9KB	+563.0B
total			+4.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`discover`	23.3KB	23.4KB	+137.0B
`lens`	61.0KB	61.1KB	+38.0B
`savedSearch`	10.0KB	10.0KB	+74.0B
`unifiedSearch`	22.4KB	22.5KB	+42.0B
total			+291.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/unified-histogram`	121	122	+1
`savedSearch`	104	105	+1
total			+2

ESLint disabled line counts

id	before	after	diff
`discover`	16	17	+1

Total ESLint disabled count

id	before	after	diff
`discover`	18	19	+1

History

💔 Build #341202 failed b17cb32
💛 Build #340790 was flaky f5617f1
💔 Build #340656 failed 8afc431
💔 Build #340614 failed dd7490c
💛 Build #340147 was flaky 4fd2ec4
💔 Build #339919 failed 49fd0b5

## Summary Part of elastic#225948 Enables controls in Discover from the editor. <img width="1252" height="122" alt="image" src="https://github.com/user-attachments/assets/76792f2e-abd0-406b-8a9f-84c53a06dfc4" /> The users can save the charts with variables in a dashboard but the controls are not been transferred. We will deal with it on a follow up PR. The same behavior is on dashboards too so there is a consistency there 😄. Flaky tests runner elastic#229598 (comment) Note: The Expand width to fit available space is not working but I will hide it for Discover only in a follow up PR ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Hannah Mudge <hannah.wright@elastic.co> Co-authored-by: Davis McPhee <davis.mcphee@elastic.co> Co-authored-by: Lukas Olson <lukas@elastic.co>

## Summary Part of #225948 Enables controls in Discover from the editor. <img width="1252" height="122" alt="image" src="https://github.com/user-attachments/assets/76792f2e-abd0-406b-8a9f-84c53a06dfc4" /> The users can save the charts with variables in a dashboard but the controls are not been transferred. We will deal with it on a follow up PR. The same behavior is on dashboards too so there is a consistency there 😄. Flaky tests runner #229598 (comment) Note: The Expand width to fit available space is not working but I will hide it for Discover only in a follow up PR ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Hannah Mudge <hannah.wright@elastic.co> Co-authored-by: Davis McPhee <davis.mcphee@elastic.co> Co-authored-by: Lukas Olson <lukas@elastic.co>

## Summary Part of elastic#225948 Enables controls in Discover from the editor. <img width="1252" height="122" alt="image" src="https://github.com/user-attachments/assets/76792f2e-abd0-406b-8a9f-84c53a06dfc4" /> The users can save the charts with variables in a dashboard but the controls are not been transferred. We will deal with it on a follow up PR. The same behavior is on dashboards too so there is a consistency there 😄. Flaky tests runner elastic#229598 (comment) Note: The Expand width to fit available space is not working but I will hide it for Discover only in a follow up PR ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Hannah Mudge <hannah.wright@elastic.co> Co-authored-by: Davis McPhee <davis.mcphee@elastic.co> Co-authored-by: Lukas Olson <lukas@elastic.co>

[ES|QL][Discover] Supports controls

2673ea2

stratoula mentioned this pull request Jul 28, 2025

[ES|QL] Supports controls in Discover #212544

Closed

7 tasks

kibanamachine and others added 27 commits July 28, 2025 10:31

[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'

735628b

Fix type check ci

327e083

Merge branch 'main' into controls-in-discover

baffc80

Fix FT

debc0f0

On refresh create controls, move variables to internal state

88be0b2

Cleanup

149d5ca

Simplification

d098d8c

Merge branch 'main' into controls-in-discover

bf2d654

Merge branch 'main' into controls-in-discover

66c8fa9

Implementation with storage

705f25a

Save in session storage

48a03a5

Small performance improvement

6fd2e87

Small cleanup

e5cff28

Merge branch 'main' into controls-in-discover

c243eb5

Make it work for tabs disabled

d3691f3

WIP - save controls state in the SO

afc6efe

Store in local storage

f7cbdae

Cleanuo

a0cea02

Unsaved badge implementation

ef5d8bb

Merge branch 'main' into controls-in-discover

7deceb1

Some bug fixes

a045dc2

Update state after control removal

1af165d

Set and reset correctly

2111569

Adds unit tests

f287536

[CI] Auto-commit changed files from 'node scripts/jest_integration -u…

de3be4e

… src/core/server/integration_tests/ci_checks'

Fixes unit tests

9b4400e

Add FTs

e81d0a4

stratoula added the Feature:ES|QL ES|QL related features in Kibana label Aug 5, 2025

Merge with main and resolve conflicts

13e23c3

kertal mentioned this pull request Sep 17, 2025

[Discover][ESQL] Fix esql request count failures #235300

Closed

[CI] Auto-commit changed files from 'node scripts/jest_integration -u…

4fd2ec4

… src/core/server/integration_tests/ci_checks'

davismcphee approved these changes Sep 17, 2025

View reviewed changes

kertal requested a review from lukasolson September 17, 2025 17:18

lukasolson approved these changes Sep 17, 2025

View reviewed changes

Merge with main and resolve conflicts

8afc431

stratoula force-pushed the controls-in-discover branch from dd7490c to 8afc431 Compare September 18, 2025 07:45

stratoula mentioned this pull request Sep 18, 2025

[ES|QL][Discover] Transfer controls from Discover to Dashboards #235477

Closed

2 tasks

gsoldevila approved these changes Sep 18, 2025

View reviewed changes

vadimkibana approved these changes Sep 18, 2025

View reviewed changes

stratoula added 2 commits September 18, 2025 12:26

Merge branch 'main' into controls-in-discover

41c51da

Comment our for serverless too

f5617f1

Heenawter reviewed Sep 18, 2025

View reviewed changes

Heenawter approved these changes Sep 18, 2025

View reviewed changes

stratoula added 2 commits September 19, 2025 08:36

Merge with main and resolve conflicts

b17cb32

Small enhancements

b0cef5a

stratoula requested a review from a team as a code owner September 19, 2025 07:21

delanni approved these changes Sep 19, 2025

View reviewed changes

markov00 approved these changes Sep 19, 2025

View reviewed changes

stratoula merged commit f82a862 into elastic:main Sep 19, 2025
12 checks passed

florent-leborgne mentioned this pull request Sep 22, 2025

[Kibana ES|QL][Discover] Controls in Discover elastic/docs-content#3096

Closed

florent-leborgne added the needs_docs label Sep 22, 2025

davismcphee mentioned this pull request Nov 19, 2025

[Discover] Add Controls in Discover #220270

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ES|QL][Discover] Supports controls#229598

[ES|QL][Discover] Supports controls#229598
stratoula merged 106 commits intoelastic:mainfrom
stratoula:controls-in-discover

stratoula commented Jul 28, 2025 •

edited

Loading

davismcphee left a comment

lukasolson left a comment

stratoula commented Sep 18, 2025

stratoula commented Sep 18, 2025 •

edited

Loading

gsoldevila left a comment

vadimkibana left a comment

Heenawter left a comment

Uh oh!

Uh oh!

Uh oh!

delanni left a comment

elasticmachine commented Sep 19, 2025

API count

ESLint disabled line counts

Total ESLint disabled count

Uh oh!

Labels

11 participants

Conversation

stratoula commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

davismcphee left a comment

Choose a reason for hiding this comment

lukasolson left a comment

Choose a reason for hiding this comment

stratoula commented Sep 18, 2025

stratoula commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

gsoldevila left a comment

Choose a reason for hiding this comment

vadimkibana left a comment

Choose a reason for hiding this comment

Heenawter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

delanni left a comment

Choose a reason for hiding this comment

elasticmachine commented Sep 19, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

Labels

11 participants

stratoula commented Jul 28, 2025 •

edited

Loading

stratoula commented Sep 18, 2025 •

edited

Loading