Skip to content

Stack Management Data Views - Fix overlapping action icons on mobile #229771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MiloszRadzynski merged 9 commits into from
Aug 4, 2025
Merged

Stack Management Data Views - Fix overlapping action icons on mobile #229771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
32eeab6
Stack Management Data Views - Fix overlapping actions icon on mobile
MiloszRadzynski Jul 29, 2025
38bd16b
Remove redundant action column and merge edit and delete action into …
MiloszRadzynski Jul 30, 2025
7a174ad
Revert unnecessary changes
MiloszRadzynski Jul 30, 2025
726166f
Adjust functional tests
MiloszRadzynski Jul 30, 2025
f7d0ffb
Change color of the delete action to red
MiloszRadzynski Jul 31, 2025
ccc64ec
Update table snapshot after changing color of delete action
MiloszRadzynski Jul 31, 2025
739d424
Add translation for 'actions' column name
MiloszRadzynski Jul 31, 2025
b248d32
Merge branch 'main' into stack-management-mobile-fix-overlapped-icons…
MiloszRadzynski Jul 31, 2025
e7791ca
Merge branch 'main' into stack-management-mobile-fix-overlapped-icons…
MiloszRadzynski Aug 4, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions ...dit_index_pattern/indexed_fields_table/components/table/__snapshots__/table.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...public/components/edit_index_pattern/indexed_fields_table/components/table/table.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ describe('Table', () => {

test('should not allow edit or deletion for user with only read access', () => {
const editAvailable = renderTable().prop('columns')[6].actions[0].available(items[4]);
const deleteAvailable = renderTable().prop('columns')[7].actions[0].available(items[4]);
const deleteAvailable = renderTable().prop('columns')[6].actions[1].available(items[4]);
expect(editAvailable).toBeFalsy();
expect(deleteAvailable).toBeFalsy();
});
Expand Down
18 changes: 10 additions & 8 deletions ...ment/public/components/edit_index_pattern/indexed_fields_table/components/table/table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,13 @@ const isExcludedAriaLabel = i18n.translate(
}
);

const actionsLabel = i18n.translate(
'indexPatternManagement.editIndexPattern.fields.table.actionsLabel',
{
defaultMessage: 'Actions',
}
);

const editLabel = i18n.translate('indexPatternManagement.editIndexPattern.fields.table.editLabel', {
defaultMessage: 'Edit',
});
Expand Down Expand Up @@ -477,7 +484,7 @@ class TableClass extends PureComponent<
render: (value: string) => this.renderBooleanTemplate(value, isExcludedAriaLabel),
},
{
name: '',
name: actionsLabel,
actions: [
{
name: editLabel,
Expand All @@ -488,16 +495,11 @@ class TableClass extends PureComponent<
'data-test-subj': 'editFieldFormat',
available: (field) => field.isUserEditable,
},
],
width: '40px',
},
{
name: '',
actions: [
{
name: deleteLabel,
description: deleteDescription,
icon: 'trash',
color: 'danger',
onClick: (field) => {
const toDelete = [field.name];
if (field.spec?.runtimeField?.fields) {
Expand All @@ -513,7 +515,7 @@ class TableClass extends PureComponent<
available: showDelete,
},
],
width: '40px',
width: '80px',
},
];

Expand Down
1 change: 1 addition & 0 deletions src/platform/test/functional/apps/management/data_views/_data_view_create_delete.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
'Searchable',
'Aggregatable',
'Excluded',
'Actions',
];

expect(headers.length).to.be(expectedHeaders.length);
Expand Down
2 changes: 1 addition & 1 deletion src/platform/test/functional/page_objects/settings_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ export class SettingsPageObject extends FtrService {

await this.find.clickByCssSelector(
`table.euiTable tbody tr.euiTableRow:nth-child(${tableFields.indexOf(name) + 1})
td:nth-last-child(2) button`
td:last-child button`
);
await this.retry.waitFor('flyout to open', async () => {
return await this.testSubjects.exists('flyoutTitle');
Expand Down
1 change: 1 addition & 0 deletions x-pack/platform/test/stack_functional_integration/apps/management/_index_pattern_create.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export default ({ getService, getPageObjects }) => {
'Searchable',
'Aggregatable',
'Excluded',
'Actions',
];

expect(headers.length).to.be(expectedHeaders.length);
Expand Down
1 change: 1 addition & 0 deletions ...erverless/functional/test_suites/common/management/data_views/_data_view_create_delete.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
'Searchable',
'Aggregatable',
'Excluded',
'Actions',
];

expect(headers.length).to.be(expectedHeaders.length);
Expand Down