[8.17] [SharedUX] Fix toast counter badge stack order (#229300)#229782
Merged
angeles-mb merged 1 commit intoelastic:8.17from Jul 29, 2025
Merged
[8.17] [SharedUX] Fix toast counter badge stack order (#229300)#229782angeles-mb merged 1 commit intoelastic:8.17from
angeles-mb merged 1 commit intoelastic:8.17from
Conversation
Closes elastic#226225 ## Summary - Fixed the toast counter badge which was positioned behind the toast (toast stack context sets [z-index: 9000](https://github.com/elastic/eui/blob/aa115fbc28a3fc107ebabbb75f6fdae75d32c976/packages/eui-theme-common/src/global_styling/variables/levels.ts#L42-L43)) - Original toast counter PR: elastic#161738 - As discussed on that PR, a more robust approach would include this counter in the EUI component itself but it seems that it was discarded here: elastic/eui#6945 after Kibana's usecase being covered by this simpler approach ## Visuals ### Before/After Success <img width="345" height="77" alt="Screenshot 2025-07-24 at 11 27 06" src="https://github.com/user-attachments/assets/47ac83d4-7c4b-4b12-ba34-a1c124fe8780" /> <img width="349" height="78" alt="Screenshot 2025-07-24 at 11 27 54" src="https://github.com/user-attachments/assets/dac9ddf0-c7b2-47a5-971e-d83c67ed54b8" /> ### Before/After Info Flavour <img width="346" height="78" alt="Screenshot 2025-07-24 at 11 36 50" src="https://github.com/user-attachments/assets/72fe86a3-9a76-4517-8d69-4ef544d6ec4b" /> <img width="346" height="77" alt="Screenshot 2025-07-24 at 11 37 20" src="https://github.com/user-attachments/assets/62c8365d-602e-4164-8e69-5afcf1ab9e09" /> ### Before/After Success Mobile <img width="398" height="135" alt="Screenshot 2025-07-24 at 11 29 39" src="https://github.com/user-attachments/assets/7005eefd-6ed3-4a70-8bff-ac02da7b542f" /> <img width="395" height="132" alt="Screenshot 2025-07-24 at 11 28 35" src="https://github.com/user-attachments/assets/567111ce-c798-48e9-be67-ebff31553ac3" /> (cherry picked from commit 9699426) # Conflicts: # packages/core/notifications/core-notifications-browser-internal/src/toasts/__snapshots__/deduplicate_toasts.test.tsx.snap # x-pack/platform/plugins/private/canvas/public/components/export_app/__snapshots__/export_app.test.tsx.snap
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Page load bundle
cc @angeles-mb |
kowalczyk-krzysztof
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.17:Questions ?
Please refer to the Backport tool documentation