[Obs AI Assistant] Remove assistant settings page for basic licenses#230036
Closed
eleonoramicozzi wants to merge 9 commits intoelastic:mainfrom
Closed
[Obs AI Assistant] Remove assistant settings page for basic licenses#230036eleonoramicozzi wants to merge 9 commits intoelastic:mainfrom
eleonoramicozzi wants to merge 9 commits intoelastic:mainfrom
Conversation
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
added 2 commits
July 31, 2025 16:47
… remove_assistant_settings_for_basic_license
7111d76 to
e7ba812
Compare
… remove_assistant_settings_for_basic_license
…/github.com/eleonoramicozzi/kibana into remove_assistant_settings_for_basic_license
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
|
neptunian
reviewed
Aug 6, 2025
| const isObservabilityAIAssistantEnabled = | ||
| observabilityAIAssistantCapabilityEnabled && | ||
| observabilityAIAssistantEnabled && | ||
| aiAssistantManagementSelection; |
Contributor
There was a problem hiding this comment.
Do we need this check for aiAssistantManagementSelection if the app is already disabled? They can't get to this page anyway?
2 tasks
rbrtj
added a commit
that referenced
this pull request
Aug 12, 2025
Resolves: #224922 This PR: * Introduces a new `AI` section in Stack Management * Moves all AI Assistant management pages out of the `Kibana` section into the new `AI` setion. * Introduces the `genAISettings` plugin with a `GenAI Settings` page under the new `AI` section to manage generic configurations like connectors and feature visibility. * ~~AI Assistants settings now depend on the `aiAssistantManagementSelection` setting instead of the availability of individual assistants.~~ * ~~Enabled read mode for Security and Observability/Search assistant settings based on the setting above ^~~ It appears that the Assistant settings cannot directly rely on the `AI Assistant Settings` privilege. There are still ongoing discussions about whether we should remove the `AI Assistant Settings` privilege or take a different approach. With that in mind, I reverted some changes in this PR to just create a new section and move `AI Assistants` under it, along with adding the new `GenAI Settings` page. I left the existing privileges checks as they are, they will be updated once the discussions are resolved. <img width="1477" height="954" alt="image" src="https://github.com/user-attachments/assets/8b50bcbc-28df-42fa-82c5-5a8c262b2c9f" /> ### `AI Assistants` scenarios with different privileges: 1. `Management > AI Assistant Settings` - All/Read `Security Assistant` and `Observability Assistant` - All <img width="1717" height="1363" alt="image" src="https://github.com/user-attachments/assets/dcea9c33-4f2d-4ea4-818e-ba6ffaf1a812" /> 2. `Management > AI Assistant Settings` - All/Read, `Security Assistant` and `Observability Assistant` - none <img width="1716" height="1357" alt="image" src="https://github.com/user-attachments/assets/6b26e954-e201-475b-bee9-4a7ca20bd120" /> 3. `Management > AI Assistant Settings` - None <img width="1719" height="1313" alt="image" src="https://github.com/user-attachments/assets/9c38ecc1-693b-4c3b-8c09-f227ba539202" /> 4. No `Enterprise` license. Currently buggy, will be fixed by #230036 <img width="1718" height="1356" alt="image" src="https://github.com/user-attachments/assets/39e07e33-baa3-4eaf-8fa4-c31895605517" /> TBD: - [ ] Manage Connectors should apply filters, however, the connectors page does not currently save filters in the URL state. - [ ] In solution views, take the user directly to the individual Assistant settings - I've decided to hold off on this until the ongoing privilege discussions are resolved, as the implementation may vary depending on the outcome. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
Resolves: elastic#224922 This PR: * Introduces a new `AI` section in Stack Management * Moves all AI Assistant management pages out of the `Kibana` section into the new `AI` setion. * Introduces the `genAISettings` plugin with a `GenAI Settings` page under the new `AI` section to manage generic configurations like connectors and feature visibility. * ~~AI Assistants settings now depend on the `aiAssistantManagementSelection` setting instead of the availability of individual assistants.~~ * ~~Enabled read mode for Security and Observability/Search assistant settings based on the setting above ^~~ It appears that the Assistant settings cannot directly rely on the `AI Assistant Settings` privilege. There are still ongoing discussions about whether we should remove the `AI Assistant Settings` privilege or take a different approach. With that in mind, I reverted some changes in this PR to just create a new section and move `AI Assistants` under it, along with adding the new `GenAI Settings` page. I left the existing privileges checks as they are, they will be updated once the discussions are resolved. <img width="1477" height="954" alt="image" src="https://github.com/user-attachments/assets/8b50bcbc-28df-42fa-82c5-5a8c262b2c9f" /> ### `AI Assistants` scenarios with different privileges: 1. `Management > AI Assistant Settings` - All/Read `Security Assistant` and `Observability Assistant` - All <img width="1717" height="1363" alt="image" src="https://github.com/user-attachments/assets/dcea9c33-4f2d-4ea4-818e-ba6ffaf1a812" /> 2. `Management > AI Assistant Settings` - All/Read, `Security Assistant` and `Observability Assistant` - none <img width="1716" height="1357" alt="image" src="https://github.com/user-attachments/assets/6b26e954-e201-475b-bee9-4a7ca20bd120" /> 3. `Management > AI Assistant Settings` - None <img width="1719" height="1313" alt="image" src="https://github.com/user-attachments/assets/9c38ecc1-693b-4c3b-8c09-f227ba539202" /> 4. No `Enterprise` license. Currently buggy, will be fixed by elastic#230036 <img width="1718" height="1356" alt="image" src="https://github.com/user-attachments/assets/39e07e33-baa3-4eaf-8fa4-c31895605517" /> TBD: - [ ] Manage Connectors should apply filters, however, the connectors page does not currently save filters in the URL state. - [ ] In solution views, take the user directly to the individual Assistant settings - I've decided to hold off on this until the ongoing privilege discussions are resolved, as the implementation may vary depending on the outcome. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Aug 26, 2025
Resolves: elastic#224922 This PR: * Introduces a new `AI` section in Stack Management * Moves all AI Assistant management pages out of the `Kibana` section into the new `AI` setion. * Introduces the `genAISettings` plugin with a `GenAI Settings` page under the new `AI` section to manage generic configurations like connectors and feature visibility. * ~~AI Assistants settings now depend on the `aiAssistantManagementSelection` setting instead of the availability of individual assistants.~~ * ~~Enabled read mode for Security and Observability/Search assistant settings based on the setting above ^~~ It appears that the Assistant settings cannot directly rely on the `AI Assistant Settings` privilege. There are still ongoing discussions about whether we should remove the `AI Assistant Settings` privilege or take a different approach. With that in mind, I reverted some changes in this PR to just create a new section and move `AI Assistants` under it, along with adding the new `GenAI Settings` page. I left the existing privileges checks as they are, they will be updated once the discussions are resolved. <img width="1477" height="954" alt="image" src="https://github.com/user-attachments/assets/8b50bcbc-28df-42fa-82c5-5a8c262b2c9f" /> ### `AI Assistants` scenarios with different privileges: 1. `Management > AI Assistant Settings` - All/Read `Security Assistant` and `Observability Assistant` - All <img width="1717" height="1363" alt="image" src="https://github.com/user-attachments/assets/dcea9c33-4f2d-4ea4-818e-ba6ffaf1a812" /> 2. `Management > AI Assistant Settings` - All/Read, `Security Assistant` and `Observability Assistant` - none <img width="1716" height="1357" alt="image" src="https://github.com/user-attachments/assets/6b26e954-e201-475b-bee9-4a7ca20bd120" /> 3. `Management > AI Assistant Settings` - None <img width="1719" height="1313" alt="image" src="https://github.com/user-attachments/assets/9c38ecc1-693b-4c3b-8c09-f227ba539202" /> 4. No `Enterprise` license. Currently buggy, will be fixed by elastic#230036 <img width="1718" height="1356" alt="image" src="https://github.com/user-attachments/assets/39e07e33-baa3-4eaf-8fa4-c31895605517" /> TBD: - [ ] Manage Connectors should apply filters, however, the connectors page does not currently save filters in the URL state. - [ ] In solution views, take the user directly to the individual Assistant settings - I've decided to hold off on this until the ongoing privilege discussions are resolved, as the implementation may vary depending on the outcome. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Contributor
Author
|
This was addressed in #231989 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #229347
AI Assistants are only available for users with enterprise or trial license. Right now, if a user has a basic license, they can still navigate to the AI Assistant settings page. This PR removes the "AI Assistants" menu item for licenses < enterprise, preventing the user from seeing a disabled page.
Note
The decision to remove the menu item completely, instead of disabling the observability Assistant tile, was made together with @isaclfreire , see https://elastic.slack.com/archives/C0932G71NDA/p1753867908124919?thread_ts=1753810253.575439&cid=C0932G71NDA
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*label is applied per the guidelinesbackport:*labels.Testing
Enterprise license, AI settings page is available
Basic license, AI settings page is not available (directly navigating to the url is also blocked)