Skip to content

Revert "[Discover][UnifiedDataTable] Left align content inside the rendered cell value"#230095

Merged
jughosta merged 1 commit intomainfrom
revert-226562-210234-fix-json-in-number-column
Jul 31, 2025
Merged

Revert "[Discover][UnifiedDataTable] Left align content inside the rendered cell value"#230095
jughosta merged 1 commit intomainfrom
revert-226562-210234-fix-json-in-number-column

Conversation

@jughosta
Copy link
Contributor

@jughosta jughosta commented Jul 31, 2025 •
edited by kibanamachine
Loading

Reverts #226562 due to issues with #229178 (comment)

Closes #229178

Before:
Screenshot 2025-07-31 at 17 49 27

After:
Screenshot 2025-07-31 at 17 49 56
@jughosta jughosta self-assigned this Jul 31, 2025
@jughosta jughosta added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// backport:version Backport to applied version labels v9.2.0 v9.1.1 labels Jul 31, 2025
@jughosta jughosta marked this pull request as ready for review July 31, 2025 16:02
@jughosta jughosta requested a review from a team as a code owner July 31, 2025 16:02
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 31, 2025

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)
@jughosta jughosta enabled auto-merge (squash) July 31, 2025 16:05
l-suarez
l-suarez approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@l-suarez l-suarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you Julia!
@jughosta jughosta mentioned this pull request Jul 31, 2025
Open
@jughosta jughosta merged commit 217ea79 into main Jul 31, 2025
24 checks passed
@jughosta jughosta deleted the revert-226562-210234-fix-json-in-number-column branch July 31, 2025 17:27
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 31, 2025

Starting backport for target branches: 9.1

https://github.com/elastic/kibana/actions/runs/16655769314
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 31, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #19 / Fleet packages test Automatic agent upgrades "after all" hook for "should take agents marked and ready for retry into account and upgrade them"
  • [job] [logs] FTR Configs #19 / Fleet packages test Automatic agent upgrades should take agents marked and ready for retry into account and upgrade them

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 557.2KB 557.2KB -74.0B
discover 1.1MB 1.1MB -74.0B
esqlDataGrid 158.8KB 158.7KB -74.0B
securitySolution 9.8MB 9.8MB -74.0B
slo 979.6KB 979.5KB -74.0B
total -370.0B

cc @jughosta
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 31, 2025
@jughosta
Revert "[Discover][UnifiedDataTable] Left align content inside the re…
0915f90 
…ndered cell value" (elastic#230095)

Reverts elastic#226562 due to issues with
elastic#229178 (comment)

Closes elastic#229178

Before:
<img width="1048" height="365" alt="Screenshot 2025-07-31 at 17 49 27"
src="https://github.com/user-attachments/assets/5417df3f-674d-4a48-b9e9-69594e1ddb2b"
/>

After:
<img width="1054" height="392" alt="Screenshot 2025-07-31 at 17 49 56"
src="https://github.com/user-attachments/assets/59d116d9-ee6f-4580-a64c-593ac80271d1"
/>

(cherry picked from commit 217ea79)
@kibanamachine kibanamachine mentioned this pull request Jul 31, 2025
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 31, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation
kibanamachine added a commit that referenced this pull request Jul 31, 2025
@kibanamachine @jughosta
[9.1] Revert "[Discover][UnifiedDataTable] Left align content inside …
0c0259d 
…the rendered cell value" (#230095) (#230112)

# Backport

This will backport the following commits from `main` to `9.1`:
- [Revert "[Discover][UnifiedDataTable] Left align content inside the
rendered cell value"
(#230095)](#230095)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2025-07-31T17:27:40Z","message":"Revert
\"[Discover][UnifiedDataTable] Left align content inside the rendered
cell value\" (#230095)\n\nReverts #226562 due to issues
with\nhttps://github.com//issues/229178#issuecomment-3140377497\n\nCloses
https://github.com/elastic/kibana/issues/229178\n\nBefore:\n<img
width=\"1048\" height=\"365\" alt=\"Screenshot 2025-07-31 at 17 49
27\"\nsrc=\"https://github.com/user-attachments/assets/5417df3f-674d-4a48-b9e9-69594e1ddb2b\"\n/>\n\nAfter:\n<img
width=\"1054\" height=\"392\" alt=\"Screenshot 2025-07-31 at 17 49
56\"\nsrc=\"https://github.com/user-attachments/assets/59d116d9-ee6f-4580-a64c-593ac80271d1\"\n/>","sha":"217ea79431f5568ec1724c0dc82011f84c27bc42","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","backport:version","v9.2.0","v9.1.1"],"title":"Revert
\"[Discover][UnifiedDataTable] Left align content inside the rendered
cell
value\"","number":230095,"url":"https://github.com/elastic/kibana/pull/230095","mergeCommit":{"message":"Revert
\"[Discover][UnifiedDataTable] Left align content inside the rendered
cell value\" (#230095)\n\nReverts #226562 due to issues
with\nhttps://github.com//issues/229178#issuecomment-3140377497\n\nCloses
https://github.com/elastic/kibana/issues/229178\n\nBefore:\n<img
width=\"1048\" height=\"365\" alt=\"Screenshot 2025-07-31 at 17 49
27\"\nsrc=\"https://github.com/user-attachments/assets/5417df3f-674d-4a48-b9e9-69594e1ddb2b\"\n/>\n\nAfter:\n<img
width=\"1054\" height=\"392\" alt=\"Screenshot 2025-07-31 at 17 49
56\"\nsrc=\"https://github.com/user-attachments/assets/59d116d9-ee6f-4580-a64c-593ac80271d1\"\n/>","sha":"217ea79431f5568ec1724c0dc82011f84c27bc42"}},"sourceBranch":"main","suggestedTargetBranches":["9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230095","number":230095,"mergeCommit":{"message":"Revert
\"[Discover][UnifiedDataTable] Left align content inside the rendered
cell value\" (#230095)\n\nReverts #226562 due to issues
with\nhttps://github.com//issues/229178#issuecomment-3140377497\n\nCloses
https://github.com/elastic/kibana/issues/229178\n\nBefore:\n<img
width=\"1048\" height=\"365\" alt=\"Screenshot 2025-07-31 at 17 49
27\"\nsrc=\"https://github.com/user-attachments/assets/5417df3f-674d-4a48-b9e9-69594e1ddb2b\"\n/>\n\nAfter:\n<img
width=\"1054\" height=\"392\" alt=\"Screenshot 2025-07-31 at 17 49
56\"\nsrc=\"https://github.com/user-attachments/assets/59d116d9-ee6f-4580-a64c-593ac80271d1\"\n/>","sha":"217ea79431f5568ec1724c0dc82011f84c27bc42"}},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
delanni pushed a commit to delanni/kibana that referenced this pull request Aug 5, 2025
@jughosta @delanni
Revert "[Discover][UnifiedDataTable] Left align content inside the re…
dad3291 
…ndered cell value" (elastic#230095)

Reverts elastic#226562 due to issues with
elastic#229178 (comment)

Closes elastic#229178

Before:
<img width="1048" height="365" alt="Screenshot 2025-07-31 at 17 49 27"
src="https://github.com/user-attachments/assets/5417df3f-674d-4a48-b9e9-69594e1ddb2b"
/>

After:
<img width="1054" height="392" alt="Screenshot 2025-07-31 at 17 49 56"
src="https://github.com/user-attachments/assets/59d116d9-ee6f-4580-a64c-593ac80271d1"
/>
@wildemat wildemat mentioned this pull request Aug 7, 2025
Closed
10 tasks
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Aug 18, 2025
@jughosta @NicholasPeretti
Revert "[Discover][UnifiedDataTable] Left align content inside the re…
87ea3fe 
…ndered cell value" (elastic#230095)

Reverts elastic#226562 due to issues with
elastic#229178 (comment)

Closes elastic#229178

Before:
<img width="1048" height="365" alt="Screenshot 2025-07-31 at 17 49 27"
src="https://github.com/user-attachments/assets/5417df3f-674d-4a48-b9e9-69594e1ddb2b"
/>

After:
<img width="1054" height="392" alt="Screenshot 2025-07-31 at 17 49 56"
src="https://github.com/user-attachments/assets/59d116d9-ee6f-4580-a64c-593ac80271d1"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v9.1.1 v9.2.0

4 participants

@jughosta @elasticmachine @kibanamachine @l-suarez