Skip to content

[Search] Fix null property being read on Playground#230729

Merged
sphilipse merged 1 commit intoelastic:mainfrom
sphilipse:search-fix-null-property-read-playground
Aug 7, 2025
Merged

[Search] Fix null property being read on Playground#230729
sphilipse merged 1 commit intoelastic:mainfrom
sphilipse:search-fix-null-property-read-playground

Conversation

@sphilipse
Copy link
Member

@sphilipse sphilipse commented Aug 6, 2025 •
edited by kibanamachine
Loading

Summary

This prevents Playground from throwing a useless null error when being provided with an empty search hit.
@sphilipse sphilipse requested a review from a team as a code owner August 6, 2025 09:00
@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 6, 2025

💚 Build Succeeded

Metrics [docs]

✅ unchanged
@sphilipse sphilipse added release_note:fix backport:all-open Backport to all branches that could still receive a release labels Aug 6, 2025
Samiul-TheSoccerFan
Samiul-TheSoccerFan approved these changes Aug 6, 2025
View reviewed changes
Copy link
Contributor

@Samiul-TheSoccerFan Samiul-TheSoccerFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@sphilipse sphilipse merged commit 4573268 into elastic:main Aug 7, 2025
19 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 7, 2025

Starting backport for target branches: 8.17, 8.18, 8.19, 9.0, 9.1

https://github.com/elastic/kibana/actions/runs/16800025835
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 7, 2025
@sphilipse
[Search] Fix null property being read on Playground (elastic#230729)
e3b72a1 
## Summary

This prevents Playground from throwing a useless null error when being
provided with an empty search hit.

(cherry picked from commit 4573268)
@kibanamachine kibanamachine mentioned this pull request Aug 7, 2025
Open
@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 7, 2025

💔 Some backports could not be created

Status Branch Result
❌ 8.17 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.17:
- Remove unused deps (#230630)
❌ 8.18 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.18:
- Remove unused deps (#230630)
❌ 8.19 Backport failed because of merge conflicts
❌ 9.0 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.0:
- [DOCS][9.0.3, 9.0.4, 9.1.0] [Known Issue] Rule issues occur when xpack.alerting.rules.run.alerts.max is set to a value greater than 5000 (#230837)
- Remove unused deps (#230630)
✅ 9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 230729

Questions ?

Please refer to the Backport tool documentation
gergoabraham pushed a commit to gergoabraham/kibana that referenced this pull request Aug 7, 2025
@sphilipse @gergoabraham
[Search] Fix null property being read on Playground (elastic#230729)
da4e08a 
## Summary

This prevents Playground from throwing a useless null error when being
provided with an empty search hit.
denar50 pushed a commit to denar50/kibana that referenced this pull request Aug 8, 2025
@sphilipse @denar50
[Search] Fix null property being read on Playground (elastic#230729)
08c0e9a 
## Summary

This prevents Playground from throwing a useless null error when being
provided with an empty search hit.
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 8, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 8, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @sphilipse
6 similar comments
@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 11, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @sphilipse
@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 12, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @sphilipse
@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 13, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @sphilipse
@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 14, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @sphilipse
@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 15, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @sphilipse
@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 18, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @sphilipse
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Aug 18, 2025
@sphilipse @NicholasPeretti
[Search] Fix null property being read on Playground (elastic#230729)
1a9aac6 
## Summary

This prevents Playground from throwing a useless null error when being
provided with an empty search hit.
@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 19, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @sphilipse
@sphilipse sphilipse added backport:skip This PR does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:all-open Backport to all branches that could still receive a release labels Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:fix v9.2.0

4 participants

@sphilipse @elasticmachine @kibanamachine @Samiul-TheSoccerFan