[ML][AI Connector] UX enhancements for editing fields in the AI Connector flyout by alvarezmelissa87 · Pull Request #231037 · elastic/kibana

alvarezmelissa87 · 2025-08-07T20:19:07Z

Summary

Related issue: #226580
This PR updates the sections for the AI/Inference connector as described in the issue linked above.

AIConnectorSections.mov

Multiple authentication fields:
Addresses #226588

Elasticsearch on serverless with adaptive allocations:

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
Flaky Test Runner was used on any tests changed
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
Review the backport guidelines and apply applicable backport:* labels.

alvarezmelissa87 · 2025-08-07T20:24:10Z

cc @joana-cps - can you confirm the design looks alright? 🙏

joana-cps · 2025-08-11T09:10:22Z

cc @joana-cps - can you confirm the design looks alright? 🙏

Looks good, just adding this here for visibility. Can we have the Additional options close by default? Thanks

alvarezmelissa87 · 2025-08-11T22:29:47Z

/ci

elasticmachine · 2025-08-11T22:53:18Z

Pinging @elastic/ml-ui (:ml)

qn895 · 2025-08-12T18:56:13Z

.../kbn-inference-endpoint-ui-common/src/components/configuration/authentication_form_items.tsx

+import React, { useMemo, useState } from 'react';
+import { EuiButtonGroup, EuiFlexGroup, EuiFlexItem, EuiTitle } from '@elastic/eui';
+import { FormattedMessage } from '@kbn/i18n-react';
+import { ConfigEntryView } from '../../types/types';


nit: import type ConfigEntryView

Good catch - updated in 7425aa0

qn895 · 2025-08-12T18:59:01Z

...kages/shared/kbn-inference-endpoint-ui-common/src/components/configuration/item_form_row.tsx

+      <>
+        {description}{' '}
+        <EuiLink
+          href="https://www.elastic.co/guide/en/elasticsearch/reference/current/inference-apis.html#default-enpoints"


is this at all in the docsLink service?

Thanks for taking a look 🙏 It's not in the docsLink service. I did notice the url is wrong so I went ahead and updated it.
As this is the only link in the package and is only used for the internal provider, I'm not sure it's worth passing the whole service through. 🤔 Worth keeping an eye on as we update this code, though.

Updated to fix link in 7425aa0

qn895 · 2025-08-12T19:01:38Z

.../kbn-inference-endpoint-ui-common/src/components/configuration/authentication_form_items.tsx

+  );
+
+  return (
+    <EuiFlexGroup direction="column" data-test-subj="authentication-fields">


super duper nit: Suggestion to titleCase data-test-subj so they are formatted consistently with the rest of Kibana. Potentially prefix with 'inferenceUI'? e.g. inferenceUIAuthenticationFields

Never mind, just saw the test subjects for this plugin are in this format.

Samiul-TheSoccerFan

LGTM

Samiul-TheSoccerFan · 2025-08-12T21:09:00Z

...ackages/shared/kbn-inference-endpoint-ui-common/src/components/additional_options_fields.tsx

-        <EuiTextColor color={euiTheme.colors.primary}>
+        <EuiTextColor
+          color={euiTheme.colors.primary}
+          data-test-subj="inference-endpoint-additional-options-button"


nitpick: Do we need to update options to settings` here too?

Updated for consistency in 7425aa0

Samiul-TheSoccerFan · 2025-08-12T21:11:45Z

...ges/shared/kbn-inference-endpoint-ui-common/src/components/inference_service_form_fields.tsx

+            requiredProviderFormFields={authenticationFormFields}
+            setRequiredProviderFormFields={setAuthenticationFormFields}


Samiul-TheSoccerFan · 2025-08-12T21:13:50Z

...ges/shared/kbn-inference-endpoint-ui-common/src/components/inference_service_form_fields.tsx

+              <EuiHorizontalRule margin="m" />
+            </>
+          ) : null}
+          {/* ADDITIONAL OPTIONS */}


Do we need this part anymore? Optional fields are already handled.

On a second thought, this might be the task_settings, I assume?

Thanks for taking a look, @Samiul-TheSoccerFan 🙏
Yes, these is now the extra settings like, task type and the inference endpoint.
'More options' is now the optional config settings for the provider.

So we've got
Required and not sensitive - Settings
Optional and not sensitive - More Options
Sensitive - Auth settings
Additional options - Inference endpoint and task type

peteharverson

Tested locally (including serverless) and LGTM

alvarezmelissa87 · 2025-08-13T19:47:31Z

@elasticmachine merge upstream

qn895

LGTM 🎉

darnautov · 2025-08-14T10:46:36Z

...ggers_actions_ui/public/application/sections/action_connector_form/connector_form_fields.tsx

-            </h4>
-          </EuiTitle>
-          <EuiSpacer size="s" />
+          {actionTypeModel?.id && actionTypeModel.id !== '.inference' ? (


The generic connector form should not be aware of a specific connector ID or adjust its layout based on it. Such alterations are unsustainable and difficult to maintain.

With the planned work in #231016, do we actually need the current change?

If it’s really critical, we can consolidate this logic in one place and remove it once the issue above is resolved. There are already checks in formDeserializer and formSerializer for the .inference connector. Something like this would work:

// TODO remove when https://github.com/elastic/kibana/issues/231016 is resolved const connectorOverrides = (connectorId: string) => { switch(connectorId): { case '.inference': return : { formDeserializer: ... formSerializer: ... shouldHideConnectorSettings: ... } } }

Hm - good point! Yes, I think adding the overrides make sense - with the intention of being able to remove them once they are no longer needed. AFAIK there is planning also being done for allowing the connector framework to have connector-specific serializers so that should solve that issue, as well.

Will update 👍

Updated here: 188f56f

Thanks for the edits @alvarezmelissa87! I noticed that instead of returning callbacks for formDeserializer and formSerializer, you’re returning serialized and deserialized forms. This makes everything happen at once, whereas we usually handle these steps one at a time. It also makes the naming semantically confusing. Left a suggestion below, but otherwise LGTM

Callbacks are a better idea 👍
Updated in 374211f

…no-cache --fix'

darnautov · 2025-08-18T07:31:38Z

...red/triggers_actions_ui/public/application/sections/action_connector_form/connector_form.tsx

+  const overrides = connectorOverrides(formData.actionTypeId, formData);
+  if (overrides?.formSerializer) {
+    return overrides.formSerializer;


Thanks for consolidating the overrides in one place! I noticed the code unnecessarily serializes and deserializes the form at once. My suggestion was to return a callback instead.

const overrides = connectorOverrides(formData.actionTypeId); if (overrides?.formSerializer) { return overrides.formSerializer(formData);

Good call - updated to be callbacks here 374211f

alvarezmelissa87 · 2025-08-18T16:54:54Z

@elasticmachine merge upstream

elasticmachine · 2025-08-18T21:24:24Z

💚 Build Succeeded

Buildkite Build
Commit: 374211f

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`indexManagement`	668	671	+3
`searchInferenceEndpoints`	146	149	+3
`searchPlayground`	399	402	+3
`securitySolution`	7882	7885	+3
`stackConnectors`	338	341	+3
`triggersActionsUi`	965	966	+1
total			+16

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`indexManagement`	681.6KB	683.4KB	+1.8KB
`searchInferenceEndpoints`	98.7KB	100.4KB	+1.8KB
`securitySolution`	10.4MB	10.4MB	-6.0B
`stackConnectors`	620.0KB	621.8KB	+1.8KB
`triggersActionsUi`	1.5MB	1.5MB	+385.0B
total			+5.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`triggersActionsUi`	104.6KB	104.6KB	-5.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`triggersActionsUi`	102	103	+1

Total ESLint disabled count

id	before	after	diff
`triggersActionsUi`	107	108	+1

History

💚 Build #330163 succeeded 5c5886e
💚 Build #329885 succeeded 188f56f
💚 Build #329344 succeeded 03c47aa
💔 Build #329287 failed 0275394
💔 Build #328971 failed 7425aa0
💛 Build #328868 was flaky c096676

cc @alvarezmelissa87

…lastic#231037) ## Summary Related issue: elastic#226580 This PR updates the sections for the AI/Inference connector as described in the issue linked above. https://github.com/user-attachments/assets/0ab473a3-e444-4e02-a7e8-b522722247bf Multiple authentication fields: Addresses elastic#226588 <img width="630" height="875" alt="image" src="https://github.com/user-attachments/assets/fc66b51f-0699-42c7-9bba-f7ddff8b7e36" /> Elasticsearch on serverless with adaptive allocations: <img width="635" height="928" alt="image" src="https://github.com/user-attachments/assets/91217ee8-d7f0-4adf-a3e4-9731ab97ee08" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

alvarezmelissa87 added 3 commits August 7, 2025 11:30

wip: reorganize flyout

c8fa23d

update translations

6fd07e6

only remove connector title for inference connector

d1498a9

alvarezmelissa87 self-assigned this Aug 7, 2025

alvarezmelissa87 added release_note:enhancement :ml backport:skip This PR does not require backporting Feature:Inference UI ML Inference endpoints UI and AI connector v9.2.0 labels Aug 7, 2025

alvarezmelissa87 mentioned this pull request Aug 4, 2025

[ML][AI Connector] AI Connector flyout sections and field improvements #226580

Closed

4 tasks

alvarezmelissa87 added 2 commits August 7, 2025 14:42

remove duplicate code

6d2ed74

only show sections when there are items

e6c50d5

alvarezmelissa87 added 3 commits August 11, 2025 15:37

update auth section for multiple auth types

e655a98

Merge branch 'main' into ai-connector-sections

145e249

add back config consts

8d40479

update hidden validator fields

92cb316

alvarezmelissa87 marked this pull request as ready for review August 11, 2025 22:53

alvarezmelissa87 requested review from a team as code owners August 11, 2025 22:53

alvarezmelissa87 requested review from Samiul-TheSoccerFan, jgowdyelastic, peteharverson and qn895 and removed request for qn895 August 11, 2025 22:53

alvarezmelissa87 added 2 commits August 11, 2025 16:58

fix validation function type

6823ac1

update inference endpoint functional test

c096676

alvarezmelissa87 requested a review from a team as a code owner August 12, 2025 18:25

alvarezmelissa87 requested a review from qn895 August 12, 2025 18:27

qn895 reviewed Aug 12, 2025

View reviewed changes

Samiul-TheSoccerFan approved these changes Aug 12, 2025

View reviewed changes

Update doc link

7425aa0

peteharverson approved these changes Aug 13, 2025

View reviewed changes

update jest test for config form component

0275394

Merge branch 'main' into ai-connector-sections

03c47aa

qn895 approved these changes Aug 13, 2025

View reviewed changes

darnautov self-requested a review August 14, 2025 10:24

darnautov reviewed Aug 14, 2025

View reviewed changes

alvarezmelissa87 and others added 3 commits August 14, 2025 16:14

create override function to store type specific changes

188f56f

Merge branch 'main' into ai-connector-sections

3d1e04f

[CI] Auto-commit changed files from 'node scripts/eslint_all_files --…

5c5886e

…no-cache --fix'

darnautov reviewed Aug 18, 2025

View reviewed changes

darnautov approved these changes Aug 18, 2025

View reviewed changes

elasticmachine and others added 2 commits August 18, 2025 18:55

Merge branch 'main' into ai-connector-sections

f8eeaec

update serializers to be callbacks

374211f

alvarezmelissa87 merged commit 85f7585 into elastic:main Aug 19, 2025
12 checks passed

alvarezmelissa87 deleted the ai-connector-sections branch August 19, 2025 16:39

alvarezmelissa87 mentioned this pull request Aug 29, 2025

[ML][AI Connector] Azure OpenAI Authentication fields #226588

Closed

peteharverson changed the title ~~[ML][AI Connector] Updating sections and adding field improvements~~ Sep 24, 2025

		requiredProviderFormFields={authenticationFormFields}
		setRequiredProviderFormFields={setAuthenticationFormFields}

Conversation

alvarezmelissa87 commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

alvarezmelissa87 commented Aug 7, 2025

joana-cps commented Aug 11, 2025

alvarezmelissa87 commented Aug 11, 2025

elasticmachine commented Aug 11, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Samiul-TheSoccerFan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

peteharverson left a comment

Choose a reason for hiding this comment

alvarezmelissa87 commented Aug 13, 2025

qn895 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alvarezmelissa87 commented Aug 18, 2025

elasticmachine commented Aug 18, 2025

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

Labels

8 participants

alvarezmelissa87 commented Aug 7, 2025 •

edited

Loading