[Discover] Disable sorting for json-like fields in ES|QL mode#231289
Merged
jughosta merged 4 commits intoelastic:mainfrom Aug 14, 2025
Merged
[Discover] Disable sorting for json-like fields in ES|QL mode#231289jughosta merged 4 commits intoelastic:mainfrom
jughosta merged 4 commits intoelastic:mainfrom
Conversation
jughosta
added
release_note:fix
Team:DataDiscovery
jughosta
commented
Aug 11, 2025
Comment on lines
+135
to
+141
| return Boolean( | ||
| columnSchema !== kibanaJSON || | ||
| (dataViewField?.type && | ||
| Object.values(NonStringSortableFieldType).includes( | ||
| dataViewField.type as NonStringSortableFieldType | ||
| )) | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
@stratoula Would you advise to exclude only geo fields instead? Can't decide if it should check for any json-like fields excluding the ones which are handled separately. Or it should exclude only geo fields explicitly. What would be safer? We used to disable sorting only for _source in ES|QL mode.
Contributor
There was a problem hiding this comment.
I would go with any json-like fields Jul
Contributor
Author
There was a problem hiding this comment.
Thanks! Then I will keep these changes.
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
stratoula
approved these changes
Aug 12, 2025
Contributor
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
This works great, thanx Jul!
| dataViewField: DataViewField | undefined; | ||
| }): boolean => { | ||
| if (isPlainRecord) { | ||
| // TODO: would be great to have something like `sortable` flag for text based columns too |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Async chunks
History
cc @jughosta |
nickofthyme
approved these changes
Aug 13, 2025
akowalska622
approved these changes
Aug 14, 2025
Contributor
akowalska622
left a comment
akowalska622
left a comment
There was a problem hiding this comment.
Good job, code looks good and works as expected 🚀
Comment on lines
-248
to
+270
| if (type === 'date') { | ||
| if (type === NonStringSortableFieldType.date) { | ||
| return getUndefinedHandler(sortBy, arrayValueHandler(dateCompare)); | ||
| } | ||
| if (type === 'number') { | ||
| if (type === NonStringSortableFieldType.number) { | ||
| return getUndefinedHandler(sortBy, arrayValueHandler(numberCompare)); | ||
| } | ||
| // this is a custom type, and can safely assume the gte and lt fields are all numbers or undefined | ||
| if (type === 'range') { | ||
| if (type === NonStringSortableFieldType.range) { | ||
| return getUndefinedHandler(sortBy, arrayValueHandler(rangeComparison)); | ||
| } | ||
| // IP have a special sorting | ||
| if (type === 'ip') { | ||
| if (type === NonStringSortableFieldType.ip) { | ||
| return getUndefinedHandler(sortBy, arrayValueHandler(ipComparison)); | ||
| } | ||
| if (type === 'version') { | ||
| if (type === NonStringSortableFieldType.version) { |
Contributor
There was a problem hiding this comment.
I love the enum refactor, huge fan of this approach ❤️
Contributor
|
Starting backport for target branches: 8.19, 9.0, 9.1 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
This was referenced Aug 14, 2025
jughosta
added a commit
to jughosta/kibana
that referenced
this pull request
Aug 14, 2025
…c#231289) - Closes elastic#231280 ## Summary This PR disables sorting for json-like fields in ES|QL mode. Before: <img width="696" height="245" alt="Screenshot 2025-08-11 at 13 31 57" src="https://github.com/user-attachments/assets/74e2f23f-3d4b-4215-b047-e9224db46c76" /> After: <img width="725" height="294" alt="Screenshot 2025-08-11 at 14 35 10" src="https://github.com/user-attachments/assets/f79f3129-5ccc-4a19-8bc0-93df4da01345" /> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 63b2603) # Conflicts: # src/platform/packages/shared/kbn-unified-data-table/src/components/data_table_columns.tsx
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jughosta
added a commit
to jughosta/kibana
that referenced
this pull request
Aug 14, 2025
…c#231289) - Closes elastic#231280 ## Summary This PR disables sorting for json-like fields in ES|QL mode. Before: <img width="696" height="245" alt="Screenshot 2025-08-11 at 13 31 57" src="https://github.com/user-attachments/assets/74e2f23f-3d4b-4215-b047-e9224db46c76" /> After: <img width="725" height="294" alt="Screenshot 2025-08-11 at 14 35 10" src="https://github.com/user-attachments/assets/f79f3129-5ccc-4a19-8bc0-93df4da01345" /> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 63b2603) # Conflicts: # src/platform/packages/shared/kbn-unified-data-table/src/components/data_table_columns.tsx
jughosta
added a commit
to jughosta/kibana
that referenced
this pull request
Aug 14, 2025
…c#231289) - Closes elastic#231280 ## Summary This PR disables sorting for json-like fields in ES|QL mode. Before: <img width="696" height="245" alt="Screenshot 2025-08-11 at 13 31 57" src="https://github.com/user-attachments/assets/74e2f23f-3d4b-4215-b047-e9224db46c76" /> After: <img width="725" height="294" alt="Screenshot 2025-08-11 at 14 35 10" src="https://github.com/user-attachments/assets/f79f3129-5ccc-4a19-8bc0-93df4da01345" /> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 63b2603) # Conflicts: # src/platform/packages/shared/kbn-unified-data-table/src/components/data_table_columns.tsx
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
jughosta
added a commit
that referenced
this pull request
Aug 18, 2025
…231289) (#231857) # Backport This will backport the following commits from `main` to `9.1`: - [[Discover] Disable sorting for json-like fields in ES|QL mode (#231289)](#231289) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2025-08-14T11:47:56Z","message":"[Discover] Disable sorting for json-like fields in ES|QL mode (#231289)\n\n- Closes https://github.com/elastic/kibana/issues/231280\n\n## Summary\n\nThis PR disables sorting for json-like fields in ES|QL mode.\n\nBefore:\n<img width=\"696\" height=\"245\" alt=\"Screenshot 2025-08-11 at 13 31 57\"\nsrc=\"https://github.com/user-attachments/assets/74e2f23f-3d4b-4215-b047-e9224db46c76\"\n/>\n\nAfter:\n<img width=\"725\" height=\"294\" alt=\"Screenshot 2025-08-11 at 14 35 10\"\nsrc=\"https://github.com/user-attachments/assets/f79f3129-5ccc-4a19-8bc0-93df4da01345\"\n/>\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"63b260336e13c699560739b8c3fe0181a22c807b","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:version","v9.2.0","v9.1.3","v8.19.3","v9.0.6"],"title":"[Discover] Disable sorting for json-like fields in ES|QL mode","number":231289,"url":"https://github.com/elastic/kibana/pull/231289","mergeCommit":{"message":"[Discover] Disable sorting for json-like fields in ES|QL mode (#231289)\n\n- Closes https://github.com/elastic/kibana/issues/231280\n\n## Summary\n\nThis PR disables sorting for json-like fields in ES|QL mode.\n\nBefore:\n<img width=\"696\" height=\"245\" alt=\"Screenshot 2025-08-11 at 13 31 57\"\nsrc=\"https://github.com/user-attachments/assets/74e2f23f-3d4b-4215-b047-e9224db46c76\"\n/>\n\nAfter:\n<img width=\"725\" height=\"294\" alt=\"Screenshot 2025-08-11 at 14 35 10\"\nsrc=\"https://github.com/user-attachments/assets/f79f3129-5ccc-4a19-8bc0-93df4da01345\"\n/>\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"63b260336e13c699560739b8c3fe0181a22c807b"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19","9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/231289","number":231289,"mergeCommit":{"message":"[Discover] Disable sorting for json-like fields in ES|QL mode (#231289)\n\n- Closes https://github.com/elastic/kibana/issues/231280\n\n## Summary\n\nThis PR disables sorting for json-like fields in ES|QL mode.\n\nBefore:\n<img width=\"696\" height=\"245\" alt=\"Screenshot 2025-08-11 at 13 31 57\"\nsrc=\"https://github.com/user-attachments/assets/74e2f23f-3d4b-4215-b047-e9224db46c76\"\n/>\n\nAfter:\n<img width=\"725\" height=\"294\" alt=\"Screenshot 2025-08-11 at 14 35 10\"\nsrc=\"https://github.com/user-attachments/assets/f79f3129-5ccc-4a19-8bc0-93df4da01345\"\n/>\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"63b260336e13c699560739b8c3fe0181a22c807b"}},{"branch":"9.1","label":"v9.1.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
jughosta
added a commit
that referenced
this pull request
Aug 18, 2025
…231289) (#231858) # Backport This will backport the following commits from `main` to `9.0`: - [[Discover] Disable sorting for json-like fields in ES|QL mode (#231289)](#231289) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2025-08-14T11:47:56Z","message":"[Discover] Disable sorting for json-like fields in ES|QL mode (#231289)\n\n- Closes https://github.com/elastic/kibana/issues/231280\n\n## Summary\n\nThis PR disables sorting for json-like fields in ES|QL mode.\n\nBefore:\n<img width=\"696\" height=\"245\" alt=\"Screenshot 2025-08-11 at 13 31 57\"\nsrc=\"https://github.com/user-attachments/assets/74e2f23f-3d4b-4215-b047-e9224db46c76\"\n/>\n\nAfter:\n<img width=\"725\" height=\"294\" alt=\"Screenshot 2025-08-11 at 14 35 10\"\nsrc=\"https://github.com/user-attachments/assets/f79f3129-5ccc-4a19-8bc0-93df4da01345\"\n/>\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"63b260336e13c699560739b8c3fe0181a22c807b","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:version","v9.2.0","v9.1.3","v8.19.3","v9.0.6"],"title":"[Discover] Disable sorting for json-like fields in ES|QL mode","number":231289,"url":"https://github.com/elastic/kibana/pull/231289","mergeCommit":{"message":"[Discover] Disable sorting for json-like fields in ES|QL mode (#231289)\n\n- Closes https://github.com/elastic/kibana/issues/231280\n\n## Summary\n\nThis PR disables sorting for json-like fields in ES|QL mode.\n\nBefore:\n<img width=\"696\" height=\"245\" alt=\"Screenshot 2025-08-11 at 13 31 57\"\nsrc=\"https://github.com/user-attachments/assets/74e2f23f-3d4b-4215-b047-e9224db46c76\"\n/>\n\nAfter:\n<img width=\"725\" height=\"294\" alt=\"Screenshot 2025-08-11 at 14 35 10\"\nsrc=\"https://github.com/user-attachments/assets/f79f3129-5ccc-4a19-8bc0-93df4da01345\"\n/>\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"63b260336e13c699560739b8c3fe0181a22c807b"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19","9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/231289","number":231289,"mergeCommit":{"message":"[Discover] Disable sorting for json-like fields in ES|QL mode (#231289)\n\n- Closes https://github.com/elastic/kibana/issues/231280\n\n## Summary\n\nThis PR disables sorting for json-like fields in ES|QL mode.\n\nBefore:\n<img width=\"696\" height=\"245\" alt=\"Screenshot 2025-08-11 at 13 31 57\"\nsrc=\"https://github.com/user-attachments/assets/74e2f23f-3d4b-4215-b047-e9224db46c76\"\n/>\n\nAfter:\n<img width=\"725\" height=\"294\" alt=\"Screenshot 2025-08-11 at 14 35 10\"\nsrc=\"https://github.com/user-attachments/assets/f79f3129-5ccc-4a19-8bc0-93df4da01345\"\n/>\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"63b260336e13c699560739b8c3fe0181a22c807b"}},{"branch":"9.1","label":"v9.1.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
jughosta
added a commit
that referenced
this pull request
Aug 18, 2025
…231289) (#231859) # Backport This will backport the following commits from `main` to `8.19`: - [[Discover] Disable sorting for json-like fields in ES|QL mode (#231289)](#231289) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2025-08-14T11:47:56Z","message":"[Discover] Disable sorting for json-like fields in ES|QL mode (#231289)\n\n- Closes https://github.com/elastic/kibana/issues/231280\n\n## Summary\n\nThis PR disables sorting for json-like fields in ES|QL mode.\n\nBefore:\n<img width=\"696\" height=\"245\" alt=\"Screenshot 2025-08-11 at 13 31 57\"\nsrc=\"https://github.com/user-attachments/assets/74e2f23f-3d4b-4215-b047-e9224db46c76\"\n/>\n\nAfter:\n<img width=\"725\" height=\"294\" alt=\"Screenshot 2025-08-11 at 14 35 10\"\nsrc=\"https://github.com/user-attachments/assets/f79f3129-5ccc-4a19-8bc0-93df4da01345\"\n/>\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"63b260336e13c699560739b8c3fe0181a22c807b","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:version","v9.2.0","v9.1.3","v8.19.3","v9.0.6"],"title":"[Discover] Disable sorting for json-like fields in ES|QL mode","number":231289,"url":"https://github.com/elastic/kibana/pull/231289","mergeCommit":{"message":"[Discover] Disable sorting for json-like fields in ES|QL mode (#231289)\n\n- Closes https://github.com/elastic/kibana/issues/231280\n\n## Summary\n\nThis PR disables sorting for json-like fields in ES|QL mode.\n\nBefore:\n<img width=\"696\" height=\"245\" alt=\"Screenshot 2025-08-11 at 13 31 57\"\nsrc=\"https://github.com/user-attachments/assets/74e2f23f-3d4b-4215-b047-e9224db46c76\"\n/>\n\nAfter:\n<img width=\"725\" height=\"294\" alt=\"Screenshot 2025-08-11 at 14 35 10\"\nsrc=\"https://github.com/user-attachments/assets/f79f3129-5ccc-4a19-8bc0-93df4da01345\"\n/>\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"63b260336e13c699560739b8c3fe0181a22c807b"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19","9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/231289","number":231289,"mergeCommit":{"message":"[Discover] Disable sorting for json-like fields in ES|QL mode (#231289)\n\n- Closes https://github.com/elastic/kibana/issues/231280\n\n## Summary\n\nThis PR disables sorting for json-like fields in ES|QL mode.\n\nBefore:\n<img width=\"696\" height=\"245\" alt=\"Screenshot 2025-08-11 at 13 31 57\"\nsrc=\"https://github.com/user-attachments/assets/74e2f23f-3d4b-4215-b047-e9224db46c76\"\n/>\n\nAfter:\n<img width=\"725\" height=\"294\" alt=\"Screenshot 2025-08-11 at 14 35 10\"\nsrc=\"https://github.com/user-attachments/assets/f79f3129-5ccc-4a19-8bc0-93df4da01345\"\n/>\n\n\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"63b260336e13c699560739b8c3fe0181a22c807b"}},{"branch":"9.1","label":"v9.1.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
kibanamachine
removed
the
backport missing
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
…c#231289) - Closes elastic#231280 ## Summary This PR disables sorting for json-like fields in ES|QL mode. Before: <img width="696" height="245" alt="Screenshot 2025-08-11 at 13 31 57" src="https://github.com/user-attachments/assets/74e2f23f-3d4b-4215-b047-e9224db46c76" /> After: <img width="725" height="294" alt="Screenshot 2025-08-11 at 14 35 10" src="https://github.com/user-attachments/assets/f79f3129-5ccc-4a19-8bc0-93df4da01345" /> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Aug 26, 2025
…c#231289) - Closes elastic#231280 ## Summary This PR disables sorting for json-like fields in ES|QL mode. Before: <img width="696" height="245" alt="Screenshot 2025-08-11 at 13 31 57" src="https://github.com/user-attachments/assets/74e2f23f-3d4b-4215-b047-e9224db46c76" /> After: <img width="725" height="294" alt="Screenshot 2025-08-11 at 14 35 10" src="https://github.com/user-attachments/assets/f79f3129-5ccc-4a19-8bc0-93df4da01345" /> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR disables sorting for json-like fields in ES|QL mode.
Before:
After:
Checklist
release_note:*label is applied per the guidelinesbackport:*labels.