[ML] Data Frame Analytics: Improves layout for custom URLs list#232575
Conversation
KodeRad
added
enhancement
|
Pinging @elastic/ml-ui (:ml) |
peteharverson
changed the title
| } | ||
| > | ||
| <EuiFormRow fullWidth> | ||
| <EuiFormRow fullWidth css={styles.formRow}> |
There was a problem hiding this comment.
Not related to the changes here, but for indices without a time field we correctly hide the time range field in the wizard form. However we are showing it in the Edit job flyout. I think we should be hiding it here as it is irrelevant for jobs where the results index doesn't contain a time field. Unless I've missed something @alvarezmelissa87 ?
Maybe you could include this in the refactor follow up - #232576?
There was a problem hiding this comment.
AFAIK you're right - they should be hidden if no time field is present. 👍
There was a problem hiding this comment.
This will be addressed in the refactor follow up #232576
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
LGTM. Added a comment about the time range field, but suggest this is done in the follow-up.
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @KodeRad |
4 participants
Summary
Follow-up PR to the #231751
There is another place in which this component is used.
It is located at Data Frame Analytics > Create Job wizard
Screenshot with the fix:
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.