Add search functionality to query rule detail panel#232579
Merged
efegurkan merged 9 commits intoelastic:mainfrom Sep 16, 2025
Merged
Add search functionality to query rule detail panel#232579efegurkan merged 9 commits intoelastic:mainfrom
efegurkan merged 9 commits intoelastic:mainfrom
Conversation
efegurkan
added
backport:version
wildemat
approved these changes
Sep 8, 2025
Contributor
wildemat
left a comment
wildemat
left a comment
There was a problem hiding this comment.
approved with some non blocking comments
...search_query_rules/public/components/query_ruleset_detail/use_query_ruleset_detail_state.tsx
Show resolved
Hide resolved
| <EuiFlexGroup direction="column" gutterSize="xs" responsive={false}> | ||
| {Array.isArray(queryRule.criteria) ? ( | ||
| <> | ||
| {queryRule.criteria.slice(0, 3).map((criteria, criteriaIndex) => ( |
Contributor
There was a problem hiding this comment.
Nit:
I'm unfamiliar with the design spec used for this list. Does 3 represent just the max results we want to show? Maybe have a named constant?
| <> | ||
| {queryRule.criteria.slice(0, 3).map((criteria, criteriaIndex) => ( | ||
| <EuiFlexItem key={criteria.type + criteriaIndex} grow={false}> | ||
| <QueryRuleDraggableItemCriteriaDisplay criteria={criteria} /> |
Contributor
There was a problem hiding this comment.
Unrelated to this change, but the query rules list component doesn't announce list items properly on voice over. It hops between "Drag Handle" announcements. Perhaps there's already an a11y issue for this
Samiul-TheSoccerFan
approved these changes
Sep 8, 2025
Contributor
Samiul-TheSoccerFan
left a comment
Samiul-TheSoccerFan
left a comment
There was a problem hiding this comment.
LGTM, @wildemat has some good suggestions if you are interested :).
Comment on lines
78
to
88
| <EuiPanel paddingSize="s" hasShadow={false}> | ||
| <EuiFlexGroup alignItems="center" gutterSize="m"> | ||
| <EuiFlexItem grow={false}> | ||
| {/* Custom spacer to prevent elements jumping in between search and list */} | ||
| <EuiPanel | ||
| color="transparent" | ||
| paddingSize="s" | ||
| css={css({ | ||
| minWidth: euiTheme.base * 2, | ||
| minHeight: euiTheme.base * 2, | ||
| })} |
Contributor
There was a problem hiding this comment.
A lot of these codes looks almost similar to https://github.com/elastic/kibana/blob/main/x-pack/solutions/search/plugins/search_query_rules/public/components/query_ruleset_detail/query_rule_draggable_list/query_rule_draggable_list.tsx. If this is the case, may be it would be helpful to create a shareable component instead of duplicating the same work.
Member
Author
|
@elasticmachine merge upstream |
Add context to the aria label on draggable element. Add a max visible constant for the slice of criterion. Updated filter function to a more readable suggestion from Matt.
| }} | ||
| fullWidth | ||
| incremental={true} | ||
| aria-label="Search rules" |
| <EuiFlexItem> | ||
| <EuiFieldSearch | ||
| data-test-subj="queryRulesetDetailSearchFilter" | ||
| placeholder={'Search rules...'} |
| <EuiFlexItem> | ||
| {rules.length === 0 && <RulesetDetailEmptyPrompt />} | ||
| {rules.length > 0 && ( | ||
| {rules.length === 0 && <RulesetDetailEmptyPrompt isFilter={searchFilter.trim() !== ''} />} |
Contributor
There was a problem hiding this comment.
We're doing searchFilter.trim() !== '' in 3 different places in the component, should we introduce a variable for this instead?
const hasSearchFilter = searchFilter.trim() !== ''
wildemat
approved these changes
Sep 16, 2025
Contributor
wildemat
left a comment
wildemat
left a comment
There was a problem hiding this comment.
+1 to @TattdCodeMonkey comments. Otherwise recent changes LGTM
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Saved Objects .kibana field count
History
|
Contributor
|
Starting backport for target branches: 8.19, 9.1 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
baileycash-elastic
pushed a commit
to baileycash-elastic/kibana
that referenced
this pull request
Sep 16, 2025
## Summary Adds search element to the query rules detail page. Summarize your PR. If it involves visual changes include a screenshot or gif. <img width="2539" height="640" alt="Screenshot 2025-09-07 at 14 22 29" src="https://github.com/user-attachments/assets/25bd158b-8b49-4ceb-9467-ab100665eee1" /> <img width="2552" height="843" alt="Screenshot 2025-09-07 at 14 22 42" src="https://github.com/user-attachments/assets/868f5061-0803-409e-9bcf-12ec355d6588" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This was referenced Sep 17, 2025
Member
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
efegurkan
added a commit
to efegurkan/kibana
that referenced
this pull request
Sep 17, 2025
## Summary Adds search element to the query rules detail page. Summarize your PR. If it involves visual changes include a screenshot or gif. <img width="2539" height="640" alt="Screenshot 2025-09-07 at 14 22 29" src="https://github.com/user-attachments/assets/25bd158b-8b49-4ceb-9467-ab100665eee1" /> <img width="2552" height="843" alt="Screenshot 2025-09-07 at 14 22 42" src="https://github.com/user-attachments/assets/868f5061-0803-409e-9bcf-12ec355d6588" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 3f87b78) # Conflicts: # x-pack/solutions/search/plugins/search_query_rules/public/components/empty_prompt/ruleset_detail_empty_prompt.tsx # x-pack/solutions/search/plugins/search_query_rules/public/components/query_ruleset_detail/query_rule_detail_panel.tsx # x-pack/solutions/search/plugins/search_query_rules/public/components/query_ruleset_detail/query_rule_draggable_list/query_rule_draggable_list.tsx
efegurkan
added a commit
to efegurkan/kibana
that referenced
this pull request
Sep 17, 2025
## Summary Adds search element to the query rules detail page. Summarize your PR. If it involves visual changes include a screenshot or gif. <img width="2539" height="640" alt="Screenshot 2025-09-07 at 14 22 29" src="https://github.com/user-attachments/assets/25bd158b-8b49-4ceb-9467-ab100665eee1" /> <img width="2552" height="843" alt="Screenshot 2025-09-07 at 14 22 42" src="https://github.com/user-attachments/assets/868f5061-0803-409e-9bcf-12ec355d6588" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 3f87b78) # Conflicts: # x-pack/solutions/search/plugins/search_query_rules/public/components/empty_prompt/ruleset_detail_empty_prompt.tsx # x-pack/solutions/search/plugins/search_query_rules/public/components/query_ruleset_detail/query_rule_detail_panel.tsx # x-pack/solutions/search/plugins/search_query_rules/public/components/query_ruleset_detail/query_rule_draggable_list/query_rule_draggable_list.tsx
efegurkan
added a commit
that referenced
this pull request
Sep 19, 2025
…235349) # Backport This will backport the following commits from `main` to `8.19`: - [Add search functionality to query rule detail panel (#232579)](#232579) <!--- Backport version: 10.0.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Efe Gürkan YALAMAN","email":"efeguerkan.yalaman@elastic.co"},"sourceCommit":{"committedDate":"2025-09-16T17:34:34Z","message":"Add search functionality to query rule detail panel (#232579)\n\n## Summary\n\nAdds search element to the query rules detail page.\n\nSummarize your PR. If it involves visual changes include a screenshot or\ngif.\n<img width=\"2539\" height=\"640\" alt=\"Screenshot 2025-09-07 at 14 22 29\"\nsrc=\"https://github.com/user-attachments/assets/25bd158b-8b49-4ceb-9467-ab100665eee1\"\n/>\n<img width=\"2552\" height=\"843\" alt=\"Screenshot 2025-09-07 at 14 22 42\"\nsrc=\"https://github.com/user-attachments/assets/868f5061-0803-409e-9bcf-12ec355d6588\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"3f87b785033de2f8c9d02dcc12738100af3f3521","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Search","release_note:feature","backport:version","v9.2.0","v8.19.5","v9.1.5"],"title":"Add search functionality to query rule detail panel","number":232579,"url":"https://github.com/elastic/kibana/pull/232579","mergeCommit":{"message":"Add search functionality to query rule detail panel (#232579)\n\n## Summary\n\nAdds search element to the query rules detail page.\n\nSummarize your PR. If it involves visual changes include a screenshot or\ngif.\n<img width=\"2539\" height=\"640\" alt=\"Screenshot 2025-09-07 at 14 22 29\"\nsrc=\"https://github.com/user-attachments/assets/25bd158b-8b49-4ceb-9467-ab100665eee1\"\n/>\n<img width=\"2552\" height=\"843\" alt=\"Screenshot 2025-09-07 at 14 22 42\"\nsrc=\"https://github.com/user-attachments/assets/868f5061-0803-409e-9bcf-12ec355d6588\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"3f87b785033de2f8c9d02dcc12738100af3f3521"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/232579","number":232579,"mergeCommit":{"message":"Add search functionality to query rule detail panel (#232579)\n\n## Summary\n\nAdds search element to the query rules detail page.\n\nSummarize your PR. If it involves visual changes include a screenshot or\ngif.\n<img width=\"2539\" height=\"640\" alt=\"Screenshot 2025-09-07 at 14 22 29\"\nsrc=\"https://github.com/user-attachments/assets/25bd158b-8b49-4ceb-9467-ab100665eee1\"\n/>\n<img width=\"2552\" height=\"843\" alt=\"Screenshot 2025-09-07 at 14 22 42\"\nsrc=\"https://github.com/user-attachments/assets/868f5061-0803-409e-9bcf-12ec355d6588\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"3f87b785033de2f8c9d02dcc12738100af3f3521"}},{"branch":"8.19","label":"v8.19.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
efegurkan
added a commit
that referenced
this pull request
Sep 19, 2025
…235348) # Backport This will backport the following commits from `main` to `9.1`: - [Add search functionality to query rule detail panel (#232579)](#232579) <!--- Backport version: 10.0.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Efe Gürkan YALAMAN","email":"efeguerkan.yalaman@elastic.co"},"sourceCommit":{"committedDate":"2025-09-16T17:34:34Z","message":"Add search functionality to query rule detail panel (#232579)\n\n## Summary\n\nAdds search element to the query rules detail page.\n\nSummarize your PR. If it involves visual changes include a screenshot or\ngif.\n<img width=\"2539\" height=\"640\" alt=\"Screenshot 2025-09-07 at 14 22 29\"\nsrc=\"https://github.com/user-attachments/assets/25bd158b-8b49-4ceb-9467-ab100665eee1\"\n/>\n<img width=\"2552\" height=\"843\" alt=\"Screenshot 2025-09-07 at 14 22 42\"\nsrc=\"https://github.com/user-attachments/assets/868f5061-0803-409e-9bcf-12ec355d6588\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"3f87b785033de2f8c9d02dcc12738100af3f3521","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Search","release_note:feature","backport:version","v9.2.0","v8.19.5","v9.1.5"],"title":"Add search functionality to query rule detail panel","number":232579,"url":"https://github.com/elastic/kibana/pull/232579","mergeCommit":{"message":"Add search functionality to query rule detail panel (#232579)\n\n## Summary\n\nAdds search element to the query rules detail page.\n\nSummarize your PR. If it involves visual changes include a screenshot or\ngif.\n<img width=\"2539\" height=\"640\" alt=\"Screenshot 2025-09-07 at 14 22 29\"\nsrc=\"https://github.com/user-attachments/assets/25bd158b-8b49-4ceb-9467-ab100665eee1\"\n/>\n<img width=\"2552\" height=\"843\" alt=\"Screenshot 2025-09-07 at 14 22 42\"\nsrc=\"https://github.com/user-attachments/assets/868f5061-0803-409e-9bcf-12ec355d6588\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"3f87b785033de2f8c9d02dcc12738100af3f3521"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/232579","number":232579,"mergeCommit":{"message":"Add search functionality to query rule detail panel (#232579)\n\n## Summary\n\nAdds search element to the query rules detail page.\n\nSummarize your PR. If it involves visual changes include a screenshot or\ngif.\n<img width=\"2539\" height=\"640\" alt=\"Screenshot 2025-09-07 at 14 22 29\"\nsrc=\"https://github.com/user-attachments/assets/25bd158b-8b49-4ceb-9467-ab100665eee1\"\n/>\n<img width=\"2552\" height=\"843\" alt=\"Screenshot 2025-09-07 at 14 22 42\"\nsrc=\"https://github.com/user-attachments/assets/868f5061-0803-409e-9bcf-12ec355d6588\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"3f87b785033de2f8c9d02dcc12738100af3f3521"}},{"branch":"8.19","label":"v8.19.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Sep 24, 2025
## Summary Adds search element to the query rules detail page. Summarize your PR. If it involves visual changes include a screenshot or gif. <img width="2539" height="640" alt="Screenshot 2025-09-07 at 14 22 29" src="https://github.com/user-attachments/assets/25bd158b-8b49-4ceb-9467-ab100665eee1" /> <img width="2552" height="843" alt="Screenshot 2025-09-07 at 14 22 42" src="https://github.com/user-attachments/assets/868f5061-0803-409e-9bcf-12ec355d6588" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
niros1
pushed a commit
that referenced
this pull request
Sep 30, 2025
## Summary Adds search element to the query rules detail page. Summarize your PR. If it involves visual changes include a screenshot or gif. <img width="2539" height="640" alt="Screenshot 2025-09-07 at 14 22 29" src="https://github.com/user-attachments/assets/25bd158b-8b49-4ceb-9467-ab100665eee1" /> <img width="2552" height="843" alt="Screenshot 2025-09-07 at 14 22 42" src="https://github.com/user-attachments/assets/868f5061-0803-409e-9bcf-12ec355d6588" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
rylnd
pushed a commit
to rylnd/kibana
that referenced
this pull request
Oct 17, 2025
## Summary Adds search element to the query rules detail page. Summarize your PR. If it involves visual changes include a screenshot or gif. <img width="2539" height="640" alt="Screenshot 2025-09-07 at 14 22 29" src="https://github.com/user-attachments/assets/25bd158b-8b49-4ceb-9467-ab100665eee1" /> <img width="2552" height="843" alt="Screenshot 2025-09-07 at 14 22 42" src="https://github.com/user-attachments/assets/868f5061-0803-409e-9bcf-12ec355d6588" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds search element to the query rules detail page.
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.