[Dashboard] Fix panel borders#232676
Merged
Heenawter merged 1 commit intoelastic:mainfrom Aug 22, 2025
Merged
Conversation
Heenawter
added
Feature:Dashboard
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
cc @Heenawter |
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
nreese
approved these changes
Aug 22, 2025
Contributor
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
LGTM. Thanks for reporting and fixing issue
code review only
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Aug 26, 2025
Closes elastic#232671 ## Summary The `PresentationPanelHoverActionsWrapper` styles were hard coded to be in edit mode, which meant that the panel border wasn't changing to solid in view mode as it should. This PR fixes that by properly passing the view mode to the panel styles. | Before | After | |--------|--------| |  |  | ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
KodeRad
pushed a commit
to KodeRad/kibana
that referenced
this pull request
Aug 28, 2025
Closes elastic#232671 ## Summary The `PresentationPanelHoverActionsWrapper` styles were hard coded to be in edit mode, which meant that the panel border wasn't changing to solid in view mode as it should. This PR fixes that by properly passing the view mode to the panel styles. | Before | After | |--------|--------| |  |  | ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #232671
Summary
The
PresentationPanelHoverActionsWrapperstyles were hard coded to be in edit mode, which meant that the panel border wasn't changing to solid in view mode as it should. This PR fixes that by properly passing the view mode to the panel styles.Checklist
release_note:*label is applied per the guidelinesbackport:*labels.