[Discover][Traces] Showing Logs in context of the trace

[kpatticha]

Summary

closes #232249

Screen.Recording.2025-08-25.at.3.59.28.PM.mov

Empty State	With Data

How to test

1. Make sure nav type is observability
2. select APM data view
3. open any transaction/span

TODO

• fix storybook

Notes for reviewers

• This PR registers the log events component as feature in discover cause this circular dependency is blocking me from using the component directly in the doc_viewer

[cauemarcondes]

@kpatticha is it possible to set a max height so we don't scroll like this covering the whole flyout content?

Another question:

• How valuable is the empty Logs section?

Asking because for Span links I'm not showing the section in case there's no links available.

[kpatticha]

@kpatticha is it possible to set a max height so we don't scroll like this covering the whole flyout content?

Yes we can set up max-height. I will update it

Another question:

• How valuable is the empty Logs section?
  Asking because for Span links I'm not showing the section in case there's no links available.

This is the inconsistency I was talking. The LazySavedSearchComponent handles the states and at the moment it doesn’t provide a callback for consumers to know whether data is available.

If we want to address this, it would be better to create a separate ticket.

[cauemarcondes]

LGTM, just some nits

[afharo]

kibana.jsonc reformatted. No real changes. LGTM

[davismcphee]

Code-only review, Data Discovery changes LGTM. Just one mock related request from my end.

[iblancof]

Asking because for Span links I'm not showing the section in case there's no links available.

@cauemarcondes I wanted to try this on your Span Links PR before asking, but I still don’t know how to set up the data for it (I left a comment suggesting it could be added as a “How to test” section in the description).

So, does this mean that we see the section with a loading state and then it disappears?

[kpatticha]

Asking because for Span links I'm not showing the section in case there's no links available.

@cauemarcondes I wanted to try this on your Span Links PR before asking, but I still don’t know how to set up the data for it (I left a comment suggesting it could be added as a “How to test” section in the description).

So, does this mean that we see the section with a loading state and then it disappears?

Are you asking for the Span links section ? The easiest way is to run the span_links scenario that generates some links. You can filter span.links.span.id: * in discover to see the documents that have the links . Also, some of the remote clusters have span links .

Based on the code: https://github.com/elastic/kibana/pull/232135/files#diff-741b102730d177939f71f243f6b836eb3db1104f3291eeb2e6b933066003a88bR116-R121 the section doesn't render

[iblancof]

Asking because for Span links I'm not showing the section in case there's no links available.

@cauemarcondes I wanted to try this on your Span Links PR before asking, but I still don’t know how to set up the data for it (I left a comment suggesting it could be added as a “How to test” section in the description).
So, does this mean that we see the section with a loading state and then it disappears?

Are you asking for the Span links section ? The easiest way is to run the span_links scenario that generates some links. You can filter span.links.span.id: * in discover to see the documents that have the links . Also, some of the remote clusters have span links .

Thank you @kpatticha! Apparently, I didn’t check the list of available scenarios carefully enough.

Based on the code: https://github.com/elastic/kibana/pull/232135/files#diff-741b102730d177939f71f243f6b836eb3db1104f3291eeb2e6b933066003a88bR116-R121 the section doesn't render

I decided to check it locally, and that makes sense since we don’t really show any loader for it, instead, the section just suddenly renders once the request is resolved.
I placed the section at the top to properly see the behavior:

Screen.Recording.2025-08-29.at.11.56.11.mov

It’s true that this section remains out of the user’s view unless they scroll, but I’m not sure this is the best practice.
Maybe we should consider adding a skeleton for section loading?

And sorry for hijacking this PR to talk about the other one, but I think we could decide on a unified approach for all sections.

[kpatticha]

Asking because for Span links I'm not showing the section in case there's no links available.

@cauemarcondes I wanted to try this on your Span Links PR before asking, but I still don’t know how to set up the data for it (I left a comment suggesting it could be added as a “How to test” section in the description).
So, does this mean that we see the section with a loading state and then it disappears?

Are you asking for the Span links section ? The easiest way is to run the span_links scenario that generates some links. You can filter span.links.span.id: * in discover to see the documents that have the links . Also, some of the remote clusters have span links .

Thank you @kpatticha! Apparently, I didn’t check the list of available scenarios carefully enough.

Based on the code: https://github.com/elastic/kibana/pull/232135/files#diff-741b102730d177939f71f243f6b836eb3db1104f3291eeb2e6b933066003a88bR116-R121 the section doesn't render

I decided to check it locally, and that makes sense since we don’t really show any loader for it, instead, the section just suddenly renders once the request is resolved. I placed the section at the top to properly see the behavior:

Screen.Recording.2025-08-29.at.11.56.11.mov
It’s true that this section remains out of the user’s view unless they scroll, but I’m not sure this is the best practice. Maybe we should consider adding a skeleton for section loading?

And sorry for hijacking this PR to talk about the other one, but I think we could decide on a unified approach for all sections.

No prob, these are valid points. This falls under the topic I previously shared regarding the state in the flyout, and I’ve created a design ticket to address it as we move forward.

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 498f249

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
logsShared	322	324	+2
unifiedDocViewer	377	379	+2
total			+4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
logsShared	203.2KB	203.1KB	-75.0B
unifiedDocViewer	280.2KB	281.8KB	+1.6KB
total			+1.5KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
discoverShared	3	4	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
logsShared	90.5KB	91.1KB	+631.0B

History

• 💔 Build #333998 failed 7d763ac
• 💚 Build #333578 succeeded a629b9a
• 💚 Build #333205 succeeded dcd7fd5
• 💔 Build #333184 failed 8291611
• 💔 Build #333168 failed 8bb839e

[achyutjhunjhunwala]

LGTM 👍🏼