[AI Infra] Choose which AI Assistant to show in the Elastic Header & Move the `AI Assistant visibility` setting to `GenAI Settings` page by rbrtj · Pull Request #233727 · elastic/kibana

rbrtj · 2025-09-02T11:46:10Z

Resolves #235602
This PR:

Moves the AI Assistant Visibility UI setting to GenAI Settings page. It disables the setting in Serverless and ECH Solution views.

Introduces a new navigation header selector for non-solution pages (Analytics, Stack Management), allowing users to choose which version of the Assistant they want to see. Based on their selection, the UI setting is updated, and the relevant Assistant window opens instantly.

Screen.Recording.2025-09-19.at.11.41.41.mov

… AI Assistant Management

…isibility-to-genai-settings-page

rbrtj · 2025-09-19T09:51:01Z

...observability/plugins/observability_ai_assistant_app/public/components/nav_control/index.tsx

+  useEffect(() => {
+    const openChatSubscription = aiAssistantManagementSelection.openChat$.subscribe((event) => {
+      if (event.assistant === 'observability') {
+        service.conversations.openNewConversation({ messages: [] });
+      }
+    });
+
+    return () => {
+      openChatSubscription.unsubscribe();
+    };
+  }, [aiAssistantManagementSelection.openChat$, service.conversations]);
+


Honestly, I don't think it's the right move to introduce this new subscription here. However, with this new selector, we need a way to instantly open the appropriate assistant window, and I couldn't think of a better solution to populate it with all the relevant configuration already in place. The trigger is exposed from ai_assistant_management plugin start contract.
I'm open to any ideas.

I think it's fine.

elasticmachine · 2025-09-19T09:53:52Z

Pinging @elastic/appex-ai-infra (Team:AI Infra)

github-actions · 2025-09-19T09:55:36Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

rbrtj · 2025-09-25T15:11:07Z

Damn.. I'm so sorry for all the pings, something went wrong 😅

…gs-page

qn895 · 2025-09-25T15:29:06Z

...gins/shared/ai_assistant_management/selection/public/components/navigation_control/index.tsx

+  triggerOpenChat: (event: { assistant: AIAssistantType }) => void;
+}
+
+export const AiAssistantHeaderButton: React.FC<AiAssistantHeaderButtonProps> = ({


super duper nit: Suggestion to make this consistent with the rest with AIAssistant... (so upper cased I and instead of lower-cased)

Updated in 21648e4

…gs-page

KDKHD · 2025-09-26T16:52:38Z

x-pack/platform/plugins/private/gen_ai_settings/public/components/gen_ai_settings_app.tsx

  async function handleSave() {
    try {
      await saveAll();
+      window.location.reload();


When registering the settings in the server-side plugin, there is a "requires reload" property. Can we set that property to true for the respective setting and then check Inside of useSettingsContext() > saveAll() if a reload is needed?

Good call, done in ff34021

KDKHD · 2025-09-26T16:55:22Z

...form/plugins/shared/ai_assistant_management/selection/server/src/settings/classic_setting.ts

+  readonly: true,
+  readonlyMode: 'ui',


Is readonly: true needed if you use readonlyMode:'ui'?

Yeah, it seems like we need both, otherwise it would show up in the Kibana Advanced Settings

KDKHD · 2025-09-26T16:58:06Z

...gins/shared/ai_assistant_management/selection/public/icons/assistant_icon/assistant_icon.tsx

+
+// TODO: This is duplicated code. It should be removed when the logo becomes available in EUI.
+
+const AssistantLogo = (props: React.SVGProps<SVGSVGElement>) => (


Assistant logo in shared component library: x-pack/platform/packages/shared/ai-assistant/icon/icon.tsx

I needed to use the logo in src/platform... (OSS), so I couldn't import it from x-pack. Ideally, the shared logo should live in the OSS code probably, but I wanted to avoid relocating it and updating all current imports in this PR.

…gs-page

KDKHD · 2025-09-29T08:49:44Z

I'm seeing a few small issues only after initially selecting the default assistant and before a page reload. Otherwise, all ok!

The assistant automatically opens every time I return to the Discover page. After page reload, this issue disappeared.

Screen.Recording.2025-09-29.at.09.19.40.mov

Even when I select "Security" as the default assistant the first time I open the assistant, if I go into GenAi settings, the setting still shows "Only in their own solutions". After page reload, the correct value is shown in the setting.

csr

src/platform/test/tsconfig.json LGTM 👍

jloleysens

Config changes LGTM. Thanks for testing on a serverless deployment as well!

…ount

rbrtj · 2025-09-29T13:27:23Z

I'm seeing a few small issues only after initially selecting the default assistant and before a page reload. Otherwise, all ok!

The assistant automatically opens every time I return to the Discover page. After page reload, this issue disappeared.

Screen.Recording.2025-09-29.at.09.19.40.mov
2. Even when I select "Security" as the default assistant the first time I open the assistant, if I go into GenAi settings, the setting still shows "Only in their own solutions". After page reload, the correct value is shown in the setting.

Thanks for catching that. The problem was the use of ReplaySubject for openChatTrigger. We need to persist the value with either ReplaySubject or BehaviorSubject because the appropriate assistants nav buttons are mounted after the observable emits a value. However, this causes the nav components to consume the persisted value on each re-mount (e.g., when navigating to other solution pages). To prevent this, I added a simple completeOpenChat function exposed from the management plugin. 7e8d819

I created a separate issue [AI Infra] GenAI Settings Page: AI Assistants Visibility setting doesn't reflect the option selected in the nav header #236804

…gs-page

elasticmachine · 2025-09-29T20:15:53Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 28fce07
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-233727-28fce075257d

Failed CI Steps

FTR Configs #104

Test Failures

[job] [logs] FTR Configs #104 / Endpoint plugin @ess @serverless @skipInServerlessMKI Endpoint execute response action "after all" hook for "should succeed with valid endpoint id, command and an optional timeout"

The CI Stats report is too large to be displayed here, check out the CI build annotation for this information.

History

💔 Build #345184 failed 20c834e
💔 Build #345128 failed de2d650
💔 Build #345033 failed 7e8d819
💔 Build #344781 failed fe04572
💚 Build #344154 succeeded 21648e4

cc @rbrtj

…Move the `AI Assistant visibility` setting to `GenAI Settings` page (#233727) Resolves #235602 This PR: * Moves the `AI Assistant Visibility` UI setting to `GenAI Settings` page. It disables the setting in Serverless and ECH Solution views. <img width="1096" height="713" alt="image" src="https://github.com/user-attachments/assets/5e8c7dce-13e5-44b4-81a5-cf3936a7ba5f" /> * Introduces a new navigation header selector for non-solution pages (Analytics, Stack Management), allowing users to choose which version of the Assistant they want to see. Based on their selection, the UI setting is updated, and the relevant Assistant window opens instantly. https://github.com/user-attachments/assets/8cc2644f-45e7-4200-b92f-df96ef827847 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

…Move the `AI Assistant visibility` setting to `GenAI Settings` page (elastic#233727) Resolves elastic#235602 This PR: * Moves the `AI Assistant Visibility` UI setting to `GenAI Settings` page. It disables the setting in Serverless and ECH Solution views. <img width="1096" height="713" alt="image" src="https://github.com/user-attachments/assets/5e8c7dce-13e5-44b4-81a5-cf3936a7ba5f" /> * Introduces a new navigation header selector for non-solution pages (Analytics, Stack Management), allowing users to choose which version of the Assistant they want to see. Based on their selection, the UI setting is updated, and the relevant Assistant window opens instantly. https://github.com/user-attachments/assets/8cc2644f-45e7-4200-b92f-df96ef827847 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

rbrtj added 6 commits September 1, 2025 14:45

Remove aiAssistantPreferredAIAssistantType setting from Observability…

f5da131

… AI Assistant Management

AI Assistant Visibility Setting in GenAI Settings page

ad54fb3

Hide AI Assistant Availability setting in Kibana -> Advanced Settings

97203c2

AI Assistants visible by default in serverless & space view

0f8eefc

Merge remote-tracking branch 'upstream/main' into move-ai-assistant-v…

371b79d

…isibility-to-genai-settings-page

Assistant solution selector

ae78ad0

rbrtj changed the title ~~Remove aiAssistantPreferredAIAssistantType setting from Observability…~~ Sep 19, 2025

remove comment leftover

6269fdd

rbrtj commented Sep 19, 2025

View reviewed changes

rbrtj changed the title ~~[AI Infra] Choose which AI Assistant to show in the Elastic Header~~ Sep 19, 2025

rbrtj self-assigned this Sep 19, 2025

rbrtj added backport:skip This PR does not require backporting release_note:feature Makes this part of the condensed release notes Team:AI Infra Platform AppEx AI Infrastructure Team t// v9.2.0 labels Sep 19, 2025

rbrtj marked this pull request as ready for review September 19, 2025 09:53

rbrtj requested review from a team as code owners September 19, 2025 09:53

adjust comment

0738e79

botelastic bot added the ci:project-deploy-observability Create an Observability project label Sep 19, 2025

rbrtj removed request for a team and paul-tavares September 25, 2025 15:10

Merge branch 'main' into move-ai-assistant-visibility-to-genai-settin…

fd3c61f

…gs-page

qn895 reviewed Sep 25, 2025

View reviewed changes

rbrtj and others added 2 commits September 26, 2025 09:09

Merge branch 'main' into move-ai-assistant-visibility-to-genai-settin…

891e944

…gs-page

Nav control consistent naming

21648e4

rbrtj requested a review from qn895 September 26, 2025 08:10

KDKHD reviewed Sep 26, 2025

View reviewed changes

rbrtj and others added 2 commits September 29, 2025 10:00

Enhance saveAll functionality to reload the page based on save results

ff34021

Merge branch 'main' into move-ai-assistant-visibility-to-genai-settin…

fe04572

…gs-page

rbrtj requested a review from KDKHD September 29, 2025 08:07

Dosant approved these changes Sep 29, 2025

View reviewed changes

KDKHD approved these changes Sep 29, 2025

View reviewed changes

csr approved these changes Sep 29, 2025

View reviewed changes

jloleysens approved these changes Sep 29, 2025

View reviewed changes

Prevent assistants window from opening on each nav link component rem…

7e8d819

…ount

rbrtj and others added 3 commits September 29, 2025 16:36

fix assistant provider test

de2d650

update limits

20c834e

Merge branch 'main' into move-ai-assistant-visibility-to-genai-settin…

28fce07

…gs-page

rbrtj merged commit 46d638c into elastic:main Sep 29, 2025
12 checks passed

rbrtj mentioned this pull request Oct 2, 2025

[Internal]: New AI section in Stack Management & AI assistant navigation header selector elastic/docs-content#3268

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AI Infra] Choose which AI Assistant to show in the Elastic Header & Move the `AI Assistant visibility` setting to `GenAI Settings` page#233727

[AI Infra] Choose which AI Assistant to show in the Elastic Header & Move the `AI Assistant visibility` setting to `GenAI Settings` page#233727
rbrtj merged 33 commits intoelastic:mainfrom
rbrtj:move-ai-assistant-visibility-to-genai-settings-page

rbrtj commented Sep 2, 2025 •

edited

Loading

rbrtj Sep 19, 2025 •

edited

Loading

neptunian Sep 22, 2025

elasticmachine commented Sep 19, 2025

github-actions bot commented Sep 19, 2025

rbrtj commented Sep 25, 2025

qn895 Sep 25, 2025

rbrtj Sep 26, 2025

KDKHD Sep 26, 2025

rbrtj Sep 29, 2025

KDKHD Sep 26, 2025

rbrtj Sep 29, 2025

KDKHD Sep 26, 2025

rbrtj Sep 29, 2025

KDKHD commented Sep 29, 2025 •

edited

Loading

csr left a comment

jloleysens left a comment •

edited

Loading

rbrtj commented Sep 29, 2025 •

edited

Loading

elasticmachine commented Sep 29, 2025 •

edited

Loading

Uh oh!

Labels

14 participants


		// TODO: This is duplicated code. It should be removed when the logo becomes available in EUI.

		const AssistantLogo = (props: React.SVGProps<SVGSVGElement>) => (

Conversation

rbrtj commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

rbrtj Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Sep 19, 2025

github-actions bot commented Sep 19, 2025

🤖 GitHub comments

rbrtj commented Sep 25, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KDKHD commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

csr left a comment

Choose a reason for hiding this comment

jloleysens left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

rbrtj commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

elasticmachine commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

History

Uh oh!

Labels

14 participants

rbrtj commented Sep 2, 2025 •

edited

Loading

rbrtj Sep 19, 2025 •

edited

Loading

KDKHD commented Sep 29, 2025 •

edited

Loading

jloleysens left a comment •

edited

Loading

rbrtj commented Sep 29, 2025 •

edited

Loading

elasticmachine commented Sep 29, 2025 •

edited

Loading