Fixes Save Modal promise chain onSave

[nickofthyme]

Summary

This PR fixes an issue in which the SO save modal in Lens, Dashboard and others, allowed the user to spam the save button, resulting in multiple saved instances.

Demo

Before

Zight.Recording.2025-09-03.at.12.08.19.PM.mp4

After

Zight.Recording.2025-09-03.at.03.54.03.PM.mp4

Fixes #233906

Details

When attempting to save any SO using the SavedObjectSaveModal, the logic was attempting to await the call to onSave and block any additional calls. This was working correctly to set the isLoading state, but the onSave callback is not expecting a Promise to be returned so it has no affect and the onSave is immediately resolved, unsetting the loading state and thus allowing multiple calls to save.

So the issue is that onSave should expect () => Promise<void> not () => void. A crude fix to this could be to throttle the calls to onSave and preventing and future clicks until the save is eventually complete. But if the save takes longer or fails this will enable the save button and allow clicking again, creating other possible issues and not solving the root of the problem.

So the chain of onSave is broken from calling it here to the eventual function up the call stack that is performing the save. This involves updating the chain of promised from the onSave prop all the way up to the root consumer, which is typically calling an async function.

Further complicating things.... there is this dreadful, I mean deprecated, showSaveModal function that wraps a modal component (almost like a HOC) and calls props.onSave of the passed component to determine the success state of the call to onSave.

kibana/src/platform/plugins/shared/saved_objects/public/save_modal/show_saved_object_save_modal.tsx

Lines 34 to 37 in 07cc9e9

	export function showSaveModal(
	saveModal: React.ReactElement<MinimalSaveModalProps>,
	Wrapper?: FC<PropsWithChildren<unknown>>
	) {

Here's a rough example...

import { showSaveModal } from "@kbn/saved-objects-plugin/public";

export function openSaveModal() {
  // ...

  showSaveModal(
    <SavedObjectSaveModal
      ...
      onSave={async () => {
        const response = await doTheSave();

        if(response.success) {
          return { id: response.id };
        } else {
          return { error: 'failed to save' }
        }
      }}
    />
  );
}

The strange thing is that the SavedObjectSaveModal.onSave doesn't need the SaveResult to be returned and these modal components are used in various places but only some are passed to showSaveModal.

So I cleaned up this code as well to expect the SaveResult when using showSaveModal and void otherwise.

Checklist

• Unit or functional tests were updated or added to match the most common scenarios
• This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
• The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
• Review the backport guidelines and apply applicable backport:* labels.

Release Notes

Fixes issue with save modal allowing duplicate saves of dashboard, visualizations and others.

[elasticmachine]

Pinging @elastic/kibana-visualizations (Team:Visualizations)

[davismcphee]

Code-only review, Data Discovery changes LGTM 👍 Thanks for fixing it! ...Although I'm not sure how I feel about my secret trick to saving multiple SOs being prevented now 🤔

[elasticmachine]

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

[elasticmachine]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 86b2407

Failed CI Steps

• FTR Configs #58

Test Failures

• [job] [logs] FTR Configs #58 / InfraOps App feature controls infrastructure security global infrastructure all privileges infrastructure landing page with data shows Wafflemap

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
presentationUtil	104	105	+1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
savedObjects	86	89	+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
aiops	517.9KB	517.9KB	+15.0B
dashboard	623.0KB	623.1KB	+28.0B
discover	1.1MB	1.1MB	+12.0B
graph	371.0KB	371.0KB	+23.0B
lens	1.5MB	1.5MB	+57.0B
links	100.7KB	100.7KB	+14.0B
maps	3.1MB	3.1MB	+14.0B
ml	5.4MB	5.4MB	+15.0B
presentationUtil	67.2KB	67.4KB	+201.0B
slo	974.2KB	974.2KB	+10.0B
synthetics	1.0MB	1.0MB	+5.0B
visualizations	351.5KB	351.5KB	+18.0B
total			+412.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
presentationUtil	8.2KB	8.3KB	+125.0B
savedObjects	10.5KB	10.6KB	+91.0B
total			+216.0B

Unknown metric groups

API count

id	before	after	diff
presentationUtil	106	108	+2
savedObjects	88	94	+6
total			+8

async chunk count

id	before	after	diff
presentationUtil	9	10	+1

ESLint disabled line counts

id	before	after	diff
presentationUtil	10	11	+1

References to deprecated APIs

id	before	after	diff
dashboard	5	13	+8
discover	5	9	+4
graph	44	48	+4
lens	4	6	+2
links	1	5	+4
maps	20	22	+2
presentationUtil	0	2	+2
visualizations	8	14	+6
total			+32

Total ESLint disabled count

id	before	after	diff
presentationUtil	10	11	+1

History

• 💔 Build #337011 failed 6ae2243
• 💛 Build #336051 was flaky 7d2c6fa
• 💚 Build #335955 succeeded 30cde21
• 💔 Build #335637 failed 857839d
• 💔 Build #335565 failed 1840b9d

[kibanamachine]

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/17564712467

[kibanamachine]

💔 All backports failed

Status	Branch	Result
❌	8.19	Backport failed because of merge conflicts
❌	9.1	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 233933

Questions ?

Please refer to the Backport tool documentation

[nickofthyme]

💚 All backports created successfully

Status	Branch	Result
✅	9.1
✅	8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

[kibanamachine]

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @nickofthyme

[kibanamachine]

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @nickofthyme

[kibanamachine]

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @nickofthyme