[dashboard as code] move visualize embeddable reference handling to server by nreese · Pull Request #234249 · elastic/kibana

nreese · 2025-09-07T20:58:14Z

PR moves visualize embeddable reference handling to the server.

dashboard CRUD APIs no longer contain references from visualize panels. In the screen shot below, notice how savedSearchId and index fields contain saved object ids and are not references. Notice how the reference array for the dashboard is empty.

References are extracted on server and stored in dashboard saved object. In the screen shot below, notice how savedSearchId has been replaced with savedSearchRefName and points to a reference that contains the saved objec tid. Notice how index has been replaced with indexRefName and points to a reference that contains the saved object id.

…ncementsOut functions from embeddable public and server start contracts

nreese · 2025-09-09T18:51:25Z

/ci

elasticmachine · 2025-09-10T14:13:02Z

Pinging @elastic/kibana-presentation (Team:Presentation)

elasticmachine · 2025-09-10T14:13:03Z

Pinging @elastic/kibana-visualizations (Team:Visualizations)

nreese · 2025-09-12T01:06:19Z

@elasticmachine merge upstream

nreese · 2025-09-15T14:17:52Z

@elasticmachine merge upstream

dej611 · 2025-09-16T14:51:05Z

src/platform/plugins/shared/visualizations/common/embeddable/transforms/get_transform_out.ts

+      };
+    }
+
+    throw new Error('Unable to inject references from Visualization state, unexpected state');


I faced this error when saving a new Visualize chart into a dashboard (chosing Add to New dashboard)

[2025-09-16T12:08:25.551+02:00][WARN ][plugins.dashboard] Unable to transform "visualization" embeddable state on read. Error: Unable to inject references from Visualization state, unexpected state

I get that with both a dataView or a saved search selected as data source.
No visible error on the chart

resolved in 580ccbf

The warnings where logged when opening the visualize save model. The save modal has a dashboard selector. The selections are populated by fetching the first 30 dashboards. Since these dashboards are read, their panel state is transformed. The warning was coming from "sample web logs dashboard". This dashboard has old state where "by-reference" saved object ids are saved outside of embeddable config. I updated the transforms to better handle this case.

Wait, why does it need to fetch the first 30 dashboards with all panels here?
Wouldn't be sufficient to fetch the same data as the Dashboard listing page?

Wait, why does it need to fetch the first 30 dashboards with all panels here?

I am not sure, that is just how the dashboards selector element is currently implemented. If you want to discuss that, we could open a separate issue since that is not related to this PR.

created #235377 to track dashboard selector optimizations

nreese · 2025-09-16T15:30:19Z

@elasticmachine merge upstream

elasticmachine · 2025-09-16T18:10:28Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 580ccbf

Failed CI Steps

FTR Configs #16

Test Failures

[job] [logs] FTR Configs #16 / InfraOps App feature controls infrastructure security global infrastructure all privileges infrastructure landing page with data shows Wafflemap

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`visualizations`	542	548	+6

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`visualizations`	838	836	-2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`maps`	3.1MB	3.1MB	-81.0B
`visualizations`	351.7KB	338.4KB	-13.3KB
total			-13.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`visualizations`	37.8KB	37.9KB	+124.0B

Unknown metric groups

API count

id	before	after	diff
`visualizations`	870	868	-2

async chunk count

id	before	after	diff
`visualizations`	18	17	-1

History

💛 Build #339424 was flaky 4a245c1
💚 Build #337818 succeeded cc745a8
💚 Build #337603 succeeded 207aa26
💔 Build #337549 failed 3b3fe6d

nreese · 2025-09-18T00:11:39Z

@elasticmachine merge upstream

dej611

Checked locally 👍

jsanz

Presentation team changes look good to me (code review)

…erver (elastic#234249) PR moves visualize embeddable reference handling to the server. dashboard CRUD APIs no longer contain references from visualize panels. In the screen shot below, notice how `savedSearchId` and `index` fields contain saved object ids and are not references. Notice how the reference array for the dashboard is empty. <img width="2047" height="1020" alt="Screenshot 2025-09-10 at 6 04 00 AM" src="https://github.com/user-attachments/assets/eb0671e8-5dec-4285-b20d-0a5928b0aa93" /> References are extracted on server and stored in dashboard saved object. In the screen shot below, notice how `savedSearchId` has been replaced with `savedSearchRefName` and points to a reference that contains the saved objec tid. Notice how `index` has been replaced with `indexRefName` and points to a reference that contains the saved object id. <img width="2045" height="1015" alt="Screenshot 2025-09-10 at 6 07 27 AM" src="https://github.com/user-attachments/assets/3442615d-d78d-4fc4-9980-073a7229ac30" /> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…erver (#234249) PR moves visualize embeddable reference handling to the server. dashboard CRUD APIs no longer contain references from visualize panels. In the screen shot below, notice how `savedSearchId` and `index` fields contain saved object ids and are not references. Notice how the reference array for the dashboard is empty. <img width="2047" height="1020" alt="Screenshot 2025-09-10 at 6 04 00 AM" src="https://github.com/user-attachments/assets/eb0671e8-5dec-4285-b20d-0a5928b0aa93" /> References are extracted on server and stored in dashboard saved object. In the screen shot below, notice how `savedSearchId` has been replaced with `savedSearchRefName` and points to a reference that contains the saved objec tid. Notice how `index` has been replaced with `indexRefName` and points to a reference that contains the saved object id. <img width="2045" height="1015" alt="Screenshot 2025-09-10 at 6 07 27 AM" src="https://github.com/user-attachments/assets/3442615d-d78d-4fc4-9980-073a7229ac30" /> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…erver (elastic#234249) PR moves visualize embeddable reference handling to the server. dashboard CRUD APIs no longer contain references from visualize panels. In the screen shot below, notice how `savedSearchId` and `index` fields contain saved object ids and are not references. Notice how the reference array for the dashboard is empty. <img width="2047" height="1020" alt="Screenshot 2025-09-10 at 6 04 00 AM" src="https://github.com/user-attachments/assets/eb0671e8-5dec-4285-b20d-0a5928b0aa93" /> References are extracted on server and stored in dashboard saved object. In the screen shot below, notice how `savedSearchId` has been replaced with `savedSearchRefName` and points to a reference that contains the saved objec tid. Notice how `index` has been replaced with `indexRefName` and points to a reference that contains the saved object id. <img width="2045" height="1015" alt="Screenshot 2025-09-10 at 6 07 27 AM" src="https://github.com/user-attachments/assets/3442615d-d78d-4fc4-9980-073a7229ac30" /> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…es lost when dashboard updated from listing page (#241893) Closes #241891 for 9.2 branch. Fix is same as #241381 althought the root cause is different. This regression is cause by moving reference handling to the server in [links](#228511), [maps](#234806), and [legacy vis](#234249)

nreese added 16 commits September 5, 2025 14:25

[dashboards as code] expose transformEnhancementsIn and transformEnha…

1e3f385

…ncementsOut functions from embeddable public and server start contracts

clean up

58aecf5

tslint and eslint

4cd22b9

fix exports

3cdb491

move extract embeddable references to common

c9cf462

transform types

c850a10

by ref transform in

050205b

by ref unit test

c1df8a7

by-value search source

3d7b186

replace savedSearchId with ref name

2dd2a84

stored vis types

3b19e18

transform out for by ref state

7bf22bb

injectVisReferences

8683b57

extractVisReferences to return savedVis

aaed8f0

by value transformOut

131af54

register transforms for visualize embeddable

29732c2

nreese mentioned this pull request Sep 8, 2025

[visualize embeddable] remove unused TSVB code path from serialize and deserialize methods #234347

Closed

nreese added 5 commits September 8, 2025 16:08

remove reference injection from deserializeState

bef69c6

remove reference extraction from serializeState

2478b6e

merge with main

ec1c253

reset changes in embeddable plugin

9bef088

reset embeddable plugin changes second try

0adb261

nreese mentioned this pull request Sep 9, 2025

visualize transforms #234220

Closed

nreese added 4 commits September 9, 2025 11:33

clean up save to library

9b82af6

migrate deserializeSavedVisState tests to injectVisReferences tests

a2fc95c

remove duplicated types

9ff0a9d

clean up

3b3fe6d

nreese added 2 commits September 9, 2025 12:57

clean up

5fdec4f

remove re-export of extractcontrols and extractTimeSeries

7801072

nreese requested a review from a team as a code owner September 10, 2025 14:12

Merge branch 'main' into vis_embeddable_transforms

7b47d6e

Merge branch 'main' into vis_embeddable_transforms

4a245c1

dej611 reviewed Sep 16, 2025

View reviewed changes

elasticmachine and others added 2 commits September 16, 2025 17:30

Merge branch 'main' into vis_embeddable_transforms

4d568a4

remove throw on not by value

580ccbf

nreese requested a review from a team as a code owner September 16, 2025 16:06

nreese requested a review from dej611 September 16, 2025 16:10

Merge branch 'main' into vis_embeddable_transforms

9d58e75

dej611 approved these changes Sep 19, 2025

View reviewed changes

jsanz approved these changes Sep 19, 2025

View reviewed changes

nreese merged commit 40c654a into elastic:main Sep 19, 2025
12 checks passed

nreese mentioned this pull request Nov 5, 2025

[dashboard][9.2] fix legacy visualize, links, and maps panel references lost when dashboard updated from listing page #241893

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dashboard as code] move visualize embeddable reference handling to server#234249

[dashboard as code] move visualize embeddable reference handling to server#234249
nreese merged 35 commits intoelastic:mainfrom
nreese:vis_embeddable_transforms

nreese commented Sep 7, 2025 •

edited

Loading

nreese commented Sep 9, 2025

elasticmachine commented Sep 10, 2025

elasticmachine commented Sep 10, 2025

nreese commented Sep 12, 2025

nreese commented Sep 15, 2025

dej611 Sep 16, 2025

nreese Sep 16, 2025 •

edited

Loading

dej611 Sep 17, 2025

nreese Sep 17, 2025

nreese Sep 17, 2025

nreese commented Sep 16, 2025

elasticmachine commented Sep 16, 2025

API count

async chunk count

nreese commented Sep 18, 2025

dej611 left a comment

jsanz left a comment

Uh oh!

Labels

4 participants

Conversation

nreese commented Sep 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

nreese commented Sep 9, 2025

elasticmachine commented Sep 10, 2025

elasticmachine commented Sep 10, 2025

nreese commented Sep 12, 2025

nreese commented Sep 15, 2025

dej611 Sep 16, 2025

Choose a reason for hiding this comment

nreese Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

dej611 Sep 17, 2025

Choose a reason for hiding this comment

nreese Sep 17, 2025

Choose a reason for hiding this comment

nreese Sep 17, 2025

Choose a reason for hiding this comment

nreese commented Sep 16, 2025

elasticmachine commented Sep 16, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

async chunk count

History

nreese commented Sep 18, 2025

dej611 left a comment

Choose a reason for hiding this comment

jsanz left a comment

Choose a reason for hiding this comment

Uh oh!

Labels

4 participants

nreese commented Sep 7, 2025 •

edited

Loading

nreese Sep 16, 2025 •

edited

Loading