[Discover] Enable Discover tabs by default by davismcphee · Pull Request #235150 · elastic/kibana

davismcphee · 2025-09-16T01:03:31Z

Summary

This PR enables tabs in Discover by default. We will still read from the feature flag to determine if they should be shown, but the default value will now be true.

Resolves #235204.

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
Flaky Test Runner was used on any tests changed
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
Review the backport guidelines and apply applicable backport:* labels.

Release note

You can now manage multiple data explorations simultaneously in Discover using tabs. Navigate between them seamlessly, duplicate them to build on previous queries, and save them into a single Discover session to retrieve your queries, filters, and data configurations untouched at a later time.

MiloszRadzynski · 2025-09-19T15:04:13Z

/ci

elasticmachine · 2025-09-29T14:57:24Z

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

kertal · 2025-09-30T07:26:39Z

/ci

jughosta

LGTM 👍

jughosta · 2025-09-30T08:04:38Z

+    // Push the selected tab ID to the URL, which creates a new browser history entry.
+    // This must be done before setting other URL state, which replace the history entry
+    // in order to avoid creating multiple browser history entries when switching tabs.
+    await tabsStorageManager.pushSelectedTabIdToUrl(selectedTab.id);


nit: pushSelectedTabIdToUrl is not behind the feature flag so it will add _tab to the URL when tabs are disabled.

jughosta · 2025-09-30T08:07:16Z

+    // This must be done before setting other URL state, which replace the history entry
+    // in order to avoid creating multiple browser history entries when switching tabs.
+    await tabsStorageManager.pushSelectedTabIdToUrl(selectedTab.id);
+


After saving a discover session, _tab gets lost from the URL. Created a separate issue for it #236882

elasticmachine · 2025-09-30T08:16:05Z

💔 Build Failed

Buildkite Build
Commit: 2f3ed9d

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #11 / Space awareness actions POST /agents/actions/{actionId}/cancel should return 404 if the action is in a different space
[job] [logs] FTR Configs #11 / Space awareness agents POST /agents/bulkUpdateAgentTags should only update tags of agents in the same space when passing a list of agent ids

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`discover`	159	160	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`discover`	1.2MB	1.2MB	+308.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`discover`	37	38	+1

Unknown metric groups

API count

id	before	after	diff
`discover`	210	211	+1

History

cc @davismcphee

## Summary This PR enables tabs in Discover by default. We will still read from the feature flag to determine if they should be shown, but the default value will now be `true`. Resolves elastic#235204. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ## Release note You can now manage multiple data explorations simultaneously in Discover using tabs. Navigate between them seamlessly, duplicate them to build on previous queries, and save them into a single Discover session to retrieve your queries, filters, and data configurations untouched at a later time. --------- Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>

- Closes #235320 ## Summary This PR updates the links which were created via Share functionality: - if it was one of tabs from a non-persisted discover session, the opened link will have a single tab with the label as before - if it was one of the saved tabs on a persisted session, the opened link will restore the persisted session tabs and preselect the same tab - if it was a new tab on a persisted session, the opened link will show the persisted session tabs + an appended shared tab with the label as before. Or all previous tabs if it's in the same session (if they are still in the local storage). To be merged after #235150 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: Davis McPhee <davismcphee@hotmail.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

- Closes elastic#235320 ## Summary This PR updates the links which were created via Share functionality: - if it was one of tabs from a non-persisted discover session, the opened link will have a single tab with the label as before - if it was one of the saved tabs on a persisted session, the opened link will restore the persisted session tabs and preselect the same tab - if it was a new tab on a persisted session, the opened link will show the persisted session tabs + an appended shared tab with the label as before. Or all previous tabs if it's in the same session (if they are still in the local storage). To be merged after elastic#235150 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: Davis McPhee <davismcphee@hotmail.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 8d7db59)

## Summary This PR enables tabs in Discover by default. We will still read from the feature flag to determine if they should be shown, but the default value will now be `true`. Resolves elastic#235204. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ## Release note You can now manage multiple data explorations simultaneously in Discover using tabs. Navigate between them seamlessly, duplicate them to build on previous queries, and save them into a single Discover session to retrieve your queries, filters, and data configurations untouched at a later time. --------- Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>

- Closes elastic#235320 ## Summary This PR updates the links which were created via Share functionality: - if it was one of tabs from a non-persisted discover session, the opened link will have a single tab with the label as before - if it was one of the saved tabs on a persisted session, the opened link will restore the persisted session tabs and preselect the same tab - if it was a new tab on a persisted session, the opened link will show the persisted session tabs + an appended shared tab with the label as before. Or all previous tabs if it's in the same session (if they are still in the local storage). To be merged after elastic#235150 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: Davis McPhee <davismcphee@hotmail.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

davismcphee self-assigned this Sep 16, 2025

davismcphee force-pushed the discover-enable-tabs branch 3 times, most recently from 560ee7e to 339f0d0 Compare September 24, 2025 17:07

davismcphee mentioned this pull request Sep 26, 2025

[Discover] [Unified Tabs] Tabs telemetry #234344

Merged

8 tasks

davismcphee force-pushed the discover-enable-tabs branch from 4977c83 to 84ad0e6 Compare September 26, 2025 20:32

davismcphee added 12 commits September 29, 2025 11:16

Enable Discover tabs by default

182a3e5

Hardcode tabs enabled

75e803f

Update default tabs feature flag value for background search

692223d

Fix a11y test

a9e44ba

Fix browser history navigation for tabs

4d60478

Fix app wrapper tests

28ad7bd

Fix resizable layout tests

09240b0

Fix comparison tests

f7c1e14

Fix Jest tests

3542da2

Fix missing location state

fe83d11

Fix URL state tests

cc3a7fb

Fix test failures

19d8082

davismcphee force-pushed the discover-enable-tabs branch from 84ad0e6 to 19d8082 Compare September 29, 2025 14:32

Add tabs feature flag back with true as default

2003074

davismcphee marked this pull request as ready for review September 29, 2025 14:57

davismcphee requested review from a team as code owners September 29, 2025 14:57

nickofthyme approved these changes Sep 29, 2025

View reviewed changes

jughosta mentioned this pull request Sep 29, 2025

[Discover Tabs] Sharing the selected tab fix #236129

Merged

4 tasks

davismcphee added 3 commits September 29, 2025 17:11

Merge branch 'main' into discover-enable-tabs

77cd105

Merge branch 'main' into discover-enable-tabs

12d85cb

Merge branch 'main' into discover-enable-tabs

52b6486

Merge branch 'main' into discover-enable-tabs

2f3ed9d

jughosta mentioned this pull request Sep 30, 2025

[Discover Tabs] Make sure that the selected tab is still present in URL _tab after saving a discover session #236882

Closed

jughosta approved these changes Sep 30, 2025

View reviewed changes

jughosta enabled auto-merge (squash) September 30, 2025 08:35

jughosta merged commit 7108aef into elastic:main Sep 30, 2025
12 checks passed

kibanamachine added the v9.2.0 label Sep 30, 2025

pheyos mentioned this pull request Oct 1, 2025

failsOnMKI: serverless Discover URL state tests #237086

Open

florent-leborgne added the needs_docs label Oct 2, 2025

florent-leborgne mentioned this pull request Oct 2, 2025

[Discover] Discover tabs elastic/docs-content#3145

Closed

davismcphee deleted the discover-enable-tabs branch December 1, 2025 14:12

Copilot AI mentioned this pull request Apr 14, 2026

Re-enable MKI coverage for serverless Discover URL state tests #263223

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Discover] Enable Discover tabs by default#235150

[Discover] Enable Discover tabs by default#235150
jughosta merged 17 commits intoelastic:mainfrom
davismcphee:discover-enable-tabs

davismcphee commented Sep 16, 2025 •

edited by florent-leborgne

Loading

MiloszRadzynski commented Sep 19, 2025

elasticmachine commented Sep 29, 2025

kertal commented Sep 30, 2025

jughosta left a comment

jughosta Sep 30, 2025

jughosta Sep 30, 2025

elasticmachine commented Sep 30, 2025 •

edited

Loading

API count

Uh oh!

Labels

8 participants

Conversation

davismcphee commented Sep 16, 2025 • edited by florent-leborgne Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Release note

MiloszRadzynski commented Sep 19, 2025

elasticmachine commented Sep 29, 2025

kertal commented Sep 30, 2025

jughosta left a comment

Choose a reason for hiding this comment

jughosta Sep 30, 2025

Choose a reason for hiding this comment

jughosta Sep 30, 2025

Choose a reason for hiding this comment

elasticmachine commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Public APIs missing comments

Async chunks

Public APIs missing exports

API count

History

Uh oh!

Labels

8 participants

davismcphee commented Sep 16, 2025 •

edited by florent-leborgne

Loading

elasticmachine commented Sep 30, 2025 •

edited

Loading