[ML][AI Connector] Adds a default placeholder icon for future AI connectors#235166
Merged
KodeRad merged 7 commits intoelastic:mainfrom Sep 19, 2025
Merged
[ML][AI Connector] Adds a default placeholder icon for future AI connectors#235166KodeRad merged 7 commits intoelastic:mainfrom
KodeRad merged 7 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/ml-ui (:ml) |
12 tasks
peteharverson
approved these changes
Sep 17, 2025
Contributor
peteharverson
left a comment
There was a problem hiding this comment.
Tested and LGTM. Just left one comment.
| import deepSeekIcon from '../assets/images/deepseek.svg'; | ||
| import ai21Icon from '../assets/images/ai21_labs_default.svg'; | ||
| import llamaIcon from '../assets/images/llama_stack_default.svg'; | ||
| import default_icon from '../assets/images/default_connector_icon.svg'; |
Contributor
There was a problem hiding this comment.
Nit - why not camel case defaultIcon for consistency with the others?
Member
There was a problem hiding this comment.
There is a linting rule about file names needing to be snake_case, but I agree that we should be consistent with the other names so it'd be ok to ignore the rule for this file.
Contributor
Author
There was a problem hiding this comment.
That's right. For the consistency it's better to change it as the rest. Fixed here: 7329849
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Module Count
Async chunks
History
cc @KodeRad |
1 task
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Sep 24, 2025
…ctors (elastic#235166) ## Summary Implements [elastic#233668](elastic#233668) In case backend adds new AI connector it will be displayed with a default placeholder icon instead without any. Additionaly, it now highlights new providers when searched for them in the list. Just like the others. To test it I deleted `alibabacloud-ai-search` connector from `SERVICE_PROVIDERS` imitating the situation where the new provider was added. ### Screenshots before <img width="984" height="1298" alt="Screenshot 2025-09-15 at 15 37 03" src="https://github.com/user-attachments/assets/7b85b316-5bf8-45a1-8e63-ec925f8d492f" /> <img width="736" height="1122" alt="Screenshot 2025-09-15 at 15 37 23" src="https://github.com/user-attachments/assets/d25c30cb-3f49-45e2-983a-f4a7cd383ade" /> ### Screenshots after <img width="989" height="575" alt="Screenshot 2025-09-16 at 16 38 08" src="https://github.com/user-attachments/assets/2d211a65-27d4-45f1-bf9e-878308e196de" /> <img width="984" height="843" alt="Screenshot 2025-09-16 at 16 38 35" src="https://github.com/user-attachments/assets/22918985-b2a7-4f44-9d66-0b5d453c70f6" /> ### Highlight searched names (mind that recording has old greyed-out icon) https://github.com/user-attachments/assets/4c14fef8-c1a3-4dbd-9780-f99073a8bfb2 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...
niros1
pushed a commit
that referenced
this pull request
Sep 30, 2025
…ctors (#235166) ## Summary Implements [#233668](#233668) In case backend adds new AI connector it will be displayed with a default placeholder icon instead without any. Additionaly, it now highlights new providers when searched for them in the list. Just like the others. To test it I deleted `alibabacloud-ai-search` connector from `SERVICE_PROVIDERS` imitating the situation where the new provider was added. ### Screenshots before <img width="984" height="1298" alt="Screenshot 2025-09-15 at 15 37 03" src="https://github.com/user-attachments/assets/7b85b316-5bf8-45a1-8e63-ec925f8d492f" /> <img width="736" height="1122" alt="Screenshot 2025-09-15 at 15 37 23" src="https://github.com/user-attachments/assets/d25c30cb-3f49-45e2-983a-f4a7cd383ade" /> ### Screenshots after <img width="989" height="575" alt="Screenshot 2025-09-16 at 16 38 08" src="https://github.com/user-attachments/assets/2d211a65-27d4-45f1-bf9e-878308e196de" /> <img width="984" height="843" alt="Screenshot 2025-09-16 at 16 38 35" src="https://github.com/user-attachments/assets/22918985-b2a7-4f44-9d66-0b5d453c70f6" /> ### Highlight searched names (mind that recording has old greyed-out icon) https://github.com/user-attachments/assets/4c14fef8-c1a3-4dbd-9780-f99073a8bfb2 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...
rylnd
pushed a commit
to rylnd/kibana
that referenced
this pull request
Oct 17, 2025
…ctors (elastic#235166) ## Summary Implements [elastic#233668](elastic#233668) In case backend adds new AI connector it will be displayed with a default placeholder icon instead without any. Additionaly, it now highlights new providers when searched for them in the list. Just like the others. To test it I deleted `alibabacloud-ai-search` connector from `SERVICE_PROVIDERS` imitating the situation where the new provider was added. ### Screenshots before <img width="984" height="1298" alt="Screenshot 2025-09-15 at 15 37 03" src="https://github.com/user-attachments/assets/7b85b316-5bf8-45a1-8e63-ec925f8d492f" /> <img width="736" height="1122" alt="Screenshot 2025-09-15 at 15 37 23" src="https://github.com/user-attachments/assets/d25c30cb-3f49-45e2-983a-f4a7cd383ade" /> ### Screenshots after <img width="989" height="575" alt="Screenshot 2025-09-16 at 16 38 08" src="https://github.com/user-attachments/assets/2d211a65-27d4-45f1-bf9e-878308e196de" /> <img width="984" height="843" alt="Screenshot 2025-09-16 at 16 38 35" src="https://github.com/user-attachments/assets/22918985-b2a7-4f44-9d66-0b5d453c70f6" /> ### Highlight searched names (mind that recording has old greyed-out icon) https://github.com/user-attachments/assets/4c14fef8-c1a3-4dbd-9780-f99073a8bfb2 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #233668
In case backend adds new AI connector it will be displayed with a default placeholder icon instead without any.
Additionaly, it now highlights new providers when searched for them in the list. Just like the others.
To test it I deleted
alibabacloud-ai-searchconnector fromSERVICE_PROVIDERSimitating the situation where the new provider was added.Screenshots before
Screenshots after
Highlight searched names (mind that recording has old greyed-out icon)
highlight.mp4
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.