[UII] Add "Only agentless integrations" filter to integrations browse experience#235686
Conversation
|
Pinging @elastic/fleet (Team:Fleet) |
MichelLosier
left a comment
There was a problem hiding this comment.
Looking good so far, but it seems though the filtering is not aligning with the agentless check in deployment_modes. For example, when I have the agentless only filter on, I can still select the AWS ECS integration which doesn't support it.
Ah nice catch! I need to apply this filtering at the card level instead of at the package level. Taking a look. |
| <FormattedMessage | ||
| id="xpack.fleet.epm.agentlessFilter.label" | ||
| defaultMessage="Only agentless integrations" | ||
| /> | ||
| | ||
| <EuiIconTip | ||
| content={ | ||
| <FormattedMessage | ||
| id="xpack.fleet.epm.agentlessFilter.tooltip" | ||
| defaultMessage="Agentless integrations run in Elastic Cloud without requiring you to deploy Elastic Agents" | ||
| /> |
There was a problem hiding this comment.
@vishaangelova @karenzone any suggestions for improve the copy here or is it ok?
There was a problem hiding this comment.
For the filter: "Only agentless integrations"
If this format (starting with Only) matches wording for other filters. then 👍 .
For the message: "Agentless integrations run in Elastic Cloud without requiring you to deploy Elastic Agents"
We're using "Elastic Cloud Hosted" as the official platform name in docs, but shortening here might make sense. Are Agentless integrations available for Serverless?
There was a problem hiding this comment.
If this format (starting with Only) matches wording for other filters. then 👍
we don't really have other similar filters. there is a similar toggle right below this one that says Display beta integrations, but that behaves differently (enabling it doesn't "only" show beta ones)
Are Agentless integrations available for Serverless?
yes they are! that's the reason why I chose Elastic Cloud since I believe that term covers both hosted + serverless?
There was a problem hiding this comment.
Fantastic on Hosted+Serverless. Makes sense. 👍
Filtering implies that a user is limiting or expanding their view based on other options selected. If a user selects only one category--like Agentless integrations--the "only" is implied.
In a filtering context, it seems that removing the word "only" makes sense. I'm interested to hear what you and others think.
There was a problem hiding this comment.
🤔 I see on the screenshots in the PR that these two toggles (Only agentless integrations and Display beta integrations) are meant to extend the filtering by category, so they enhance the filtering options: if you want to see the beta integrations, you enable the toggle. If you want to see only agentless integrations from a category, you enable the Only agentless integrations, right?
Personally, I think having only in the wording makes sense, and makes the functionality explicit, easy to understand. Without only I’m left to wonder whether it works as the Display beta integrations toggle - if I enable it, will it show the agentless integrations alongside the rest? Without only in the wording, I’d also expect that the default behavior is to not show the agentless integrations (similar to the beta integrations).
I also feel that having a verb such as Show or Display at the beginning would be nice - it would also be consistent in format with the Display beta integrations toggle. But at the same time, I’m conscious of the space used, so having Display only agentless integrations might be too long. If the latter is the case, I’d stick with Only agentless integrations.
There was a problem hiding this comment.
thanks for the feedback @karenzone and @vishaangelova! (Visha, you hit the nail on the head about my conundrum with the behavior and copy)
I am going to merge this PR and leave the copy as it is for the above reasons, and also soon the entire filter experience here will be revamped and these confusing toggles will be replaced in favor of a "tag"-style filter UX: https://github.com/elastic/ingest-dev/issues/4789
|
@MichelLosier Fixed the filtering at the card level and updated the screenshots in this PR. This reduced the number of integrations from 90-something to 70ish. I assume most were non-agentless AWS ones like you mentioned :) |
MichelLosier
left a comment
There was a problem hiding this comment.
LGTM!
I think the type check failure is just the state of main at the moment
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
cc @jen-huang |
… experience (elastic#235686) ## Summary Resolves elastic/ingest-dev#5931. This PR adds a new toggle to Integrations browse page that only shows agentless integrations. A query param `?onlyAgentless=true` is added if this toggle is enabled. This toggle appears only if agentless is available for the deployment. It is placed above the existing show beta integrations toggle. Default enabled view: <img width="1988" height="1222" alt="image" src="https://github.com/user-attachments/assets/78f890aa-fa5a-4ce9-9ffb-82c5018c7627" /> Persistence across deep filtering (with categories and search): <img width="1987" height="970" alt="image" src="https://github.com/user-attachments/assets/0ee0815e-5b55-40ec-9fc2-2c0ea13d7dd4" /> ## Release note Added new filter to only show agentless integrations. ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
… experience (#235686) ## Summary Resolves elastic/ingest-dev#5931. This PR adds a new toggle to Integrations browse page that only shows agentless integrations. A query param `?onlyAgentless=true` is added if this toggle is enabled. This toggle appears only if agentless is available for the deployment. It is placed above the existing show beta integrations toggle. Default enabled view: <img width="1988" height="1222" alt="image" src="https://github.com/user-attachments/assets/78f890aa-fa5a-4ce9-9ffb-82c5018c7627" /> Persistence across deep filtering (with categories and search): <img width="1987" height="970" alt="image" src="https://github.com/user-attachments/assets/0ee0815e-5b55-40ec-9fc2-2c0ea13d7dd4" /> ## Release note Added new filter to only show agentless integrations. ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
… experience (elastic#235686) ## Summary Resolves https://github.com/elastic/ingest-dev/issues/5931. This PR adds a new toggle to Integrations browse page that only shows agentless integrations. A query param `?onlyAgentless=true` is added if this toggle is enabled. This toggle appears only if agentless is available for the deployment. It is placed above the existing show beta integrations toggle. Default enabled view: <img width="1988" height="1222" alt="image" src="https://github.com/user-attachments/assets/78f890aa-fa5a-4ce9-9ffb-82c5018c7627" /> Persistence across deep filtering (with categories and search): <img width="1987" height="970" alt="image" src="https://github.com/user-attachments/assets/0ee0815e-5b55-40ec-9fc2-2c0ea13d7dd4" /> ## Release note Added new filter to only show agentless integrations. ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
Summary
Resolves https://github.com/elastic/ingest-dev/issues/5931. This PR adds a new toggle to Integrations browse page that only shows agentless integrations. A query param
?onlyAgentless=trueis added if this toggle is enabled.This toggle appears only if agentless is available for the deployment. It is placed above the existing show beta integrations toggle.
Default enabled view:

Persistence across deep filtering (with categories and search):

Release note
Added new filter to only show agentless integrations.
Checklist
release_note:*label is applied per the guidelinesbackport:*labels.