[Cases] Separate sync alert and auto-extract updates in activity#236519
Merged
christineweng merged 3 commits intoelastic:mainfrom Oct 14, 2025
Merged
[Cases] Separate sync alert and auto-extract updates in activity#236519christineweng merged 3 commits intoelastic:mainfrom
christineweng merged 3 commits intoelastic:mainfrom
Conversation
eaaacf5 to
47753a1
Compare
Contributor
|
Pinging @elastic/kibana-cases (Team:Cases) |
janmonschke
reviewed
Oct 14, 2025
| ); | ||
|
|
||
| // Join labels with "and" if multiple, or return single label | ||
| return labels.length > 1 ? labels.join(' and ') : labels[0] || ''; |
Contributor
There was a problem hiding this comment.
Concatenating these labels with and will break translations. Imagine each label is translated to another language (e.g. Spanish) and then they're concatenated with and.
I would recommend, adding another set of labels here, or concatenating with e.g. , or &
janmonschke
approved these changes
Oct 14, 2025
Contributor
|
Starting backport for target branches: 9.2 |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2025
…stic#236519) ## Summary Ref: elastic#236493 When sync alert or auto-extract toggle was turned on/off, both settings are mentioned in the activity log. This PR added additional logic in user action builder to compare before/after values, and sends the correct payload to user action. Before <img width="715" height="185" alt="image" src="https://github.com/user-attachments/assets/37dc0b5f-ab7b-4163-b00d-d6e74f4f6af7" /> After <img width="565" height="192" alt="image" src="https://github.com/user-attachments/assets/7d7aff13-78bc-4f93-8676-0d7baa13cf3e" /> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit fca6120)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 14, 2025
#236519) (#238976) # Backport This will backport the following commits from `main` to `9.2`: - [[Cases] Separate sync alert and auto-extract updates in activity (#236519)](#236519) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"18648970+christineweng@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-10-14T16:30:11Z","message":"[Cases] Separate sync alert and auto-extract updates in activity (#236519)\n\n## Summary\n\nRef: https://github.com/elastic/kibana/issues/236493\n\nWhen sync alert or auto-extract toggle was turned on/off, both settings\nare mentioned in the activity log. This PR added additional logic in\nuser action builder to compare before/after values, and sends the\ncorrect payload to user action.\n\nBefore\n<img width=\"715\" height=\"185\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/37dc0b5f-ab7b-4163-b00d-d6e74f4f6af7\"\n/>\n\nAfter\n<img width=\"565\" height=\"192\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/7d7aff13-78bc-4f93-8676-0d7baa13cf3e\"\n/>\n\n\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"fca612083454b5f784805485b019f52c8bc81161","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:version","Team:Cases","v9.2.0","v9.3.0"],"title":"[Cases] Separate sync alert and auto-extract updates in activity","number":236519,"url":"https://github.com/elastic/kibana/pull/236519","mergeCommit":{"message":"[Cases] Separate sync alert and auto-extract updates in activity (#236519)\n\n## Summary\n\nRef: https://github.com/elastic/kibana/issues/236493\n\nWhen sync alert or auto-extract toggle was turned on/off, both settings\nare mentioned in the activity log. This PR added additional logic in\nuser action builder to compare before/after values, and sends the\ncorrect payload to user action.\n\nBefore\n<img width=\"715\" height=\"185\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/37dc0b5f-ab7b-4163-b00d-d6e74f4f6af7\"\n/>\n\nAfter\n<img width=\"565\" height=\"192\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/7d7aff13-78bc-4f93-8676-0d7baa13cf3e\"\n/>\n\n\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"fca612083454b5f784805485b019f52c8bc81161"}},"sourceBranch":"main","suggestedTargetBranches":["9.2"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/236519","number":236519,"mergeCommit":{"message":"[Cases] Separate sync alert and auto-extract updates in activity (#236519)\n\n## Summary\n\nRef: https://github.com/elastic/kibana/issues/236493\n\nWhen sync alert or auto-extract toggle was turned on/off, both settings\nare mentioned in the activity log. This PR added additional logic in\nuser action builder to compare before/after values, and sends the\ncorrect payload to user action.\n\nBefore\n<img width=\"715\" height=\"185\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/37dc0b5f-ab7b-4163-b00d-d6e74f4f6af7\"\n/>\n\nAfter\n<img width=\"565\" height=\"192\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/7d7aff13-78bc-4f93-8676-0d7baa13cf3e\"\n/>\n\n\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"fca612083454b5f784805485b019f52c8bc81161"}}]}] BACKPORT--> Co-authored-by: christineweng <18648970+christineweng@users.noreply.github.com>
ersin-erdal
pushed a commit
to ersin-erdal/kibana
that referenced
this pull request
Oct 15, 2025
…stic#236519) ## Summary Ref: elastic#236493 When sync alert or auto-extract toggle was turned on/off, both settings are mentioned in the activity log. This PR added additional logic in user action builder to compare before/after values, and sends the correct payload to user action. Before <img width="715" height="185" alt="image" src="https://github.com/user-attachments/assets/37dc0b5f-ab7b-4163-b00d-d6e74f4f6af7" /> After <img width="565" height="192" alt="image" src="https://github.com/user-attachments/assets/7d7aff13-78bc-4f93-8676-0d7baa13cf3e" /> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
mgadewoll
pushed a commit
to tkajtoch/kibana
that referenced
this pull request
Oct 17, 2025
…stic#236519) ## Summary Ref: elastic#236493 When sync alert or auto-extract toggle was turned on/off, both settings are mentioned in the activity log. This PR added additional logic in user action builder to compare before/after values, and sends the correct payload to user action. Before <img width="715" height="185" alt="image" src="https://github.com/user-attachments/assets/37dc0b5f-ab7b-4163-b00d-d6e74f4f6af7" /> After <img width="565" height="192" alt="image" src="https://github.com/user-attachments/assets/7d7aff13-78bc-4f93-8676-0d7baa13cf3e" /> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
rylnd
pushed a commit
to rylnd/kibana
that referenced
this pull request
Oct 17, 2025
…stic#236519) ## Summary Ref: elastic#236493 When sync alert or auto-extract toggle was turned on/off, both settings are mentioned in the activity log. This PR added additional logic in user action builder to compare before/after values, and sends the correct payload to user action. Before <img width="715" height="185" alt="image" src="https://github.com/user-attachments/assets/37dc0b5f-ab7b-4163-b00d-d6e74f4f6af7" /> After <img width="565" height="192" alt="image" src="https://github.com/user-attachments/assets/7d7aff13-78bc-4f93-8676-0d7baa13cf3e" /> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
nickpeihl
pushed a commit
to nickpeihl/kibana
that referenced
this pull request
Oct 23, 2025
…stic#236519) ## Summary Ref: elastic#236493 When sync alert or auto-extract toggle was turned on/off, both settings are mentioned in the activity log. This PR added additional logic in user action builder to compare before/after values, and sends the correct payload to user action. Before <img width="715" height="185" alt="image" src="https://github.com/user-attachments/assets/37dc0b5f-ab7b-4163-b00d-d6e74f4f6af7" /> After <img width="565" height="192" alt="image" src="https://github.com/user-attachments/assets/7d7aff13-78bc-4f93-8676-0d7baa13cf3e" /> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Oct 27, 2025
…stic#236519) ## Summary Ref: elastic#236493 When sync alert or auto-extract toggle was turned on/off, both settings are mentioned in the activity log. This PR added additional logic in user action builder to compare before/after values, and sends the correct payload to user action. Before <img width="715" height="185" alt="image" src="https://github.com/user-attachments/assets/37dc0b5f-ab7b-4163-b00d-d6e74f4f6af7" /> After <img width="565" height="192" alt="image" src="https://github.com/user-attachments/assets/7d7aff13-78bc-4f93-8676-0d7baa13cf3e" /> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ref: #236493
When sync alert or auto-extract toggle was turned on/off, both settings are mentioned in the activity log. This PR added additional logic in user action builder to compare before/after values, and sends the correct payload to user action.
Before

After

Checklist
release_note:*label is applied per the guidelinesbackport:*labels.