[Cases] - Connector api update by michaelolo24 · Pull Request #236863 · elastic/kibana

michaelolo24 · 2025-09-30T04:20:30Z

Summary

This PR isolates the configuration paramaeters for the tines connector to the server side

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Unit or functional tests were updated or added to match the most common scenarios

kibanamachine · 2025-10-01T02:15:42Z

Cloud deployments require a Github label, please add ci:cloud-deploy or ci:cloud-redeploy and trigger the job through the checkbox again.

elasticmachine · 2025-10-08T02:46:55Z

Pinging @elastic/kibana-cases (Team:Cases)

x-pack/platform/plugins/shared/stack_connectors/public/connector_types/tines/tines.ts

x-pack/platform/plugins/shared/stack_connectors/common/tines/schema.ts

adcoelho · 2025-10-08T07:35:28Z

...m/test/alerting_api_integration/common/plugins/actions_simulators/server/tines_simulation.ts

    } else if (request.url?.match('/webhook')) {
      body = tinesWebhookSuccessResponse;
+    } else if (request.url?.match('/actions/1')) {
+      body = tinesAgentWebhook;


Shouldn't this be body = tinesAgentsResponse;? I think the return type is TinesWebhookApiResponse.

No. I should probably update the naming to be clearer, but your return type is right TinesWebhookApiResponse, but the one for tinesAgentsResponse is TinesWebhook[s]ApiResponse, the latter returns an array, where as the former returns only a single agent. 😅

elasticmachine · 2025-10-13T05:05:57Z

💚 Build Succeeded

Buildkite Build
Commit: 5c0ce5f

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`stackConnectors`	66.8KB	66.6KB	-188.0B

Unknown metric groups

References to deprecated APIs

id	before	after	diff
`@kbn/test-suites-xpack-platform`	72	73	+1

History

semd

LGTM
This is great 💯 Thanks Mike!

I leave a small NIT

semd · 2025-10-14T13:48:21Z

x-pack/platform/plugins/shared/stack_connectors/server/connector_types/tines/tines.ts

+    (webhooks, { id, type, name, story_id: storyId }) => {
      if (type === WEBHOOK_AGENT_TYPE) {
-        webhooks.push({ id, name, path, secret, storyId });
+        webhooks.push({ id, name, storyId });


NIT: We could just map here because now we pass the action_type: WEBHOOK_AGENT_TYPE param to the webhooks request (😍 love it), so we don't strictly need to filter by type anymore. It does not hurt either though if you want to keep it 👍

true 👍🏾 . Will make a small follow up PR to remove the check, thanks!

kibanamachine · 2025-10-14T14:16:14Z

Starting backport for target branches: 8.18, 8.19, 9.1, 9.2

https://github.com/elastic/kibana/actions/runs/18499549924

## Summary This PR isolates the configuration paramaeters for the tines connector to the server side ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 55cb4b5)

kibanamachine · 2025-10-14T14:24:26Z

💚 All backports created successfully

Status	Branch	Result
✅	8.18
✅	8.19
✅	9.1
✅	9.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

# Backport This will backport the following commits from `main` to `8.19`: - [[Cases] - Connector api update (#236863)](#236863)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>

# Backport This will backport the following commits from `main` to `9.1`: - [[Cases] - Connector api update (#236863)](#236863)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>

# Backport This will backport the following commits from `main` to `8.18`: - [[Cases] - Connector api update (#236863)](#236863)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>

# Backport This will backport the following commits from `main` to `9.2`: - [[Cases] - Connector api update (#236863)](#236863)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>

## Summary This PR isolates the configuration paramaeters for the tines connector to the server side ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

michaelolo24 added bug Fixes for quality problems that affect the customer experience Team:Cases Security Solution Cases team v9.2.0 labels Sep 30, 2025

michaelolo24 force-pushed the connector-config-refactor branch from c17c44c to 58ca064 Compare October 1, 2025 02:08

michaelolo24 added backport:all-open Backport to all branches that could still receive a release release_note:fix labels Oct 1, 2025

michaelolo24 force-pushed the connector-config-refactor branch from 771a762 to 4ca56f4 Compare October 8, 2025 02:46

michaelolo24 marked this pull request as ready for review October 8, 2025 02:46

michaelolo24 requested a review from a team as a code owner October 8, 2025 02:46

michaelolo24 requested a review from semd October 8, 2025 02:47

michaelolo24 added v9.1.6 v8.18.9 v8.19.6 backport:version Backport to applied version labels and removed backport:all-open Backport to all branches that could still receive a release labels Oct 8, 2025

adcoelho reviewed Oct 8, 2025

View reviewed changes

x-pack/platform/plugins/shared/stack_connectors/public/connector_types/tines/tines.ts Show resolved Hide resolved

adcoelho reviewed Oct 8, 2025

View reviewed changes

x-pack/platform/plugins/shared/stack_connectors/common/tines/schema.ts Show resolved Hide resolved

adcoelho reviewed Oct 8, 2025

View reviewed changes

michaelolo24 added 4 commits October 10, 2025 21:08

add separate api call for connector config

58a9f1e

fix test pt1

fbe3f39

minor cleanup

0e27ed5

fix last group of tests

48e068a

michaelolo24 force-pushed the connector-config-refactor branch from b8f36b0 to 48e068a Compare October 11, 2025 01:08

michaelolo24 added 2 commits October 10, 2025 22:17

remove unnecessary check

16d298a

Merge branch 'main' into connector-config-refactor

5c0ce5f

adcoelho approved these changes Oct 14, 2025

View reviewed changes

semd approved these changes Oct 14, 2025

View reviewed changes

michaelolo24 merged commit 55cb4b5 into elastic:main Oct 14, 2025
12 checks passed

kibanamachine added the v9.3.0 label Oct 14, 2025

kibanamachine mentioned this pull request Oct 14, 2025

[8.18] [Cases] - Connector api update (#236863) #238908

Merged

kibanamachine mentioned this pull request Oct 14, 2025

[8.19] [Cases] - Connector api update (#236863) #238909

Merged

kibanamachine mentioned this pull request Oct 14, 2025

[9.1] [Cases] - Connector api update (#236863) #238910

Merged

kibanamachine mentioned this pull request Oct 14, 2025

[9.2] [Cases] - Connector api update (#236863) #238911

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cases] - Connector api update#236863

[Cases] - Connector api update#236863
michaelolo24 merged 6 commits intoelastic:mainfrom
michaelolo24:connector-config-refactor

michaelolo24 commented Sep 30, 2025 •

edited by kibanamachine

Loading

kibanamachine commented Oct 1, 2025

elasticmachine commented Oct 8, 2025

Uh oh!

Uh oh!

adcoelho Oct 8, 2025

michaelolo24 Oct 11, 2025

elasticmachine commented Oct 13, 2025

References to deprecated APIs

semd left a comment

semd Oct 14, 2025

michaelolo24 Oct 14, 2025

Uh oh!

kibanamachine commented Oct 14, 2025

kibanamachine commented Oct 14, 2025

Labels

5 participants

Conversation

michaelolo24 commented Sep 30, 2025 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

kibanamachine commented Oct 1, 2025

elasticmachine commented Oct 8, 2025

Uh oh!

Uh oh!

adcoelho Oct 8, 2025

Choose a reason for hiding this comment

michaelolo24 Oct 11, 2025

Choose a reason for hiding this comment

elasticmachine commented Oct 13, 2025

💚 Build Succeeded

Metrics [docs]

Page load bundle

References to deprecated APIs

History

semd left a comment

Choose a reason for hiding this comment

semd Oct 14, 2025

Choose a reason for hiding this comment

michaelolo24 Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Oct 14, 2025

kibanamachine commented Oct 14, 2025

💚 All backports created successfully

Questions ?

Labels

5 participants

michaelolo24 commented Sep 30, 2025 •

edited by kibanamachine

Loading