Merged
Conversation
criamico
added
Team:Fleet
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
cc @criamico |
juliaElastic
approved these changes
Oct 1, 2025
Contributor
juliaElastic
left a comment
juliaElastic
left a comment
There was a problem hiding this comment.
Code LGTM, were you able to test with a Windows VM?
Contributor
Author
@juliaElastic No I didn't, but I think that the issue was simply that the executable name was missing the version. Now it's present everywhere and it's the same as in the previous command: |
Contributor
|
Starting backport for target branches: 9.1, 9.3 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 1, 2025
Fixes elastic#233750 ## Summary Fix msi commands by including version number in agent executable Fleet server enrollment instructions: <img width="775" height="604" alt="Screenshot 2025-09-30 at 17 14 23" src="https://github.com/user-attachments/assets/504c785b-0599-4cf1-8117-a26d3d8fb83d" /> Agent enrollment instructions: <img width="764" height="475" alt="Screenshot 2025-09-30 at 17 32 40" src="https://github.com/user-attachments/assets/e2d18f30-0ad9-48e5-a7db-e2a0831a7fda" /> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 54da50b)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 1, 2025
# Backport This will backport the following commits from `main` to `9.1`: - [233750 msi commands (#236994)](#236994) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Cristina Amico","email":"criamico@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-10-01T08:32:25Z","message":"233750 msi commands (#236994)\n\nFixes https://github.com/elastic/kibana/issues/233750\n\n## Summary\n\nFix msi commands by including version number in agent executable\n\nFleet server enrollment instructions:\n<img width=\"775\" height=\"604\" alt=\"Screenshot 2025-09-30 at 17 14 23\"\nsrc=\"https://github.com/user-attachments/assets/504c785b-0599-4cf1-8117-a26d3d8fb83d\"\n/>\n\nAgent enrollment instructions:\n<img width=\"764\" height=\"475\" alt=\"Screenshot 2025-09-30 at 17 32 40\"\nsrc=\"https://github.com/user-attachments/assets/e2d18f30-0ad9-48e5-a7db-e2a0831a7fda\"\n/>\n\n\n### Checklist\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"54da50b1c6ccb42468b52772ad1c163e346cbac4","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Fleet","backport:version","v9.1.0","v9.2.0","v9.3.0"],"title":"233750 msi commands","number":236994,"url":"https://github.com/elastic/kibana/pull/236994","mergeCommit":{"message":"233750 msi commands (#236994)\n\nFixes https://github.com/elastic/kibana/issues/233750\n\n## Summary\n\nFix msi commands by including version number in agent executable\n\nFleet server enrollment instructions:\n<img width=\"775\" height=\"604\" alt=\"Screenshot 2025-09-30 at 17 14 23\"\nsrc=\"https://github.com/user-attachments/assets/504c785b-0599-4cf1-8117-a26d3d8fb83d\"\n/>\n\nAgent enrollment instructions:\n<img width=\"764\" height=\"475\" alt=\"Screenshot 2025-09-30 at 17 32 40\"\nsrc=\"https://github.com/user-attachments/assets/e2d18f30-0ad9-48e5-a7db-e2a0831a7fda\"\n/>\n\n\n### Checklist\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"54da50b1c6ccb42468b52772ad1c163e346cbac4"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","9.3"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/236994","number":236994,"mergeCommit":{"message":"233750 msi commands (#236994)\n\nFixes https://github.com/elastic/kibana/issues/233750\n\n## Summary\n\nFix msi commands by including version number in agent executable\n\nFleet server enrollment instructions:\n<img width=\"775\" height=\"604\" alt=\"Screenshot 2025-09-30 at 17 14 23\"\nsrc=\"https://github.com/user-attachments/assets/504c785b-0599-4cf1-8117-a26d3d8fb83d\"\n/>\n\nAgent enrollment instructions:\n<img width=\"764\" height=\"475\" alt=\"Screenshot 2025-09-30 at 17 32 40\"\nsrc=\"https://github.com/user-attachments/assets/e2d18f30-0ad9-48e5-a7db-e2a0831a7fda\"\n/>\n\n\n### Checklist\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"54da50b1c6ccb42468b52772ad1c163e346cbac4"}},{"branch":"9.3","label":"v9.3.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Cristina Amico <criamico@users.noreply.github.com>
rylnd
pushed a commit
to rylnd/kibana
that referenced
this pull request
Oct 17, 2025
Fixes elastic#233750 ## Summary Fix msi commands by including version number in agent executable Fleet server enrollment instructions: <img width="775" height="604" alt="Screenshot 2025-09-30 at 17 14 23" src="https://github.com/user-attachments/assets/504c785b-0599-4cf1-8117-a26d3d8fb83d" /> Agent enrollment instructions: <img width="764" height="475" alt="Screenshot 2025-09-30 at 17 32 40" src="https://github.com/user-attachments/assets/e2d18f30-0ad9-48e5-a7db-e2a0831a7fda" /> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #233750
Summary
Fix msi commands by including version number in agent executable
Fleet server enrollment instructions:
Agent enrollment instructions:
Checklist